summaryrefslogtreecommitdiff
path: root/libs
diff options
context:
space:
mode:
author Perry Wu <wuperry@google.com> 2024-06-06 20:33:47 +0000
committer Perry Wu <wuperry@google.com> 2024-06-06 20:45:35 +0000
commit2f3aa42739543bbe87e2d758bd696e3d696526a9 (patch)
tree1ce5cb289aebd8aaea48b78a7f111ca8959fbdc9 /libs
parent315112471443ee6ef02eddc7b89362a0880c8901 (diff)
Only update home visibility on exit pip to fullscreen
In ag/27443168 we update home visibility when expanding pip to fix a bug with overview. However this introduced a new bug where taskbar would appear when home was not visible. This fixes the second issue by only updating home visibility when we actually expand pip. Flag: N/A Bug: 340443311 Test: Manually verify taskbar doesn't appear when dismissing pip, and that we have not regressed b/340443311 when expanding pip Change-Id: I341118278faebf446800f89572176a3e52b5bb95
Diffstat (limited to 'libs')
-rw-r--r--libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java
index b52b0d8dee74..5ee6f6bb0e1f 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/pip/PipTransition.java
@@ -200,9 +200,6 @@ public class PipTransition extends PipTransitionController {
animator.cancel();
}
mExitTransition = mTransitions.startTransition(type, out, this);
- if (mPipOrganizer.getOutPipWindowingMode() == WINDOWING_MODE_UNDEFINED) {
- mHomeTransitionObserver.notifyHomeVisibilityChanged(false /* isVisible */);
- }
}
@Override
@@ -659,6 +656,9 @@ public class PipTransition extends PipTransitionController {
startTransaction.remove(mPipOrganizer.mPipOverlay);
mPipOrganizer.clearContentOverlay();
}
+ if (mPipOrganizer.getOutPipWindowingMode() == WINDOWING_MODE_UNDEFINED) {
+ mHomeTransitionObserver.notifyHomeVisibilityChanged(false /* isVisible */);
+ }
if (pipChange == null) {
ProtoLog.w(ShellProtoLogGroup.WM_SHELL_PICTURE_IN_PICTURE,
"%s: No window of exiting PIP is found. Can't play expand animation", TAG);