summaryrefslogtreecommitdiff
path: root/libs/input/PointerController.cpp
diff options
context:
space:
mode:
author Robert Carr <racarr@google.com> 2022-01-22 16:49:31 -0800
committer Rob Carr <racarr@google.com> 2022-02-09 03:05:31 +0000
commitd1de60acda2f260a1ec1a5c557affc4553189a23 (patch)
tree7d943d4fdc305ebfae783c5078cea563e052cccc /libs/input/PointerController.cpp
parent5d4aea692c574a06c6934df49c4c9195941c864e (diff)
DO NOT MERGE: WM: Call Transaction#sanitize
Various elements of the Transaction interface require a permission in order to apply. In particular the setTrustedOverlay and setInputWindowInfo fields. These permission checks are implemented by checking the PID and the UID of the process which sent the transaction. Unfortunately widespread use of transaction merging makes this inadequate. At the moment IWindowSession#finishDrawing seems to be the only boundary on which transactions move from client to system processes, and so we expose a sanitize method and use it from there to resolve the situation in an easily backportable way. Moving forward it likely make sense to move security sensitive interfaces off of Transaction. Most of the things behind permissions currently are not truly security sensitive, more of just a request not to use them. It was also considered to sanitize transactions at all process boundaries through writeToParcel, however this could be disruptive as previously permissioned processes (WM and SysUI) could freely exchange transactions. As the change needs to be backportable the lowest risk option was chosen. Bug: 213644870 Test: Existing tests pass Change-Id: I8d4a0ebe0cdfaed7ff1ad862724d49a14ed04478 (cherry picked from commit cdf139841567a625608b94339fa49cb895f6a69f)
Diffstat (limited to 'libs/input/PointerController.cpp')
0 files changed, 0 insertions, 0 deletions