summaryrefslogtreecommitdiff
path: root/libs/input/PointerController.cpp
diff options
context:
space:
mode:
author Lee Jones <joneslee@google.com> 2024-07-22 08:14:49 +0000
committer Lee Jones <joneslee@google.com> 2024-07-23 07:11:02 +0000
commit5ffb91e00f058942b75afe7d8a948095a2da2e31 (patch)
treee09d6d6a329b6d138076d244208e06bd0a1e4ebe /libs/input/PointerController.cpp
parent3db716220a46b4b285a441da020b29531f1b1204 (diff)
Fix NullPointerException in android.widget.TimePickerSpinnerDelegate.updateInputState
Commit 2a757ef4aea5 ("Add @hide IMM#hideSoftInputFromView as an optimization") assumed that 'mAmPmSpinnerInput' will always be assigned at this point. However in the case where users choose 24hr format, is it left as null. Providing a null check prevents the following splat: FATAL EXCEPTION: main java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.widget.EditText.hasFocus()' on a null object reference at android.widget.TimePickerSpinnerDelegate.updateInputState(TimePickerSpinnerDelegate.java:480) [...] Bug: 296466613 Fix: 333670354 Fix: 324375857 Fix: 324504911 Test: atest CtsInputMethodTestCases:TimePickerImeSupportTest Change-Id: Id125ea4da75803d490b5e09eec7554ce97e46937 Signed-off-by: Lee Jones <joneslee@google.com>
Diffstat (limited to 'libs/input/PointerController.cpp')
0 files changed, 0 insertions, 0 deletions