summaryrefslogtreecommitdiff
path: root/libs/hwui/PathParser.cpp
diff options
context:
space:
mode:
author Matías Hernández <matiashe@google.com> 2024-09-30 12:47:24 +0200
committer Matías Hernández <matiashe@google.com> 2024-09-30 12:54:25 +0200
commit38de1a3f76c189866a259d932ceac77b90e62836 (patch)
tree3f63042e231fe235b2ed1ff56a17dc90b401214e /libs/hwui/PathParser.cpp
parent6f273d49d27074107a6984ddebba4c3186bac00f (diff)
Fix reading of ZenModeConfig.manualRule in MODES_UI transition
Presence of the manualRule on pre-modes_ui xml meant that DND was active, thus to preserve this state when upgrading to modes_ui we must set a condition with STATE_TRUE. This conversion already existed, but it had an issue -- if the rule didn't have a conditionId set (very likely, since only DND-with-a-timeout adds one) then the result of the conversion would be a rule with _null_ conditionId but a condition with _empty_ id. This mismatch caused the isValidConfig() check to fail, thus discarding the previous configuration altogether! This issue manifested as "rules are gone on flag flip" (although this wouldn't be noticeable if only "default" rules, like the built-in ones or Bedtime, were the only ones present). It also resulted in DND turning off. Fixes: 369678857 Test: atest ZenModeConfigTest Flag: android.app.modes_ui Change-Id: I2787e8593b5305bfbe07681c5d0b5e19a3c12ed0
Diffstat (limited to 'libs/hwui/PathParser.cpp')
0 files changed, 0 insertions, 0 deletions