diff options
| author | 2022-10-24 19:57:43 -0400 | |
|---|---|---|
| committer | 2022-11-11 16:13:25 -0500 | |
| commit | 892cac2025cfecf42a2626911f04a5910d1097e9 (patch) | |
| tree | 2388433afb7e7c50c21fb373b9e89c76da8f5188 /libs/hwui/FrameInfoVisualizer.cpp | |
| parent | 57ff4b4589c0c8aeffc7cd585e379a5b40b4d1d2 (diff) | |
Fix erroneous self deletion on SkImage creation failure
TL;DR: Skia should always call releaseProc, and maybe sooner than we thought.
There are multiple scenarios where SkImage:MakeFromTexture will fail,
returning a nullptr and calling releaseProc due to a RefCntedCallback
falling out of scope. Previously this could cause mUsageCount to fall to
0, resulting in the AutoBackendTextureRelease deleting itself even
though DeferredLayerUpdater owned a ref and expected it to still exist.
Also added logging for some reasons that could cause the later call to
MakeFromTexture to fail.
Bug: b/246831853
Test: hwui_unit_tests
Change-Id: I7fd2566b9a85fe286f72b0fc42eba5450cac69b0
Merged-In: I7fd2566b9a85fe286f72b0fc42eba5450cac69b0
Diffstat (limited to 'libs/hwui/FrameInfoVisualizer.cpp')
0 files changed, 0 insertions, 0 deletions