diff options
| author | 2025-03-05 19:14:05 +0000 | |
|---|---|---|
| committer | 2025-03-05 19:31:10 +0000 | |
| commit | d2ecdf180bf3dc9a7a526b73c0f0b93f724de304 (patch) | |
| tree | cd8a60b5a8fe4f915b758356d11d291d28e53c11 /libs/hostgraphics/HostBufferQueue.cpp | |
| parent | 7aec8c1a2889192f517ce4daa97b6d2db0be8ea2 (diff) | |
Don't cancel the entire backup if agent disconnects and log if the agent pipe is broken
Normally the bug fix and the extra logging should be in separate CLs.
However as explained in the linked bug, there is a race condition
between the method throwing the IOException returning and us getting a
cancellation callback from ActivityManager. If we get the callback
first, the session fails. The extra IPC from the logging in handling the
exception means the callback gets a few additional milliseconds to win
the race. So with the logging, the race condition is much more likely to
happen and the logging should not be checked in without the bug fix. And
if one gets rolled back, the other should as well. This is why I made
them a single CL.
Flag: EXEMPT bugfix
Bug: 400669414
Test: manual // PFTBT is notoriously impossible to write unit tests for.
Change-Id: Icbcb72a876f927a94675c9837b0206f1a631dff5
Diffstat (limited to 'libs/hostgraphics/HostBufferQueue.cpp')
0 files changed, 0 insertions, 0 deletions