diff options
| author | 2025-01-25 18:31:33 +0000 | |
|---|---|---|
| committer | 2025-01-27 17:00:33 +0000 | |
| commit | 5a0147f03387937ec30167bb01c03a4d43e776c5 (patch) | |
| tree | 9d2eae9461bd403c45436b402ac8183746247b4e /libs/androidfw/Util.cpp | |
| parent | 10959b9e4b9a986428f827f0c494197c5a02ca56 (diff) | |
Redesigned Add Shortcut Dialog Edit Box
The add shortcut dialog has a box where the users' selected key
combination is shown. Previously this box was just a clickable surface
that displayed some text/icon composable.
There are some downsides to this design:
1. No blinking cursor to show the user that they're currently editing.
2. A11y - No talkback actions on double click despite talback reading
"double tap to activate"
The main consideration for not using a textfield composable previously
was that textfields can only show text, but keyboard keys can be
represented as text or glyphs(drawables) which traditional textfields
don't support.
This CL implements a custom InputField composable `OutlinedInputField`
which has all the benefits of a text field(blinking cursor, A11y
features) but rather than displaying just text, it generally supports
displaying any composable content which can be text, icon, or anything
else.this solution hence addresses both Downsides to the previous
design.
Test: Manual - Ensure the desired behaviour is observed in the add
shortcut dialog.
Flag: com.android.systemui.keyboard_shortcut_helper_shortcut_customizer
Fix: 390278358
Fix: 390102227
Fix: 390281127
Bug: 387995731
Change-Id: Ic5af2c9ba06a8cd0c204f742804d6202f2043e8a
Diffstat (limited to 'libs/androidfw/Util.cpp')
0 files changed, 0 insertions, 0 deletions