summaryrefslogtreecommitdiff
path: root/libs/androidfw/StringPool.cpp
diff options
context:
space:
mode:
author Chiachang Wang <chiachangwang@google.com> 2022-03-08 10:50:14 +0800
committer Cherrypicker Worker <android-build-cherrypicker-worker@google.com> 2022-06-02 09:54:24 +0000
commitfe57c5bf892c54c495cacd23492532bfa9a63dd7 (patch)
tree9a944768c044183095eb4ad1e2e7e3e46f1f8f3e /libs/androidfw/StringPool.cpp
parentb1cf2a0cd2d1c8dafe89418ae6be075ed6784494 (diff)
Stop using invalid URL to prevent unexpected crash
Verify the input PAC Uri before performing follow-up actions. Check if the URL is a valid URL to filter some invalid URLs since these invalid URLs could not fall into any subclass of existing URLConnections. When the PAC Uri is other invalid URL scheme, it will cause an UnsupportedOperationException if there is no proper subclass that implements the openConnection() method. A malformed URL may crash the system. Even it's a valid URL, some subclasses(e.g. JarURLConnection) may not have openConnection() implemented. It will also hit the problem, so convert the possbile exception from openConnection() to re-throw it to IOException which is handled in the existing code. Bug: 219498290 Test: atest FrameworksNetTests CtsNetTestCases Test: Test with malformed URL Change-Id: I22903414380b62051f514e43b93af992f45740b4 (cherry picked from commit 6390b37a3b32fc7583154d53fda3af8fbd95f59f) Merged-In: I22903414380b62051f514e43b93af992f45740b4
Diffstat (limited to 'libs/androidfw/StringPool.cpp')
0 files changed, 0 insertions, 0 deletions