summaryrefslogtreecommitdiff
path: root/libs/androidfw/StringPool.cpp
diff options
context:
space:
mode:
author Nan Wu <wnan@google.com> 2025-01-19 18:33:31 +0000
committer Nan Wu <wnan@google.com> 2025-01-29 14:14:35 +0000
commitf82f5ede5a1c71612461fd0be640701f8d5e3d87 (patch)
tree146ef19fa0a4022c3f4353cf8c7ba39c26c19c92 /libs/androidfw/StringPool.cpp
parentc7bd665fb7edf7fb68a098ff7a3f2f6c35e9f2c7 (diff)
Fix collect extra intent keys on server.
There are 2 issues: 1. in order to improve performance, we only collect keys on server if the extra bundle contains intent. This was indicated with a bit flag stored in BaseBundle.mFlags. However, the field mFlags is not parceled/unparceled. So that won't work - the flag is turned on on the client side and checked on the server side. To fix it, use a boolean member and parcel it. 2. This bug is discovered when investigating b/377190225. We found out that in collectNestedIntenKeysRecur, the intent was marked as keys are collected before it actually collects it. A recent change (do not unparcel a bundle when collecting keys) means calling this method may not have collected keys if the bundle is parceled. The fix is to move the line below after the bundle is unparceled. Bug: 377190225 Test: manual Flag: EXEMPT bug fix Change-Id: I645ded2f1e3422c9297962da47f93ca59f6f0b55
Diffstat (limited to 'libs/androidfw/StringPool.cpp')
0 files changed, 0 insertions, 0 deletions