summaryrefslogtreecommitdiff
path: root/libs/androidfw/StringPool.cpp
diff options
context:
space:
mode:
author Caitlin Shkuratov <caitlinshk@google.com> 2023-06-22 14:15:22 +0000
committer Caitlin Shkuratov <caitlinshk@google.com> 2023-07-05 14:00:02 +0000
commitb91c2972e46415f426fa7c9c4ffa1453c6254a67 (patch)
tree5a38e04a4e182050fd78ac1fc3884021bceeb967 /libs/androidfw/StringPool.cpp
parent4b6517670ae6e9f8f40f860770d905b085eeb8d3 (diff)
[Status Bar] Use `defaultDataSubId` flow to trigger config re-fetch.
The root cause of b/285298304 is that, because no downstream work was collecting on the `defaultDataSubId` flow *directly*, that flow was never starting. So, we were never listening for `ACTION_DEFAULT_DATA_SUBSCRIPTION_CHANGED` intent and were not re-fetching the config when the default subscription changed. However, this bug was masked by the `config_subIdChangeEvent_updated` test, which was incorrectly passing. It was passing because FakeBroadcastDispatcher was sending the `ACTION_DEFAULT_DATA_SUBSCRIPTION_CHANGED` intent to the `carrierConfigChangedEvent` receiver, even though that receiver did *not* match the intent. This CL: 1) Updates FakeBroadcastDispatcher to send intents only to receivers that match the intent. 2) Updates `config_subIdChangeEvent_updated` test to use the new FakeBroadcastDispatcher method, causing the test to fail. 3) Updates MobileConnectionsRepositoryImpl to collect on `defaultDataSubId` flow directly, causing the test to pass again. Fixes: 285298304 Test: atest MobileConnectionsRepositoryTest#config_subIdChangeEvent_updated Change-Id: I007751b4a6279569311362cd14410f053a6a47f2 Merged-In: I007751b4a6279569311362cd14410f053a6a47f2 (cherry picked from commit 99e2da7a6cc8956364eee85dd9696875ab806de0)
Diffstat (limited to 'libs/androidfw/StringPool.cpp')
0 files changed, 0 insertions, 0 deletions