summaryrefslogtreecommitdiff
path: root/libs/androidfw/StringPool.cpp
diff options
context:
space:
mode:
author Mady Mellor <madym@google.com> 2024-03-13 10:31:53 -0700
committer Mady Mellor <madym@google.com> 2024-03-14 15:28:31 -0700
commitadb6d81bbbdebc59f1bbffd1cc5fad445b852212 (patch)
tree406f38ae0b7135e92221cfa18bccced17fb54a24 /libs/androidfw/StringPool.cpp
parent723bced5290def96fad24421a9cefa988072a66e (diff)
Only reorder bubbles if the position is different
This was be run needlessly during an insets change event while bubbles were being collapsed, this causes a jump in the animation. To fix, let's skip the reorder if it's not necessary. Additionally, the reorder code path would trigger updating the bubble positions -- this is needed after an orientation change, and was happening after the overflow was reordered as a side effect. Now that we're skipping needless reorders, this doesn't happen so a call is added to explicitly update the positions of the bubbles after the orientation change to fix it. Bug: 318704215 Test: manual - have a bubble that hides the nav bar when its opened - move the bubble to a non-default location - expand and collapse the bubble => observe when collapsing the animation looks fine - have multiple bubbles, expand them, rotate the device => observe that the positions are correct Change-Id: I6c2d83d54d05260bc221c5d24622cdaaa1f7f467
Diffstat (limited to 'libs/androidfw/StringPool.cpp')
0 files changed, 0 insertions, 0 deletions