diff options
| author | 2021-08-30 15:01:29 -0700 | |
|---|---|---|
| committer | 2021-09-03 17:03:23 +0000 | |
| commit | aacc61be3dedac7e0717433fafed39e15deb3abc (patch) | |
| tree | 9b13ddfd8adb29282538707f0b2849be76944677 /libs/androidfw/StringPool.cpp | |
| parent | 1cf6b4ea68595b7341288a6ae002187a3559f738 (diff) | |
Surface: Release references to BlastBufferQueue and SurfaceControl on Surface#destroy
SurfaceView clients may hold on to surface references. In S this means
they would extend the lifetime of the SurfaceControl resulting in
"leaking" buffers until the references are cleared or the app is
terminated.
Fix this by calling a new destroy function on Surface which will
explicitly remove references to the SurfaceControl and BBQ it holds.
This is safe because SurfaceView controls the lifecycle of the Surface
and knows when the Surface will become invalid. Once invalid, the Surface
cannot become valid again.
Test: repro steps in bug
Bug: 198133921
Change-Id: I5c7e43736f025fc0965eae2f19719ba40df3cb70
Merged-In: I5c7e43736f025fc0965eae2f19719ba40df3cb70
Diffstat (limited to 'libs/androidfw/StringPool.cpp')
0 files changed, 0 insertions, 0 deletions