summaryrefslogtreecommitdiff
path: root/libs/androidfw/StringPool.cpp
diff options
context:
space:
mode:
author Winson Chung <winsonc@google.com> 2022-07-21 05:49:36 +0000
committer Winson Chung <winsonc@google.com> 2022-08-02 18:15:40 +0000
commit91a416bae90b93bcf32b0f41b5df3c0e7b29a6f3 (patch)
tree9b644384ea1c4fee75bbd4c40ef3a149fe8fa365 /libs/androidfw/StringPool.cpp
parent68de89974b8ea84232e4b0ffda5b509e4928d0fa (diff)
3/ Fix inverted ShellInit dependency order (no functional changes)
- We were previously initializing components manually because some startup is order-dependent, which led to an increasing number of dependencies from ShellTaskOrganizer on things that it really doesn't need to know about. The initialization order actually matches the dependency order pretty closely, so instead we can have these components add callbacks in the order they are created and initalize in sequence. - Also move some logic out of constructors to the init callback - The other subtle issue is that the provider for ShellInitImpl was implicitly also ensuring that certain shell components were created at startup (since they aren't otherwise referenced by any SysUI component directly or indirectly). Instead, separate that out into another more explicit provider, with the @ShellCreateTrigger annotation, and allow subclasses to provide a @ShellCreateTriggerOverride annotated provider for product-specific initialization Test: atest WMShellUnitTests Test: atest SystemUITests Bug: 238217847 Change-Id: I4a2583ceeaf469130ac07fc8c4e267c28843b7b8 Signed-off-by: Winson Chung <winsonc@google.com>
Diffstat (limited to 'libs/androidfw/StringPool.cpp')
0 files changed, 0 insertions, 0 deletions