summaryrefslogtreecommitdiff
path: root/libs/androidfw/StringPool.cpp
diff options
context:
space:
mode:
author Yohei Yukawa <yukawa@google.com> 2022-01-20 20:40:52 -0800
committer Yohei Yukawa <yukawa@google.com> 2022-01-20 20:40:52 -0800
commit6495e3c93be9e6908e3d3c50e02a3a4095fbc7fe (patch)
treea5ef8298611415d03fd1b08c03e6219f60d971da /libs/androidfw/StringPool.cpp
parent20ba147a1138be3ea40d7e20651ac5dd83afab1e (diff)
Clarify how IMMS#executeOrSendMessage() works
This CL attempts to clarify how InputMethodManagerService#executeOrSendMessage() has been actually working, that is, probably to emulate oneway Binder IPC semantics in case the target IInterface object is an in-process Binder object, which is quite important to avoid dead-locks. However, using it for IInputMethod objects is overkill because we have never officially supported IMEs running in the system_server process. There is no reason to define MSG_* for those cases. As the initial step towards cleaning up those unnecessarily defined switch cases, this CL introduces a new overload method InputMethodManagerService#executeOrSendMessage(IInputMethod, Message) to make it clear that it always immediately invokes InputMethodManagerService#handleMessage() if the target is IInputMethod. The actual removal of InputMethodManagerService#executeOrSendMessage(IInputMethod, Message) will be done through subsequent CLs. To summarize, there should be no observable behavior change unless someone is surprisingly running InputMethodService in the system_server process. Bug: 215609403 Test: presubmit Change-Id: I0c4aab9a0974857e531be4fb1fc75980b36f4443
Diffstat (limited to 'libs/androidfw/StringPool.cpp')
0 files changed, 0 insertions, 0 deletions