diff options
| author | 2023-08-09 23:43:37 -0700 | |
|---|---|---|
| committer | 2023-08-31 19:06:45 -0700 | |
| commit | 42d2e51bf78bec72031e5f7a70422851b302d1f4 (patch) | |
| tree | 1325e08734a349786c7e699bb00b2e4f928e7ea8 /libs/androidfw/StringPool.cpp | |
| parent | 41e15a0f45e4adc9d8193efd0933e6ca879b3c22 (diff) | |
Fix std::unique_ptr error with incomplete CommonFeatureGroup
After upgrading libc++, Clang fails to compile DumpManifest.cpp.
prebuilts/clang/host/linux-x86/clang-r498229/include/c++/v1/__memory/unique_ptr.h:63:19: error: invalid application of 'sizeof' to an incomplete type 'aapt::CommonFeatureGroup'
static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
^~~~~~~~~~~
Fix the problem by deferring the instantiation of ~unique_ptr, by
making the ManifestExtractor constructor out-of-line and moving it and
the initialization of commonFeatureGroup_ to a point after
CommonFeatureGroup has been defined.
Bug: b/175635923
Test: treehugger
Change-Id: I9ab51f29724fded24773344aa36763ffeea02d00
Diffstat (limited to 'libs/androidfw/StringPool.cpp')
0 files changed, 0 insertions, 0 deletions