summaryrefslogtreecommitdiff
path: root/libs/androidfw/ObbFile.cpp
diff options
context:
space:
mode:
author Miranda Kephart <mkephart@google.com> 2023-03-20 16:45:11 -0400
committer Miranda Kephart <mkephart@google.com> 2023-03-20 16:45:11 -0400
commitc32dc80a907ebe33a946b7bb9e56baa3d7778281 (patch)
treecb57fa5a391db684098ff064150f5199f01a0068 /libs/androidfw/ObbFile.cpp
parent0f351cb629dc5654954957875868b7e9edb80206 (diff)
Register clipboard toast callback correctly
If something is copied to the clipboard before user setup is complete, we just show a toast instead of the full UI, to prevent the user from being able to access intents they shouldn't be able to. In this case, we have a callback to reset the internal variable when the toast is hidden, but we never actually register the callback. This has very little effect in practice, since a) all of this code is only run if user setup is incomplete (or if the copied data is null, which shouldn't happen) and b) the incorrect state, where we should show the toast and don't, will only occur if we somehow get the second, post-text-classification clipboard update without getting the initial update. That said, this should still be fixed for clarity and correctness. This change registers the callback so that we reset the clipboard toast to null once it's hidden. Bug: 272035606 Test: manual Change-Id: I4bcc3bd85f6242ff4815c21d5a6a7f9d24045cd5
Diffstat (limited to 'libs/androidfw/ObbFile.cpp')
0 files changed, 0 insertions, 0 deletions