summaryrefslogtreecommitdiff
path: root/libs/androidfw/ObbFile.cpp
diff options
context:
space:
mode:
author Johannes Gallmann <gallmann@google.com> 2024-07-16 15:12:12 +0200
committer Johannes Gallmann <gallmann@google.com> 2024-07-17 05:47:45 +0000
commit8bea4595d5c3e645abe8cee215af45bb861ab9c9 (patch)
tree5e396c5796d6e05818f9ecc02fc71e0491527022 /libs/androidfw/ObbFile.cpp
parent1d1a9c342414ab00049525e128dfcc13bf24effa (diff)
Fix pointers pilfered when they shouldn't be
When onThresholdCrossed is called and mBackNavigationInfo==null, we should't pilfer pointers if onBackNavigationInfoReceived has not been called before. Because it is possible that onThresholdCrossed is called before onBackNavigationInfoReceived is called. In that case mBackNavigationInfo is always null even though it may be set shortly after when onBackNavigationInfoReceived is called. The issue can be reproduced for example with the IME predictive back animation in the Google Photos app. When executing the back gesture extremely fast, there is sometimes no predictive back animation on the IME because onThresholdCrossed is called before onBackNavigationInfoReceived. Therefore we should add an additional check that verifies that onBackNavigationInfoReceived was indeed already called. Bug: 351763151 Flag: com.android.window.flags.predictive_back_system_anims Test: Manual, i.e. verifying that very quick back swipes do not cause pointers to be pilfered when they shouldn't be. Change-Id: Icadead2be06dad724bca7f27704edbe5627beeac
Diffstat (limited to 'libs/androidfw/ObbFile.cpp')
0 files changed, 0 insertions, 0 deletions