summaryrefslogtreecommitdiff
path: root/libs/androidfw/ObbFile.cpp
diff options
context:
space:
mode:
author Ikram Gabiyev <gabiyev@google.com> 2024-12-23 14:21:11 -0800
committer Ikram Gabiyev <gabiyev@google.com> 2024-12-23 14:37:29 -0800
commit440881550bca524db0934649cea920ac9be60f4f (patch)
tree0d0d01f6a8560fa4fc68f214bdcadf24f06ca570 /libs/androidfw/ObbFile.cpp
parent48b4b671d7c790cf3d2f471b50d7193e539a467f (diff)
[1/2][PiP2] Move removePip animation to transition
PiP1 currently relies on force-hideen flag to guarantee the order of onStop() and onPictureInPictureModeChanged() callbacks being sent to client. Therefore, PiP1 first runs the fade-out animation separately before starting a jumpcut removePip transition. In PiP2, we wanna avoid synchronization issues through moving deterministic animations into transitions. Hence, we wanna run the fadeout animation while the TRANSIT_REMOVE_PIP is playing. 1. This means we should not rely on force-hidden flag in PiP2, as that would stop activity immediately before we even start fade-out 2. Currently setting windowing mode, which updates config in Core, also ends up scheduling PiP mode change directly. We shouldn't have this direct scheduling done, as a transition will make sure to update and send config and lifecycle state updates at the right time (in this case isVisibleRequested=false -> so finishTransition would handle it). Bug: 381017000 Flag: com.android.wm.shell.enable_pip2 Test: atest PipSchedulerTest Test: atest PinnedStackTests#testStopBeforeMultiWindowCallbacksOnDismiss Test: atest SwipeUpAppToPipTestsChrome#testSwipeUpToPipForMocked Change-Id: Ic1698f273257d63aebd07dda1881d2c2afa7f516
Diffstat (limited to 'libs/androidfw/ObbFile.cpp')
0 files changed, 0 insertions, 0 deletions