diff options
| author | 2023-06-28 12:37:18 +0200 | |
|---|---|---|
| committer | 2023-07-12 13:33:39 +0200 | |
| commit | fed109a5eeab5efafc42800d7a7fae8c5bdab438 (patch) | |
| tree | 0b5d767ee75177f95f2914958b53627b44f004dd /libs/androidfw/FileStream.cpp | |
| parent | e6ac1838482a36aa3626c1c059c118294411e877 (diff) | |
Fix SHOW_IMPLICIT and SHOW_EXPLICIT handling
This fixes a bug introduced in the refactor from [1], where
SHOW_IMPLICIT and SHOW_EXPLICIT requests would not be handled correctly,
as they represent the same underlying bit flag value.
IntDefs were added to help understand which set of flags to use
based on call site. Requests originating from InputMethodManager
(and a few from InputMethodService) must utilise InputMethodManager
flags (i.e SHOW_IMPLICIT). When reaching the ImeVisibilityStateComputer,
these are translated to InputMethodService flags (i.e. SHOW_EXPLICIT).
Additonally, this documents and tests that `ImeVisibilityStateComputer`
keeps the strongest state set until a hide request (i.e. an implicit
show request just after a forced / explicit show request, without
any hide requests in between, will still have the
forced / explicit state set).
[1]: Id1115ceb951e4bb0361a32b824d966cc70b7d132
Bug: 289188559
Test: atest DefaultImeVisibilityApplierTest ImeVisibilityStateComputerTest
com.android.inputmethodservice.InputMethodServiceTest
Change-Id: I0fde7ea4cec99e739eb4541cc206daa191661689
Diffstat (limited to 'libs/androidfw/FileStream.cpp')
0 files changed, 0 insertions, 0 deletions