summaryrefslogtreecommitdiff
path: root/libs/androidfw/FileStream.cpp
diff options
context:
space:
mode:
author Austin Borger <borgera@google.com> 2023-03-03 15:44:28 -0800
committer Austin Borger <borgera@google.com> 2023-03-06 20:24:12 +0000
commit7cb165f1c02e8c5a3093bb331e084b0fa6a32e90 (patch)
treea9e3772d0cacecbd78a0b9a3c2820772760bd987 /libs/androidfw/FileStream.cpp
parent7b47cfafd87a5bfdad69000e34895847edf20fcd (diff)
Fix vulnerability in AttributionSource due to incorrect Binder call
AttributionSource uses Binder.getCallingUid to verify the UID of the caller from another process. However, getCallingUid does not always behave as expected. If the AttributionSource is unparceled outside a transaction thread, which is quite possible, getCallingUid will return the UID of the current process instead. If this is a system process, the UID check gets bypassed entirely, meaning any uid can be provided. This patch fixes the vulnerability by emptying out the state of the AttributionSource, so that the service checking its credentials will fail to give permission to the app. Bug: 267231571 Test: v2/android-virtual-infra/test_mapping/presubmit-avd Merged-In: Ic301a8518b8e57e1c9a2c9f2f845e51dca145257 Change-Id: Ic985afdb5e4495f2e051e6d0d62d39c6660c585e
Diffstat (limited to 'libs/androidfw/FileStream.cpp')
0 files changed, 0 insertions, 0 deletions