diff options
| author | 2023-09-06 16:09:44 +0000 | |
|---|---|---|
| committer | 2023-09-14 20:03:23 +0000 | |
| commit | 2a9dd990d53a7ace8b070f049e18c00df98bf9b2 (patch) | |
| tree | ebc34dcccc3809bb5647ebab5a2cc2c8059cdb48 /libs/androidfw/AssetsProvider.cpp | |
| parent | 604858750cee32b4314dfa007dc9e7245bde19fb (diff) | |
Refactor of LargeScreenUtils.shouldUseLargeScreenShadeHeader
Primary reason for refactor is to include flagging - so split shade on small landscape screens can be flag-guarded.
Refactor:
- removed static methods LargeScreenUtils.shouldUseLargeScreenShadeHeader
- now using SplitShadeStateController.shouldUseSplitNotificationShade
- SplitShadeStateController is injected or passed when necessary
- flag guarding can now be done in SplitShadeStateController.shouldUseSplitNotificationShade
- FakeSplitShadeStateController is passed in test classes
Improvements that could be made in a follow up CL:
- no longer need resources as a parameter for shouldUseLargeScreenShadeHeader, context can be injected and then context.resources could be used internally
- StateFlow could be used, this could be subscribed to instead of checking shouldUseLargeScreenShadeHeader in 'updateResources' methods.
- Improvements ignored for now to reduce the size of the change and speed up review
Now, when LOCKSCREEN_ENABLE_LANDSCAPE is on: split shade is used on small landscape screens.
Bug: 293252410
Test: See files
Change-Id: If35ad6d5e095f15e037b0d2bb58f346758966379
Diffstat (limited to 'libs/androidfw/AssetsProvider.cpp')
0 files changed, 0 insertions, 0 deletions