summaryrefslogtreecommitdiff
path: root/libs/androidfw/AssetManager2.cpp
diff options
context:
space:
mode:
author Ryan Prichard <rprichard@google.com> 2023-09-06 18:21:44 -0700
committer Ryan Prichard <rprichard@google.com> 2023-09-06 18:29:05 -0700
commite8e793a340c87d650a73a29d7915f12e1dc6146b (patch)
tree61c2bfaeac83ac596ac043a7c341cd5d9679a6cb /libs/androidfw/AssetManager2.cpp
parentb303b74e0fa22c1167cfc668e8eb50c99688400c (diff)
[RESTRICT AUTOMERGE] Move Theme::Entry definition to top of file
It needs to be at least above this line: theme->entries_.reserve(kInitialReserveSize); Otherwise, after upgrading libc++, the compiler fails with errors about an incomplete type, e.g.: include/c++/v1/vector:839:62: error: arithmetic on a pointer to an incomplete type 'android::Theme::Entry' include/c++/v1/__memory/uninitialized_algorithms.h:609:5: error: cannot increment value of type 'std::reverse_iterator<android::Theme::Entry *>' Bug: b/175635923 Test: treehugger Change-Id: I6c231184c3a4c0e67dd29d43560b0c28778883db Merged-In: I6c231184c3a4c0e67dd29d43560b0c28778883db
Diffstat (limited to 'libs/androidfw/AssetManager2.cpp')
-rw-r--r--libs/androidfw/AssetManager2.cpp14
1 files changed, 7 insertions, 7 deletions
diff --git a/libs/androidfw/AssetManager2.cpp b/libs/androidfw/AssetManager2.cpp
index fc9dd145dc5d..5777fb851ab5 100644
--- a/libs/androidfw/AssetManager2.cpp
+++ b/libs/androidfw/AssetManager2.cpp
@@ -99,6 +99,13 @@ struct FindEntryResult {
StringPoolRef entry_string_ref;
};
+struct Theme::Entry {
+ uint32_t attr_res_id;
+ ApkAssetsCookie cookie;
+ uint32_t type_spec_flags;
+ Res_value value;
+};
+
AssetManager2::AssetManager2() {
memset(&configuration_, 0, sizeof(configuration_));
}
@@ -1411,13 +1418,6 @@ Theme::Theme(AssetManager2* asset_manager) : asset_manager_(asset_manager) {
Theme::~Theme() = default;
-struct Theme::Entry {
- uint32_t attr_res_id;
- ApkAssetsCookie cookie;
- uint32_t type_spec_flags;
- Res_value value;
-};
-
namespace {
struct ThemeEntryKeyComparer {
bool operator() (const Theme::Entry& entry, uint32_t attr_res_id) const noexcept {