summaryrefslogtreecommitdiff
path: root/libs/androidfw/ApkParsing.cpp
diff options
context:
space:
mode:
author Haoran Zhang <haoranzhang@google.com> 2023-02-18 00:05:49 +0000
committer Haoran Zhang <haoranzhang@google.com> 2023-02-23 23:34:11 +0000
commit8e3f12f30546380c6fe7564adc5344c7e4b4380e (patch)
treeeac1359e7576bb74b671746de8dba651efb2161f /libs/androidfw/ApkParsing.cpp
parent5d3be7c0533cc40def6f686923cf05204a982ff6 (diff)
Since we are using string.subString(startIndex, endIndex) when parsing
denylist, we should make sure startIndex <= endIndex before calling string.substring(). Otherwise, an index out of bound excpetion would throw and make the app terminate. This could happen if we are not careful with the denylist and make the denylist wrong formatted. For example, a ";" is left out in the end, and startIndex in this case would become -1. When we find the denylist is not properly formatted on framework, we could print an error in log stating the denylist is wrongly formatted and go ahead treating this app as not denied. Test: atest cts/tests/autofillservice/src/android/autofillservice/cts/servicebehavior/AutofillForAllAppsTest.java Bug:269775456 Change-Id: I7fb87ec18880550a07533d6be079991268120041
Diffstat (limited to 'libs/androidfw/ApkParsing.cpp')
0 files changed, 0 insertions, 0 deletions