summaryrefslogtreecommitdiff
path: root/libs/androidfw/ApkParsing.cpp
diff options
context:
space:
mode:
author Ioana Alexandru <aioana@google.com> 2023-03-07 19:31:22 +0000
committer Ioana Alexandru <aioana@google.com> 2023-03-07 19:38:04 +0000
commit2de48461731828e8df4d146eb55520c1b41543ed (patch)
treed9405ff089e80a3442e2ca4141351fdf4e29e86f /libs/androidfw/ApkParsing.cpp
parente8544a37420639fdcc2854c6a5eeb09607168e22 (diff)
Use backgroundColor for the old toast layout.
Some history necessary to understand why this is needed: - From Android R, we started rendering text toasts in System UI instead of having them rendered by the app. As a result, we have two separate layouts for toasts: * targetSdk < 30: transient_notification.xml (rendered by the app) * targetSdg >= 30: text_toast.xml (rendered by SystemUI) - We previously used backgroundColor for the toast background (toastFrameBackground), but we moved to using surfaceColor (a system color which matches the device theme). The problem is that surfaceColor isn't available when the toast is rendered by the app though, leading to weird behaviors like showing light grey text on a white background if the app's theme is material dark. To fix this, we should still use backgroundColor (like before) for toasts that are rendered by the app. Fix: 245678793 Test: manually triggered toast from app targeting SDK 29, observed color is correct Change-Id: I7ab1991c628b85f01391e41b6a03b3bd7f219058
Diffstat (limited to 'libs/androidfw/ApkParsing.cpp')
0 files changed, 0 insertions, 0 deletions