summaryrefslogtreecommitdiff
path: root/graphics/java
diff options
context:
space:
mode:
author John Reck <jreck@google.com> 2023-05-18 18:10:26 -0400
committer John Reck <jreck@google.com> 2023-05-18 18:10:26 -0400
commitf0c528ab6ed64b3a551d555bf7cb77f39c571fd7 (patch)
treefbcb7b0394b6c0324b2d395bc017fe1010229a5c /graphics/java
parentf11d33ba2cb32aeccb366821aef7734758f1a059 (diff)
Fix RippleDrawable alpha
Alpha was being double-applied by being both handled in the shader and applied by the Paint. So change the Paint to not apply the alpha since the shader does it. Fixes: 272375156 Test: looked at ripples in dark & light theme, verified no visual change Change-Id: I6ca4d32a7a5735ce8ec418014d0318c29dd3c8bf
Diffstat (limited to 'graphics/java')
-rw-r--r--graphics/java/android/graphics/drawable/RippleDrawable.java3
1 files changed, 2 insertions, 1 deletions
diff --git a/graphics/java/android/graphics/drawable/RippleDrawable.java b/graphics/java/android/graphics/drawable/RippleDrawable.java
index 4d0a05811dbf..641a2ae7b2c3 100644
--- a/graphics/java/android/graphics/drawable/RippleDrawable.java
+++ b/graphics/java/android/graphics/drawable/RippleDrawable.java
@@ -1013,7 +1013,8 @@ public class RippleDrawable extends LayerDrawable {
}
p.setShader(shader);
p.setColorFilter(null);
- p.setColor(color);
+ // Alpha is handled by the shader (and color is a no-op because there's a shader)
+ p.setColor(0xFF000000);
return properties;
}