diff options
| author | 2024-10-14 12:33:33 +0200 | |
|---|---|---|
| committer | 2025-01-17 16:07:10 +0100 | |
| commit | 1d0b620cea46d3f154428d73c6489e235fe83439 (patch) | |
| tree | 9a8859e39c0b5752455d53e6c5463d267a84654d /api/coverage/tools | |
| parent | 80db1783bd3404efeba59e304fb6e551dc67a249 (diff) | |
Use correct navigation hint for IME visibility
The system navigation bar and taskbar were correctly computing the
navigation hint flags, but using the incorrect flag
(navigation_hint_back_alt) to save the state of the IME visibility.
While this back_alt flag can only ever be set while the IME is visible,
it can also be unset when the IME is visible. In practice, any IME can
override this to be unset while the IME is visible, and the system also
temporarily overrides it while the IME Switcher menu is visible. This
would lead to the navigation bar/taskbar incorrectly beliving the IME is
not visible.
Additionally renames onImeVisibilityChanged (introduced in [1]) to
onBackAltChanged, to reflect the original meaning from [2].
This fixes the IME visibility state to be computed based on the
navigation_hint_ime_shown flag.
[1]: I6034d66532d83d7f12b5e7d65610d4aa91b3533f
[2]: Ifd1f8c9f400d90542f0ca858b9a4deacabbd518a
Flag: EXEMPT bugfix
Bug: 366129400
Test: atest NavigationBarTest#testSetImeWindowStatusSysuiState_ImeVisibleImeSwitcherButtonVisible
NavigationBarTest#testSetImeWindowStatusSysuiState_ImeVisibleImeSwitcherButtonNotVisible
NavigationBarTest#testSetImeWindowStatusSysuiState_ImeNotVisibleImeSwitcherButtonVisible
NavigationBarTest#testSetImeWindowStatusSysuiState_ImeVisibleBackDispositionAdjustNothing
Change-Id: Ic57cea49f5ff49132802083b4f0c9b0e82db1cf7
Diffstat (limited to 'api/coverage/tools')
0 files changed, 0 insertions, 0 deletions