diff options
| author | 2022-08-11 23:43:44 +0000 | |
|---|---|---|
| committer | 2022-08-12 17:35:40 +0000 | |
| commit | e0b684f7d00d0a33d5498e548dfa03a81330e826 (patch) | |
| tree | 63a167f6698fc3d7de96f58add8b2b48d62e5dde /api/api.go | |
| parent | 2701e8074c69080ed181f141dbe24149cf70d6e2 (diff) | |
SurfaceView: Revert SurfaceLock locking changes
This reverts commit 9e3cd0533fa4dbca75d65750f9ffcd9817779c3c
and commit 74c760394aacd5a57ba0acade8cb8151ba14678c.
Initially we made a change to address a performance issue
in SurfaceView caused by holding the mSurfaceLock whenever
we went though the updateSurfaces loop. This had a side
effects of causing an ANR since the locking order changed.
The followup fix removed the lock but broke some API
contracts around lock and unlock canvas.
Subsequent fixes, which never went into QPR, introduced
new issues. Changing the locking order is too risky
QPR so lets revert and try to rework the locking
mechanism in U.
Test: app in b/234006724 does not ANR
Test: app in b/235188096 does not crash
Test: app in b/239895124 does not ANR
Test: app in b/239142077 does not crash
Test: atest SurfaceViewTest
Bug: 235188096
Change-Id: I99c5bb707ecad7c8d3c1fbd8b4105a77d58c145d
Diffstat (limited to 'api/api.go')
0 files changed, 0 insertions, 0 deletions