diff options
| author | 2023-08-03 17:54:36 +0000 | |
|---|---|---|
| committer | 2023-08-03 18:16:09 +0000 | |
| commit | 95b105671e5eb57434303088a0291b81e8de1372 (patch) | |
| tree | fb459414ecd9e1d544232b34b136c3fcf3b4aafa /api/api.go | |
| parent | 6f74b260aa67e8a07fd28a253f6e18b8ee298343 (diff) | |
Return error code when there's an error starting an activity
When an error occurs while attempting to start an activity,
runStartActivity does not always return an error code like it should.
This causes tools like the simpleperf app profiler to have incorrect
behavior:
$ system/extras/simpleperf/scripts/app_profiler.py -p com.google.android.youtube -a doesntexist
18:08:45,394 [DEBUG] (simpleperf_utils.py:304) run adb cmd: ['adb', 'shell', 'am', 'start', '-n', 'com.google.android.youtube/doesntexist'] [result True]
<Blocks forever>
Immediately return an error code in these cases like elsewhere in the
function.
Bug: 294402973
Test: $ system/extras/simpleperf/scripts/app_profiler.py -p com.google.android.youtube -a doesntexist
Test: 17:39:26,843 [DEBUG] (simpleperf_utils.py:304) run adb cmd: ['adb', 'shell', 'am', 'start', '-n', 'com.google.android.youtube/doesntexist'] [result False]
Test: Can't start activity com.google.android.youtube/doesntexist
Change-Id: If1ebbde6ee77b27b8d6fa7d4097163d3b4594389
Diffstat (limited to 'api/api.go')
0 files changed, 0 insertions, 0 deletions