summaryrefslogtreecommitdiff
path: root/api/api.go
diff options
context:
space:
mode:
author Steve Elliott <steell@google.com> 2022-02-15 00:18:13 -0500
committer Steve Elliott <steell@google.com> 2022-03-10 20:19:43 +0000
commit654c615cf9fa17f97dd1aed497a482aba3b97c04 (patch)
tree6e429b7442d49c68f2f577ef81dec08299dc0cff /api/api.go
parent68afc54a39d753216e60cc8ee78e456e6b56c41b (diff)
Defer MessagingGroup#recycle until bind completes
There is a "race condition" where a MessagingGroup is recycled while the contents of that group are being used elsewhere in the ConversationLayout, namely in the "image message container" used to show the most recent image message in the collapsed state. This state isn't cleared until later in the bind() process, which unfortunately depends on the groups being updated. For that reason, we defer all synchronous calls to recycle() until the end of bind(), which will ensure that the old groups are still around as long as necessary. Fixes: 216202070 Test: manual Change-Id: Idef815d54690544615512bd2bd1006f172403e18 (cherry picked from commit 2a68270c76def0b635bd1583e9c1817d09dff969)
Diffstat (limited to 'api/api.go')
0 files changed, 0 insertions, 0 deletions