diff options
| author | 2023-01-11 14:27:10 +0000 | |
|---|---|---|
| committer | 2023-01-30 17:09:06 +0000 | |
| commit | 15055c70a171359697ac8c46dc98dae8dac4a775 (patch) | |
| tree | 1db38d930e90b7f172c1638ec0179e3693cd5cec /api/api.go | |
| parent | 4677d90f9ec5eb81492846c965de6786eacd096c (diff) | |
Cleanup in ExpandableNotificationRowTest
After adding some new test cases to ExpandableNotificationRowTest we
have noticed an increasing number of leaks of ExpandableNotificationRow.
How did this happen:
- Mockito was holding onto some ExpandableNotificationRow instances and resetting the inline mocks didn't help to release them
- NotificationTestHelper has a mock StatusBarStateController
- NotificationTestHelper creates a real HeadsUpManagerPhone passing in
the mock StatusBarStateController
- HeadsUpManagerPhone sets a listener on the mock StatusBarStateController
- that listener holds onto a NotificationEntry
- that entry has an ExpandableNotificationRow
This CL:
- uses a mock HeadsUpManagerPhone
- removes some unnecessary ExpandableNotificationRow instances from ExpandableNotificationRowTest
Fixes: 265135790
Test: create heap dumps using com.android.systemui.MemoryTrackingTestCase and compare them with go/ahat
Test: atest ExpandableNotificationRowTest
Test: atest SystemUITests
Change-Id: I314a1f6e59f095f8cc6018e3d65bf90bd9cd4a75
Merged-In: I314a1f6e59f095f8cc6018e3d65bf90bd9cd4a75
Diffstat (limited to 'api/api.go')
0 files changed, 0 insertions, 0 deletions