summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Kaylee Lubick <kjlubick@google.com> 2025-02-25 05:46:47 -0800
committer Kaylee Lubick <kjlubick@google.com> 2025-02-25 05:49:37 -0800
commite37757c40f863bf96212793a590a2177b1d1608d (patch)
treed3328aaa6e0cc308f7aa1ec1a80106010f19b3f6
parent334963a7283a7d8d6f3825e91bff4989bf985101 (diff)
Replace uses of SkPackARGB32 with SkColorSetARGB
The former is a private Skia API but functionally the same as SkColorSetARGB or SkColorSetRGB. I spotted a few cases in which a constant color could be used and changed those to aid readability Change-Id: Ibd06d95f98f48ec8931a2e894096b89d76981bd4 Flag: EXEMPT refactoring
-rw-r--r--libs/hwui/jni/GIFMovie.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/libs/hwui/jni/GIFMovie.cpp b/libs/hwui/jni/GIFMovie.cpp
index 6c82aa1ca27d..476b6fda5007 100644
--- a/libs/hwui/jni/GIFMovie.cpp
+++ b/libs/hwui/jni/GIFMovie.cpp
@@ -63,7 +63,7 @@ GIFMovie::GIFMovie(SkStream* stream)
}
fCurrIndex = -1;
fLastDrawIndex = -1;
- fPaintingColor = SkPackARGB32(0, 0, 0, 0);
+ fPaintingColor = SK_AlphaTRANSPARENT;
}
GIFMovie::~GIFMovie()
@@ -127,7 +127,7 @@ static void copyLine(uint32_t* dst, const unsigned char* src, const ColorMapObje
for (; width > 0; width--, src++, dst++) {
if (*src != transparent && *src < cmap->ColorCount) {
const GifColorType& col = cmap->Colors[*src];
- *dst = SkPackARGB32(0xFF, col.Red, col.Green, col.Blue);
+ *dst = SkColorSetRGB(col.Red, col.Green, col.Blue);
}
}
}
@@ -395,10 +395,10 @@ bool GIFMovie::onGetBitmap(SkBitmap* bm)
lastIndex = fGIF->ImageCount - 1;
}
- SkColor bgColor = SkPackARGB32(0, 0, 0, 0);
+ SkColor bgColor = SK_ColorTRANSPARENT;
if (gif->SColorMap != nullptr && gif->SBackGroundColor < gif->SColorMap->ColorCount) {
const GifColorType& col = gif->SColorMap->Colors[gif->SBackGroundColor];
- bgColor = SkColorSetARGB(0xFF, col.Red, col.Green, col.Blue);
+ bgColor = SkColorSetRGB(col.Red, col.Green, col.Blue);
}
// draw each frames - not intelligent way
@@ -411,7 +411,7 @@ bool GIFMovie::onGetBitmap(SkBitmap* bm)
if (!trans && gif->SColorMap != nullptr) {
fPaintingColor = bgColor;
} else {
- fPaintingColor = SkColorSetARGB(0, 0, 0, 0);
+ fPaintingColor = SK_ColorTRANSPARENT;
}
bm->eraseColor(fPaintingColor);