diff options
author | 2024-02-06 14:13:11 +0900 | |
---|---|---|
committer | 2024-02-06 14:13:11 +0900 | |
commit | d86ba1ee96f8bb3e95353cb20bf7d2b515786ca9 (patch) | |
tree | 3634fc00d3b56342da9e5a59a04fb35e9f2e6fa1 | |
parent | e41e4419cbb3f7b7787e8312568c712ecfc357c7 (diff) |
Rename feature flag for inter character justification
Bug: 322228767
Test: TreeHugger
Change-Id: Iea07f64362537123a702928aeb0becff8cef9f71
-rw-r--r-- | core/api/current.txt | 10 | ||||
-rw-r--r-- | core/java/android/text/Layout.java | 6 | ||||
-rw-r--r-- | core/java/android/text/TextLine.java | 2 | ||||
-rw-r--r-- | core/java/android/text/flags/flags.aconfig | 2 | ||||
-rw-r--r-- | core/tests/coretests/src/android/text/TextLineJustificationTest.kt | 2 | ||||
-rw-r--r-- | core/tests/coretests/src/android/text/TextLineLetterSpacingTest.kt | 8 | ||||
-rw-r--r-- | graphics/java/android/graphics/Paint.java | 6 | ||||
-rw-r--r-- | graphics/java/android/graphics/text/LineBreaker.java | 4 | ||||
-rw-r--r-- | libs/hwui/FeatureFlags.h | 4 | ||||
-rw-r--r-- | libs/hwui/hwui/MinikinUtils.cpp | 4 |
10 files changed, 24 insertions, 24 deletions
diff --git a/core/api/current.txt b/core/api/current.txt index 283e429c13bf..ec34c2d99e32 100644 --- a/core/api/current.txt +++ b/core/api/current.txt @@ -16516,8 +16516,8 @@ package android.graphics { field public static final int START_HYPHEN_EDIT_NO_EDIT = 0; // 0x0 field public static final int STRIKE_THRU_TEXT_FLAG = 16; // 0x10 field public static final int SUBPIXEL_TEXT_FLAG = 128; // 0x80 - field @FlaggedApi("com.android.text.flags.inter_character_justification") public static final int TEXT_RUN_FLAG_LEFT_EDGE = 8192; // 0x2000 - field @FlaggedApi("com.android.text.flags.inter_character_justification") public static final int TEXT_RUN_FLAG_RIGHT_EDGE = 16384; // 0x4000 + field @FlaggedApi("com.android.text.flags.letter_spacing_justification") public static final int TEXT_RUN_FLAG_LEFT_EDGE = 8192; // 0x2000 + field @FlaggedApi("com.android.text.flags.letter_spacing_justification") public static final int TEXT_RUN_FLAG_RIGHT_EDGE = 16384; // 0x4000 field public static final int UNDERLINE_TEXT_FLAG = 8; // 0x8 } @@ -17994,7 +17994,7 @@ package android.graphics.text { field public static final int HYPHENATION_FREQUENCY_FULL = 2; // 0x2 field public static final int HYPHENATION_FREQUENCY_NONE = 0; // 0x0 field public static final int HYPHENATION_FREQUENCY_NORMAL = 1; // 0x1 - field @FlaggedApi("com.android.text.flags.inter_character_justification") public static final int JUSTIFICATION_MODE_INTER_CHARACTER = 2; // 0x2 + field @FlaggedApi("com.android.text.flags.letter_spacing_justification") public static final int JUSTIFICATION_MODE_INTER_CHARACTER = 2; // 0x2 field public static final int JUSTIFICATION_MODE_INTER_WORD = 1; // 0x1 field public static final int JUSTIFICATION_MODE_NONE = 0; // 0x0 } @@ -47216,7 +47216,7 @@ package android.text { method public int getLineForOffset(int); method public int getLineForVertical(int); method public float getLineLeft(int); - method @FlaggedApi("com.android.text.flags.inter_character_justification") @IntRange(from=0) public int getLineLetterSpacingUnitCount(@IntRange(from=0) int, boolean); + method @FlaggedApi("com.android.text.flags.letter_spacing_justification") @IntRange(from=0) public int getLineLetterSpacingUnitCount(@IntRange(from=0) int, boolean); method public float getLineMax(int); method public float getLineRight(int); method @FlaggedApi("com.android.text.flags.use_bounds_for_width") public final float getLineSpacingAmount(); @@ -47267,7 +47267,7 @@ package android.text { field @NonNull public static final android.text.Layout.TextInclusionStrategy INCLUSION_STRATEGY_ANY_OVERLAP; field @NonNull public static final android.text.Layout.TextInclusionStrategy INCLUSION_STRATEGY_CONTAINS_ALL; field @NonNull public static final android.text.Layout.TextInclusionStrategy INCLUSION_STRATEGY_CONTAINS_CENTER; - field @FlaggedApi("com.android.text.flags.inter_character_justification") public static final int JUSTIFICATION_MODE_INTER_CHARACTER = 2; // 0x2 + field @FlaggedApi("com.android.text.flags.letter_spacing_justification") public static final int JUSTIFICATION_MODE_INTER_CHARACTER = 2; // 0x2 field public static final int JUSTIFICATION_MODE_INTER_WORD = 1; // 0x1 field public static final int JUSTIFICATION_MODE_NONE = 0; // 0x0 } diff --git a/core/java/android/text/Layout.java b/core/java/android/text/Layout.java index 1ea80f146b0b..8ddb42d6b3be 100644 --- a/core/java/android/text/Layout.java +++ b/core/java/android/text/Layout.java @@ -18,7 +18,7 @@ package android.text; import static com.android.text.flags.Flags.FLAG_FIX_LINE_HEIGHT_FOR_LOCALE; import static com.android.text.flags.Flags.FLAG_USE_BOUNDS_FOR_WIDTH; -import static com.android.text.flags.Flags.FLAG_INTER_CHARACTER_JUSTIFICATION; +import static com.android.text.flags.Flags.FLAG_LETTER_SPACING_JUSTIFICATION; import android.annotation.FlaggedApi; import android.annotation.FloatRange; @@ -172,7 +172,7 @@ public abstract class Layout { /** * Value for justification mode indicating the text is justified by stretching letter spacing. */ - @FlaggedApi(FLAG_INTER_CHARACTER_JUSTIFICATION) + @FlaggedApi(FLAG_LETTER_SPACING_JUSTIFICATION) public static final int JUSTIFICATION_MODE_INTER_CHARACTER = LineBreaker.JUSTIFICATION_MODE_INTER_CHARACTER; @@ -1831,7 +1831,7 @@ public abstract class Layout { * @return the number of cluster count in the line. */ @IntRange(from = 0) - @FlaggedApi(FLAG_INTER_CHARACTER_JUSTIFICATION) + @FlaggedApi(FLAG_LETTER_SPACING_JUSTIFICATION) public int getLineLetterSpacingUnitCount(@IntRange(from = 0) int line, boolean includeTrailingWhitespace) { final int start = getLineStart(line); diff --git a/core/java/android/text/TextLine.java b/core/java/android/text/TextLine.java index 224e5d8f7712..bde9c7770eb7 100644 --- a/core/java/android/text/TextLine.java +++ b/core/java/android/text/TextLine.java @@ -305,7 +305,7 @@ public class TextLine { } mAddedWordSpacingInPx = (justifyWidth - width) / spaces; mAddedLetterSpacingInPx = 0; - } else { // justificationMode == Layout.JUSTIFICATION_MODE_INTER_CHARACTER + } else { // justificationMode == Layout.JUSTIFICATION_MODE_LETTER_SPACING LineInfo lineInfo = new LineInfo(); float width = Math.abs(measure(end, false, null, null, lineInfo)); diff --git a/core/java/android/text/flags/flags.aconfig b/core/java/android/text/flags/flags.aconfig index f3e0ea780182..fbc645b19ede 100644 --- a/core/java/android/text/flags/flags.aconfig +++ b/core/java/android/text/flags/flags.aconfig @@ -77,7 +77,7 @@ flag { } flag { - name: "inter_character_justification" + name: "letter_spacing_justification" namespace: "text" description: "A feature flag that implement inter character justification." bug: "283193133" diff --git a/core/tests/coretests/src/android/text/TextLineJustificationTest.kt b/core/tests/coretests/src/android/text/TextLineJustificationTest.kt index a52561557523..c18f35ff1dc0 100644 --- a/core/tests/coretests/src/android/text/TextLineJustificationTest.kt +++ b/core/tests/coretests/src/android/text/TextLineJustificationTest.kt @@ -126,4 +126,4 @@ class TextLineJustificationTest { TextLine.recycle(tl) } -}
\ No newline at end of file +} diff --git a/core/tests/coretests/src/android/text/TextLineLetterSpacingTest.kt b/core/tests/coretests/src/android/text/TextLineLetterSpacingTest.kt index 27869bbf5392..71980c125f01 100644 --- a/core/tests/coretests/src/android/text/TextLineLetterSpacingTest.kt +++ b/core/tests/coretests/src/android/text/TextLineLetterSpacingTest.kt @@ -21,7 +21,7 @@ import android.platform.test.annotations.RequiresFlagsEnabled import android.platform.test.flag.junit.DeviceFlagsValueProvider import androidx.test.ext.junit.runners.AndroidJUnit4 import androidx.test.filters.SmallTest -import com.android.text.flags.Flags.FLAG_INTER_CHARACTER_JUSTIFICATION +import com.android.text.flags.Flags.FLAG_LETTER_SPACING_JUSTIFICATION import com.google.common.truth.Truth.assertThat import org.junit.Rule import org.junit.Test @@ -40,7 +40,7 @@ class TextLineLetterSpacingTest { @JvmField val mCheckFlagsRule = DeviceFlagsValueProvider.createCheckFlagsRule() - @RequiresFlagsEnabled(FLAG_INTER_CHARACTER_JUSTIFICATION) + @RequiresFlagsEnabled(FLAG_LETTER_SPACING_JUSTIFICATION) @Test fun calculateRunFlagTest() { // Only one Bidi run @@ -84,7 +84,7 @@ class TextLineLetterSpacingTest { .isEqualTo(LEFT_EDGE) } - @RequiresFlagsEnabled(FLAG_INTER_CHARACTER_JUSTIFICATION) + @RequiresFlagsEnabled(FLAG_LETTER_SPACING_JUSTIFICATION) @Test fun resolveRunFlagForSubSequenceTest() { val runStart = 5 @@ -221,4 +221,4 @@ class TextLineLetterSpacingTest { MIDDLE_OF_LINE, true, runStart, runEnd, runStart + 1, runEnd - 1)) .isEqualTo(MIDDLE_OF_LINE) } -}
\ No newline at end of file +} diff --git a/graphics/java/android/graphics/Paint.java b/graphics/java/android/graphics/Paint.java index ae61a2d811d2..df95a91d72d7 100644 --- a/graphics/java/android/graphics/Paint.java +++ b/graphics/java/android/graphics/Paint.java @@ -17,7 +17,7 @@ package android.graphics; import static com.android.text.flags.Flags.FLAG_FIX_LINE_HEIGHT_FOR_LOCALE; -import static com.android.text.flags.Flags.FLAG_INTER_CHARACTER_JUSTIFICATION; +import static com.android.text.flags.Flags.FLAG_LETTER_SPACING_JUSTIFICATION; import android.annotation.ColorInt; import android.annotation.ColorLong; @@ -293,7 +293,7 @@ public class Paint { * {@link Paint#measureText(CharSequence, int, int)}. The non-run based APIs works as both * {@link #TEXT_RUN_FLAG_LEFT_EDGE} and {@link #TEXT_RUN_FLAG_RIGHT_EDGE} are specified. */ - @FlaggedApi(FLAG_INTER_CHARACTER_JUSTIFICATION) + @FlaggedApi(FLAG_LETTER_SPACING_JUSTIFICATION) public static final int TEXT_RUN_FLAG_LEFT_EDGE = 0x2000; @@ -324,7 +324,7 @@ public class Paint { * {@link Paint#measureText(CharSequence, int, int)}. The non-run based APIs works as both * {@link #TEXT_RUN_FLAG_LEFT_EDGE} and {@link #TEXT_RUN_FLAG_RIGHT_EDGE} are specified. */ - @FlaggedApi(FLAG_INTER_CHARACTER_JUSTIFICATION) + @FlaggedApi(FLAG_LETTER_SPACING_JUSTIFICATION) public static final int TEXT_RUN_FLAG_RIGHT_EDGE = 0x4000; // These flags are always set on a new/reset paint, even if flags 0 is passed. diff --git a/graphics/java/android/graphics/text/LineBreaker.java b/graphics/java/android/graphics/text/LineBreaker.java index 97071260402c..0e9f29db8cb5 100644 --- a/graphics/java/android/graphics/text/LineBreaker.java +++ b/graphics/java/android/graphics/text/LineBreaker.java @@ -17,7 +17,7 @@ package android.graphics.text; import static com.android.text.flags.Flags.FLAG_USE_BOUNDS_FOR_WIDTH; -import static com.android.text.flags.Flags.FLAG_INTER_CHARACTER_JUSTIFICATION; +import static com.android.text.flags.Flags.FLAG_LETTER_SPACING_JUSTIFICATION; import android.annotation.FlaggedApi; import android.annotation.FloatRange; @@ -183,7 +183,7 @@ public class LineBreaker { /** * Value for justification mode indicating the text is justified by stretching letter spacing. */ - @FlaggedApi(FLAG_INTER_CHARACTER_JUSTIFICATION) + @FlaggedApi(FLAG_LETTER_SPACING_JUSTIFICATION) public static final int JUSTIFICATION_MODE_INTER_CHARACTER = 2; /** diff --git a/libs/hwui/FeatureFlags.h b/libs/hwui/FeatureFlags.h index 6ebfc63bdf26..ac75c077b58f 100644 --- a/libs/hwui/FeatureFlags.h +++ b/libs/hwui/FeatureFlags.h @@ -41,9 +41,9 @@ inline bool deprecate_ui_fonts() { #endif // __ANDROID__ } -inline bool inter_character_justification() { +inline bool letter_spacing_justification() { #ifdef __ANDROID__ - return com_android_text_flags_inter_character_justification(); + return com_android_text_flags_letter_spacing_justification(); #else return true; #endif // __ANDROID__ diff --git a/libs/hwui/hwui/MinikinUtils.cpp b/libs/hwui/hwui/MinikinUtils.cpp index 56133699d5f5..d66d7f8e83f4 100644 --- a/libs/hwui/hwui/MinikinUtils.cpp +++ b/libs/hwui/hwui/MinikinUtils.cpp @@ -72,7 +72,7 @@ minikin::Layout MinikinUtils::doLayout(const Paint* paint, minikin::Bidi bidiFla const minikin::Range contextRange(contextStart, contextStart + contextCount); const minikin::StartHyphenEdit startHyphen = paint->getStartHyphenEdit(); const minikin::EndHyphenEdit endHyphen = paint->getEndHyphenEdit(); - const minikin::RunFlag minikinRunFlag = text_feature::inter_character_justification() + const minikin::RunFlag minikinRunFlag = text_feature::letter_spacing_justification() ? paint->getRunFlag() : minikin::RunFlag::NONE; @@ -105,7 +105,7 @@ float MinikinUtils::measureText(const Paint* paint, minikin::Bidi bidiFlags, const minikin::Range range(start, start + count); const minikin::StartHyphenEdit startHyphen = paint->getStartHyphenEdit(); const minikin::EndHyphenEdit endHyphen = paint->getEndHyphenEdit(); - const minikin::RunFlag minikinRunFlag = text_feature::inter_character_justification() + const minikin::RunFlag minikinRunFlag = text_feature::letter_spacing_justification() ? paint->getRunFlag() : minikin::RunFlag::NONE; |