summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Mathias Agopian <mathias@google.com> 2009-08-06 17:14:10 -0700
committer Mathias Agopian <mathias@google.com> 2009-08-06 17:14:10 -0700
commitd7ef08c08d50d1c01d30a242b04590bd3a272431 (patch)
tree95d2d6f3ed9741a826f374c46e0f7bc17cd2c4aa
parent738b9a45399485893fa9541fae19c47e01bc4af4 (diff)
oops, EGLConfig of value zero may be valid
-rw-r--r--libs/ui/EGLUtils.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/libs/ui/EGLUtils.cpp b/libs/ui/EGLUtils.cpp
index 9b2839d25282..80bfdfd5c799 100644
--- a/libs/ui/EGLUtils.cpp
+++ b/libs/ui/EGLUtils.cpp
@@ -61,8 +61,9 @@ status_t EGLUtils::selectConfigForPixelFormat(
const int fbSzG = fbFormatInfo.getSize(PixelFormatInfo::INDEX_GREEN);
const int fbSzB = fbFormatInfo.getSize(PixelFormatInfo::INDEX_BLUE);
+ int i;
EGLConfig config = NULL;
- for (int i=0 ; i<n ; i++) {
+ for (i=0 ; i<n ; i++) {
EGLint r,g,b,a;
eglGetConfigAttrib(dpy, configs[i], EGL_RED_SIZE, &r);
eglGetConfigAttrib(dpy, configs[i], EGL_GREEN_SIZE, &g);
@@ -76,7 +77,7 @@ status_t EGLUtils::selectConfigForPixelFormat(
free(configs);
- if (config) {
+ if (i<n) {
*outConfig = config;
return NO_ERROR;
}