summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Adrian Roos <roosa@google.com> 2019-02-28 12:49:19 +0100
committer Adrian Roos <roosa@google.com> 2019-03-05 18:13:42 +0000
commitcdb8167051afffa77348dfee991679480d4d31a8 (patch)
tree8ef191cf9b411378c4188a0016bb41c8fa48945e
parent56ff78438513dd6c308468d1c5ac7ad29556dbbf (diff)
Apilint: No longer flag interface callbacks
With default interfaces, this is no longer necessary. Test: python apilint_test.py Change-Id: Ifa9ba24511a82797089934009d9096c3a589e7f6
-rw-r--r--tools/apilint/apilint.py4
1 files changed, 0 insertions, 4 deletions
diff --git a/tools/apilint/apilint.py b/tools/apilint/apilint.py
index ddfee622699e..d0537830d7dd 100644
--- a/tools/apilint/apilint.py
+++ b/tools/apilint/apilint.py
@@ -816,7 +816,6 @@ def verify_method_names(clazz):
def verify_callbacks(clazz):
"""Verify Callback classes.
- All callback classes must be abstract.
All methods must follow onFoo() naming style."""
if clazz.fullname == "android.speech.tts.SynthesisCallback": return
@@ -826,9 +825,6 @@ def verify_callbacks(clazz):
warn(clazz, None, "L1", "Class should be named FooCallback")
if clazz.name.endswith("Callback"):
- if "interface" in clazz.split:
- error(clazz, None, "CL3", "Callbacks must be abstract class to enable extension in future API levels")
-
for m in clazz.methods:
if not re.match("on[A-Z][a-z]*", m.name):
error(clazz, m, "L1", "Callback method names must be onFoo() style")