diff options
author | 2024-04-23 14:26:29 +0100 | |
---|---|---|
committer | 2024-04-24 17:13:59 +0100 | |
commit | c935f27db14347bf5862b762a58c9db6c8d91325 (patch) | |
tree | 3d82074f673e3448fab7ec7e642371cd47c317b5 | |
parent | 1824134a9de5411bdf99d8c66194071ff41e1afc (diff) |
Run clang-format on libhostgraphics
Bug: 322360037
Test: N/A
Change-Id: I346805e599a41abcd1eaaa51f5654cb323e5146f
-rw-r--r-- | libs/hostgraphics/ADisplay.cpp | 12 | ||||
-rw-r--r-- | libs/hostgraphics/Fence.cpp | 2 | ||||
-rw-r--r-- | libs/hostgraphics/HostBufferQueue.cpp | 46 | ||||
-rw-r--r-- | libs/hostgraphics/PublicFormat.cpp | 2 | ||||
-rw-r--r-- | libs/hostgraphics/gui/BufferItem.h | 8 | ||||
-rw-r--r-- | libs/hostgraphics/gui/BufferItemConsumer.h | 43 | ||||
-rw-r--r-- | libs/hostgraphics/gui/BufferQueue.h | 2 | ||||
-rw-r--r-- | libs/hostgraphics/gui/ConsumerBase.h | 4 | ||||
-rw-r--r-- | libs/hostgraphics/gui/IGraphicBufferConsumer.h | 8 | ||||
-rw-r--r-- | libs/hostgraphics/gui/IGraphicBufferProducer.h | 3 | ||||
-rw-r--r-- | libs/hostgraphics/gui/Surface.h | 66 | ||||
-rw-r--r-- | libs/hostgraphics/ui/Fence.h | 27 | ||||
-rw-r--r-- | libs/hostgraphics/ui/GraphicBuffer.h | 45 |
13 files changed, 175 insertions, 93 deletions
diff --git a/libs/hostgraphics/ADisplay.cpp b/libs/hostgraphics/ADisplay.cpp index 9cc1f40184e3..58fa08281a61 100644 --- a/libs/hostgraphics/ADisplay.cpp +++ b/libs/hostgraphics/ADisplay.cpp @@ -94,14 +94,14 @@ namespace android { int ADisplay_acquirePhysicalDisplays(ADisplay*** outDisplays) { // This is running on host, so there are no physical displays available. // Create 1 fake display instead. - DisplayImpl** const impls = reinterpret_cast<DisplayImpl**>( - malloc(sizeof(DisplayImpl*) + sizeof(DisplayImpl))); + DisplayImpl** const impls = + reinterpret_cast<DisplayImpl**>(malloc(sizeof(DisplayImpl*) + sizeof(DisplayImpl))); DisplayImpl* const displayData = reinterpret_cast<DisplayImpl*>(impls + 1); - displayData[0] = DisplayImpl{ADisplayType::DISPLAY_TYPE_INTERNAL, - ADataSpace::ADATASPACE_UNKNOWN, - AHardwareBuffer_Format::AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM, - DisplayConfigImpl()}; + displayData[0] = + DisplayImpl{ADisplayType::DISPLAY_TYPE_INTERNAL, ADataSpace::ADATASPACE_UNKNOWN, + AHardwareBuffer_Format::AHARDWAREBUFFER_FORMAT_R8G8B8A8_UNORM, + DisplayConfigImpl()}; impls[0] = displayData; *outDisplays = reinterpret_cast<ADisplay**>(impls); return 1; diff --git a/libs/hostgraphics/Fence.cpp b/libs/hostgraphics/Fence.cpp index 9e54816651c4..4383bf02a00e 100644 --- a/libs/hostgraphics/Fence.cpp +++ b/libs/hostgraphics/Fence.cpp @@ -20,4 +20,4 @@ namespace android { const sp<Fence> Fence::NO_FENCE = sp<Fence>(new Fence); -} // namespace android
\ No newline at end of file +} // namespace android diff --git a/libs/hostgraphics/HostBufferQueue.cpp b/libs/hostgraphics/HostBufferQueue.cpp index b4fd5d9aab3d..7e14b88a47fa 100644 --- a/libs/hostgraphics/HostBufferQueue.cpp +++ b/libs/hostgraphics/HostBufferQueue.cpp @@ -15,21 +15,26 @@ */ #include <gui/BufferQueue.h> - #include <system/window.h> namespace android { class HostBufferQueue : public IGraphicBufferProducer, public IGraphicBufferConsumer { public: - HostBufferQueue() : mWidth(0), mHeight(0) { } + HostBufferQueue() : mWidth(0), mHeight(0) {} -// Consumer - virtual status_t setConsumerIsProtected(bool isProtected) { return OK; } + // Consumer + virtual status_t setConsumerIsProtected(bool isProtected) { + return OK; + } - virtual status_t detachBuffer(int slot) { return OK; } + virtual status_t detachBuffer(int slot) { + return OK; + } - virtual status_t getReleasedBuffers(uint64_t* slotMask) { return OK; } + virtual status_t getReleasedBuffers(uint64_t* slotMask) { + return OK; + } virtual status_t setDefaultBufferSize(uint32_t w, uint32_t h) { mWidth = w; @@ -38,26 +43,36 @@ public: return OK; } - virtual status_t setDefaultBufferFormat(PixelFormat defaultFormat) { return OK; } + virtual status_t setDefaultBufferFormat(PixelFormat defaultFormat) { + return OK; + } - virtual status_t setDefaultBufferDataSpace(android_dataspace defaultDataSpace) { return OK; } + virtual status_t setDefaultBufferDataSpace(android_dataspace defaultDataSpace) { + return OK; + } - virtual status_t discardFreeBuffers() { return OK; } + virtual status_t discardFreeBuffers() { + return OK; + } virtual status_t acquireBuffer(BufferItem* buffer, nsecs_t presentWhen, - uint64_t maxFrameNumber = 0) { + uint64_t maxFrameNumber = 0) { buffer->mGraphicBuffer = mBuffer; buffer->mSlot = 0; return OK; } - virtual status_t setMaxAcquiredBufferCount(int maxAcquiredBuffers) { return OK; } + virtual status_t setMaxAcquiredBufferCount(int maxAcquiredBuffers) { + return OK; + } - virtual status_t setConsumerUsageBits(uint64_t usage) { return OK; } + virtual status_t setConsumerUsageBits(uint64_t usage) { + return OK; + } -// Producer + // Producer virtual int query(int what, int* value) { - switch(what) { + switch (what) { case NATIVE_WINDOW_WIDTH: *value = mWidth; break; @@ -83,8 +98,7 @@ private: }; void BufferQueue::createBufferQueue(sp<IGraphicBufferProducer>* outProducer, - sp<IGraphicBufferConsumer>* outConsumer) { - + sp<IGraphicBufferConsumer>* outConsumer) { sp<HostBufferQueue> obj(new HostBufferQueue()); *outProducer = obj; diff --git a/libs/hostgraphics/PublicFormat.cpp b/libs/hostgraphics/PublicFormat.cpp index af6d2738c801..2a2eec63467c 100644 --- a/libs/hostgraphics/PublicFormat.cpp +++ b/libs/hostgraphics/PublicFormat.cpp @@ -30,4 +30,4 @@ PublicFormat mapHalFormatDataspaceToPublicFormat(int format, android_dataspace d return static_cast<PublicFormat>(format); } -} // namespace android
\ No newline at end of file +} // namespace android diff --git a/libs/hostgraphics/gui/BufferItem.h b/libs/hostgraphics/gui/BufferItem.h index 01409e19c715..e95a9231dfaf 100644 --- a/libs/hostgraphics/gui/BufferItem.h +++ b/libs/hostgraphics/gui/BufferItem.h @@ -17,16 +17,15 @@ #ifndef ANDROID_GUI_BUFFERITEM_H #define ANDROID_GUI_BUFFERITEM_H +#include <system/graphics.h> #include <ui/Fence.h> #include <ui/Rect.h> - -#include <system/graphics.h> - #include <utils/StrongPointer.h> namespace android { class Fence; + class GraphicBuffer; // The only thing we need here for layoutlib is mGraphicBuffer. The rest of the fields are added @@ -37,6 +36,7 @@ public: enum { INVALID_BUFFER_SLOT = -1 }; BufferItem() : mGraphicBuffer(nullptr), mFence(Fence::NO_FENCE) {} + ~BufferItem() {} sp<GraphicBuffer> mGraphicBuffer; @@ -60,6 +60,6 @@ public: bool mTransformToDisplayInverse; }; -} +} // namespace android #endif // ANDROID_GUI_BUFFERITEM_H diff --git a/libs/hostgraphics/gui/BufferItemConsumer.h b/libs/hostgraphics/gui/BufferItemConsumer.h index 707b313eb102..c25941151800 100644 --- a/libs/hostgraphics/gui/BufferItemConsumer.h +++ b/libs/hostgraphics/gui/BufferItemConsumer.h @@ -17,32 +17,30 @@ #ifndef ANDROID_GUI_BUFFERITEMCONSUMER_H #define ANDROID_GUI_BUFFERITEMCONSUMER_H -#include <utils/RefBase.h> - #include <gui/ConsumerBase.h> #include <gui/IGraphicBufferConsumer.h> +#include <utils/RefBase.h> namespace android { class BufferItemConsumer : public ConsumerBase { public: - BufferItemConsumer( - const sp<IGraphicBufferConsumer>& consumer, - uint64_t consumerUsage, - int bufferCount, - bool controlledByApp) : mConsumer(consumer) { - } + BufferItemConsumer(const sp<IGraphicBufferConsumer>& consumer, uint64_t consumerUsage, + int bufferCount, bool controlledByApp) + : mConsumer(consumer) {} - status_t acquireBuffer(BufferItem *item, nsecs_t presentWhen, bool waitForFence = true) { + status_t acquireBuffer(BufferItem* item, nsecs_t presentWhen, bool waitForFence = true) { return mConsumer->acquireBuffer(item, presentWhen, 0); } - status_t releaseBuffer( - const BufferItem &item, const sp<Fence>& releaseFence = Fence::NO_FENCE) { return OK; } + status_t releaseBuffer(const BufferItem& item, + const sp<Fence>& releaseFence = Fence::NO_FENCE) { + return OK; + } - void setName(const String8& name) { } + void setName(const String8& name) {} - void setFrameAvailableListener(const wp<FrameAvailableListener>& listener) { } + void setFrameAvailableListener(const wp<FrameAvailableListener>& listener) {} status_t setDefaultBufferSize(uint32_t width, uint32_t height) { return mConsumer->setDefaultBufferSize(width, height); @@ -56,16 +54,23 @@ public: return mConsumer->setDefaultBufferDataSpace(defaultDataSpace); } - void abandon() { } + void abandon() {} - status_t detachBuffer(int slot) { return OK; } + status_t detachBuffer(int slot) { + return OK; + } + + status_t discardFreeBuffers() { + return OK; + } - status_t discardFreeBuffers() { return OK; } + void freeBufferLocked(int slotIndex) {} - void freeBufferLocked(int slotIndex) { } + status_t addReleaseFenceLocked(int slot, const sp<GraphicBuffer> graphicBuffer, + const sp<Fence>& fence) { + return OK; + } - status_t addReleaseFenceLocked( - int slot, const sp<GraphicBuffer> graphicBuffer, const sp<Fence>& fence) { return OK; } private: sp<IGraphicBufferConsumer> mConsumer; }; diff --git a/libs/hostgraphics/gui/BufferQueue.h b/libs/hostgraphics/gui/BufferQueue.h index aa3e7268e11c..67a8c00fd267 100644 --- a/libs/hostgraphics/gui/BufferQueue.h +++ b/libs/hostgraphics/gui/BufferQueue.h @@ -29,7 +29,7 @@ public: enum { NO_BUFFER_AVAILABLE = IGraphicBufferConsumer::NO_BUFFER_AVAILABLE }; static void createBufferQueue(sp<IGraphicBufferProducer>* outProducer, - sp<IGraphicBufferConsumer>* outConsumer); + sp<IGraphicBufferConsumer>* outConsumer); }; } // namespace android diff --git a/libs/hostgraphics/gui/ConsumerBase.h b/libs/hostgraphics/gui/ConsumerBase.h index 9002953c0848..7f7309e8a3a8 100644 --- a/libs/hostgraphics/gui/ConsumerBase.h +++ b/libs/hostgraphics/gui/ConsumerBase.h @@ -18,7 +18,6 @@ #define ANDROID_GUI_CONSUMERBASE_H #include <gui/BufferItem.h> - #include <utils/RefBase.h> namespace android { @@ -28,10 +27,11 @@ public: struct FrameAvailableListener : public virtual RefBase { // See IConsumerListener::onFrame{Available,Replaced} virtual void onFrameAvailable(const BufferItem& item) = 0; + virtual void onFrameReplaced(const BufferItem& /* item */) {} }; }; } // namespace android -#endif // ANDROID_GUI_CONSUMERBASE_H
\ No newline at end of file +#endif // ANDROID_GUI_CONSUMERBASE_H diff --git a/libs/hostgraphics/gui/IGraphicBufferConsumer.h b/libs/hostgraphics/gui/IGraphicBufferConsumer.h index 9eb67b218800..14ac4fe71cc8 100644 --- a/libs/hostgraphics/gui/IGraphicBufferConsumer.h +++ b/libs/hostgraphics/gui/IGraphicBufferConsumer.h @@ -16,16 +16,16 @@ #pragma once -#include <utils/RefBase.h> - #include <ui/PixelFormat.h> - #include <utils/Errors.h> +#include <utils/RefBase.h> namespace android { class BufferItem; + class Fence; + class GraphicBuffer; class IGraphicBufferConsumer : virtual public RefBase { @@ -62,4 +62,4 @@ public: virtual status_t discardFreeBuffers() = 0; }; -} // namespace android
\ No newline at end of file +} // namespace android diff --git a/libs/hostgraphics/gui/IGraphicBufferProducer.h b/libs/hostgraphics/gui/IGraphicBufferProducer.h index 1447a4fd3695..8fd8590d10d7 100644 --- a/libs/hostgraphics/gui/IGraphicBufferProducer.h +++ b/libs/hostgraphics/gui/IGraphicBufferProducer.h @@ -17,9 +17,8 @@ #ifndef ANDROID_GUI_IGRAPHICBUFFERPRODUCER_H #define ANDROID_GUI_IGRAPHICBUFFERPRODUCER_H -#include <utils/RefBase.h> - #include <ui/GraphicBuffer.h> +#include <utils/RefBase.h> namespace android { diff --git a/libs/hostgraphics/gui/Surface.h b/libs/hostgraphics/gui/Surface.h index 0d810370c47c..2774f89cb54c 100644 --- a/libs/hostgraphics/gui/Surface.h +++ b/libs/hostgraphics/gui/Surface.h @@ -28,17 +28,25 @@ namespace android { class Surface : public ANativeObjectBase<ANativeWindow, Surface, RefBase> { public: explicit Surface(const sp<IGraphicBufferProducer>& bufferProducer, bool controlledByApp = false) - : mBufferProducer(bufferProducer) { + : mBufferProducer(bufferProducer) { ANativeWindow::perform = hook_perform; ANativeWindow::dequeueBuffer = hook_dequeueBuffer; ANativeWindow::query = hook_query; } - static bool isValid(const sp<Surface>& surface) { return surface != nullptr; } + + static bool isValid(const sp<Surface>& surface) { + return surface != nullptr; + } + void allocateBuffers() {} - uint64_t getNextFrameNumber() const { return 0; } + uint64_t getNextFrameNumber() const { + return 0; + } - int setScalingMode(int mode) { return 0; } + int setScalingMode(int mode) { + return 0; + } virtual int disconnect(int api, IGraphicBufferProducer::DisconnectMode mode = @@ -50,16 +58,28 @@ public: // TODO: implement this return 0; } - virtual int unlockAndPost() { return 0; } - virtual int query(int what, int* value) const { return mBufferProducer->query(what, value); } - status_t setDequeueTimeout(nsecs_t timeout) { return OK; } + virtual int unlockAndPost() { + return 0; + } - nsecs_t getLastDequeueStartTime() const { return 0; } + virtual int query(int what, int* value) const { + return mBufferProducer->query(what, value); + } + + status_t setDequeueTimeout(nsecs_t timeout) { + return OK; + } + + nsecs_t getLastDequeueStartTime() const { + return 0; + } virtual void destroy() {} - int getBuffersDataSpace() { return 0; } + int getBuffersDataSpace() { + return 0; + } protected: virtual ~Surface() {} @@ -89,15 +109,31 @@ protected: *buffer = mBuffer.get(); return OK; } - virtual int cancelBuffer(ANativeWindowBuffer* buffer, int fenceFd) { return 0; } - virtual int queueBuffer(ANativeWindowBuffer* buffer, int fenceFd) { return 0; } - virtual int perform(int operation, va_list args) { return 0; } - virtual int setSwapInterval(int interval) { return 0; } - virtual int setBufferCount(int bufferCount) { return 0; } + + virtual int cancelBuffer(ANativeWindowBuffer* buffer, int fenceFd) { + return 0; + } + + virtual int queueBuffer(ANativeWindowBuffer* buffer, int fenceFd) { + return 0; + } + + virtual int perform(int operation, va_list args) { + return 0; + } + + virtual int setSwapInterval(int interval) { + return 0; + } + + virtual int setBufferCount(int bufferCount) { + return 0; + } private: // can't be copied Surface& operator=(const Surface& rhs); + Surface(const Surface& rhs); const sp<IGraphicBufferProducer> mBufferProducer; @@ -106,4 +142,4 @@ private: } // namespace android -#endif // ANDROID_GUI_SURFACE_H +#endif // ANDROID_GUI_SURFACE_H diff --git a/libs/hostgraphics/ui/Fence.h b/libs/hostgraphics/ui/Fence.h index 04d535c3a211..187c3116f61c 100644 --- a/libs/hostgraphics/ui/Fence.h +++ b/libs/hostgraphics/ui/Fence.h @@ -17,8 +17,8 @@ #ifndef ANDROID_FENCE_H #define ANDROID_FENCE_H -#include <utils/String8.h> #include <utils/RefBase.h> +#include <utils/String8.h> typedef int64_t nsecs_t; @@ -26,11 +26,14 @@ namespace android { class Fence : public LightRefBase<Fence> { public: - Fence() { } - Fence(int) { } + Fence() {} + + Fence(int) {} + static const sp<Fence> NO_FENCE; static constexpr nsecs_t SIGNAL_TIME_PENDING = INT64_MAX; static constexpr nsecs_t SIGNAL_TIME_INVALID = -1; + static sp<Fence> merge(const char* name, const sp<Fence>& f1, const sp<Fence>& f2) { return NO_FENCE; } @@ -40,16 +43,22 @@ public: } enum class Status { - Invalid, // Fence is invalid - Unsignaled, // Fence is valid but has not yet signaled - Signaled, // Fence is valid and has signaled + Invalid, // Fence is invalid + Unsignaled, // Fence is valid but has not yet signaled + Signaled, // Fence is valid and has signaled }; - status_t wait(int timeout) { return OK; } + status_t wait(int timeout) { + return OK; + } - status_t waitForever(const char* logname) { return OK; } + status_t waitForever(const char* logname) { + return OK; + } - int dup() const { return 0; } + int dup() const { + return 0; + } inline Status getStatus() { // The sync_wait call underlying wait() has been measured to be diff --git a/libs/hostgraphics/ui/GraphicBuffer.h b/libs/hostgraphics/ui/GraphicBuffer.h index eec9b235cd6a..cda45e4660ca 100644 --- a/libs/hostgraphics/ui/GraphicBuffer.h +++ b/libs/hostgraphics/ui/GraphicBuffer.h @@ -19,34 +19,51 @@ #include <stdint.h> #include <sys/types.h> - -#include <vector> - #include <ui/ANativeObjectBase.h> #include <ui/PixelFormat.h> #include <ui/Rect.h> #include <utils/RefBase.h> +#include <vector> + namespace android { class GraphicBuffer : public ANativeObjectBase<ANativeWindowBuffer, GraphicBuffer, RefBase> { public: GraphicBuffer(uint32_t w, uint32_t h) { - data.resize(w*h); + data.resize(w * h); reserved[0] = data.data(); width = w; height = h; } - uint32_t getWidth() const { return static_cast<uint32_t>(width); } - uint32_t getHeight() const { return static_cast<uint32_t>(height); } - uint32_t getStride() const { return static_cast<uint32_t>(width); } - uint64_t getUsage() const { return 0; } - PixelFormat getPixelFormat() const { return PIXEL_FORMAT_RGBA_8888; } - Rect getBounds() const { return Rect(width, height); } + uint32_t getWidth() const { + return static_cast<uint32_t>(width); + } + + uint32_t getHeight() const { + return static_cast<uint32_t>(height); + } + + uint32_t getStride() const { + return static_cast<uint32_t>(width); + } + + uint64_t getUsage() const { + return 0; + } + + PixelFormat getPixelFormat() const { + return PIXEL_FORMAT_RGBA_8888; + } + + Rect getBounds() const { + return Rect(width, height); + } - status_t lockAsyncYCbCr(uint32_t inUsage, const Rect& rect, - android_ycbcr *ycbcr, int fenceFd) { return OK; } + status_t lockAsyncYCbCr(uint32_t inUsage, const Rect& rect, android_ycbcr* ycbcr, int fenceFd) { + return OK; + } status_t lockAsync(uint32_t inUsage, const Rect& rect, void** vaddr, int fenceFd, int32_t* outBytesPerPixel = nullptr, int32_t* outBytesPerStride = nullptr) { @@ -54,7 +71,9 @@ public: return OK; } - status_t unlockAsync(int *fenceFd) { return OK; } + status_t unlockAsync(int* fenceFd) { + return OK; + } private: std::vector<uint32_t> data; |