summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Po-Chien Hsueh <pchsueh@google.com> 2017-02-09 10:38:34 +0800
committer Po-Chien Hsueh <pchsueh@google.com> 2017-02-09 15:00:09 +0800
commitc5ae595e6f71798109c730cd835a2cca79a8877c (patch)
treea228eb79eb5003000262b29c28ed67e67844ae56
parent47c4c94100e1ec861d2c2593ad66ba050bbe93fe (diff)
Remove build flag ANDROID_ENABLE_RENDERSCRIPT
remove this flag and consider renderscript is always enabled Bug: 34693640 Test: compile Change-Id: I22464e1d64f2a55a60ba9f8ab1510f2811605552
-rw-r--r--core/jni/Android.mk2
-rw-r--r--libs/hwui/Android.mk12
-rw-r--r--libs/hwui/FontRenderer.cpp12
-rw-r--r--libs/hwui/FontRenderer.h4
-rw-r--r--libs/hwui/hwui_static_deps.mk5
5 files changed, 10 insertions, 25 deletions
diff --git a/core/jni/Android.mk b/core/jni/Android.mk
index db3ea8c51bf4..dd2f365bb86a 100644
--- a/core/jni/Android.mk
+++ b/core/jni/Android.mk
@@ -203,6 +203,8 @@ LOCAL_C_INCLUDES += \
$(call include-path-for, libhardware)/hardware \
$(call include-path-for, libhardware_legacy)/hardware_legacy \
$(TOP)/frameworks/base/media/jni \
+ $(TOP)/frameworks/rs/cpp \
+ $(TOP)/frameworks/rs \
$(TOP)/system/core/base/include \
$(TOP)/system/core/include \
$(TOP)/system/core/libappfuse/include \
diff --git a/libs/hwui/Android.mk b/libs/hwui/Android.mk
index 692199d7af1f..ff40c8a9fb92 100644
--- a/libs/hwui/Android.mk
+++ b/libs/hwui/Android.mk
@@ -189,13 +189,11 @@ hwui_c_includes += \
external/harfbuzz_ng/src \
external/freetype/include
-ifneq (false,$(ANDROID_ENABLE_RENDERSCRIPT))
- hwui_cflags += -DANDROID_ENABLE_RENDERSCRIPT
- hwui_c_includes += \
- $(call intermediates-dir-for,STATIC_LIBRARIES,TARGET,) \
- frameworks/rs/cpp \
- frameworks/rs
-endif
+# enable RENDERSCRIPT
+hwui_c_includes += \
+ $(call intermediates-dir-for,STATIC_LIBRARIES,TARGET,) \
+ frameworks/rs/cpp \
+ frameworks/rs
# ------------------------
# static library
diff --git a/libs/hwui/FontRenderer.cpp b/libs/hwui/FontRenderer.cpp
index 4f9a3de64fc2..ee99018fb652 100644
--- a/libs/hwui/FontRenderer.cpp
+++ b/libs/hwui/FontRenderer.cpp
@@ -33,14 +33,11 @@
#include <algorithm>
#include <cutils/properties.h>
+#include <RenderScript.h>
#include <SkGlyph.h>
#include <SkUtils.h>
#include <utils/Log.h>
-#ifdef ANDROID_ENABLE_RENDERSCRIPT
-#include <RenderScript.h>
-#endif
-
namespace android {
namespace uirenderer {
@@ -591,17 +588,12 @@ FontRenderer::DropShadow FontRenderer::renderDropShadow(const SkPaint* paint, co
return image;
}
-#ifdef ANDROID_ENABLE_RENDERSCRIPT
// Align buffers for renderscript usage
if (paddedWidth & (RS_CPU_ALLOCATION_ALIGNMENT - 1)) {
paddedWidth += RS_CPU_ALLOCATION_ALIGNMENT - paddedWidth % RS_CPU_ALLOCATION_ALIGNMENT;
}
int size = paddedWidth * paddedHeight;
uint8_t* dataBuffer = (uint8_t*) memalign(RS_CPU_ALLOCATION_ALIGNMENT, size);
-#else
- int size = paddedWidth * paddedHeight;
- uint8_t* dataBuffer = (uint8_t*) malloc(size);
-#endif
memset(dataBuffer, 0, size);
@@ -691,7 +683,6 @@ bool FontRenderer::renderTextOnPath(const SkPaint* paint, const Rect* clip, cons
void FontRenderer::blurImage(uint8_t** image, int32_t width, int32_t height, float radius) {
uint32_t intRadius = Blur::convertRadiusToInt(radius);
-#ifdef ANDROID_ENABLE_RENDERSCRIPT
if (width * height * intRadius >= RS_MIN_INPUT_CUTOFF && radius <= 25.0f) {
uint8_t* outImage = (uint8_t*) memalign(RS_CPU_ALLOCATION_ALIGNMENT, width * height);
@@ -729,7 +720,6 @@ void FontRenderer::blurImage(uint8_t** image, int32_t width, int32_t height, flo
return;
}
}
-#endif
std::unique_ptr<float[]> gaussian(new float[2 * intRadius + 1]);
Blur::generateGaussianWeights(gaussian.get(), radius);
diff --git a/libs/hwui/FontRenderer.h b/libs/hwui/FontRenderer.h
index dd9c40f89ad0..329309c1cd5c 100644
--- a/libs/hwui/FontRenderer.h
+++ b/libs/hwui/FontRenderer.h
@@ -34,7 +34,6 @@
#include <vector>
-#ifdef ANDROID_ENABLE_RENDERSCRIPT
#include "RenderScript.h"
namespace RSC {
class Element;
@@ -42,7 +41,6 @@ namespace RSC {
class ScriptIntrinsicBlur;
class sp;
}
-#endif
namespace android {
namespace uirenderer {
@@ -201,12 +199,10 @@ private:
FontCacheHistoryTracker mHistoryTracker;
#endif
-#ifdef ANDROID_ENABLE_RENDERSCRIPT
// RS constructs
RSC::sp<RSC::RS> mRs;
RSC::sp<const RSC::Element> mRsElement;
RSC::sp<RSC::ScriptIntrinsicBlur> mRsScript;
-#endif
static void computeGaussianWeights(float* weights, int32_t radius);
static void horizontalBlur(float* weights, int32_t radius, const uint8_t *source, uint8_t *dest,
diff --git a/libs/hwui/hwui_static_deps.mk b/libs/hwui/hwui_static_deps.mk
index f69da484af43..a75fd6a8d587 100644
--- a/libs/hwui/hwui_static_deps.mk
+++ b/libs/hwui/hwui_static_deps.mk
@@ -28,6 +28,5 @@ LOCAL_SHARED_LIBRARIES += \
libminikin \
libandroidfw
-ifneq (false,$(ANDROID_ENABLE_RENDERSCRIPT))
- LOCAL_SHARED_LIBRARIES += libRScpp
-endif
+# enable RENDERSCRIPT
+LOCAL_SHARED_LIBRARIES += libRScpp