summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Yi Kong <yikong@google.com> 2024-08-12 07:03:29 +0800
committer Yi Kong <yikong@google.com> 2024-08-12 17:47:11 +0800
commit95af4cae9771735ed490aa8ca2a6e42fd34be415 (patch)
treed4acd34330df348a594d16b8f5ee1197de1563cb
parenta35b1f13ddef1d27f368c371dcd942c2c3fb37df (diff)
Remove unnecessary std::move
Moving a temporary object prevents copy elision, and could reduce performance. This fixes -Wpessimizing-move compiler warning. Test: presubmit Bug: 154270751 Change-Id: I4c769b174bb2a1fab2928c4887dcb70d82f264fa
-rw-r--r--libs/androidfw/PosixUtils.cpp2
-rw-r--r--media/jni/android_media_MediaCodecLinearBlock.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/libs/androidfw/PosixUtils.cpp b/libs/androidfw/PosixUtils.cpp
index 8ddc57240129..49ee8f7ac4eb 100644
--- a/libs/androidfw/PosixUtils.cpp
+++ b/libs/androidfw/PosixUtils.cpp
@@ -119,7 +119,7 @@ ProcResult ExecuteBinary(const std::vector<std::string>& argv) {
auto err = ReadFile(stderr[0]);
result.stderr_str = err ? std::move(*err) : "";
close(stderr[0]);
- return std::move(result);
+ return result;
}
}
diff --git a/media/jni/android_media_MediaCodecLinearBlock.h b/media/jni/android_media_MediaCodecLinearBlock.h
index 060abfdc1ee5..ffbf0a826b4a 100644
--- a/media/jni/android_media_MediaCodecLinearBlock.h
+++ b/media/jni/android_media_MediaCodecLinearBlock.h
@@ -62,7 +62,7 @@ struct JMediaCodecLinearBlock {
std::shared_ptr<C2Buffer> buffer =
C2Buffer::CreateLinearBuffer(block.subBlock(offset, size));
for (const std::shared_ptr<const C2Info> &info : mBuffer->info()) {
- std::shared_ptr<C2Param> param = std::move(C2Param::Copy(*info));
+ std::shared_ptr<C2Param> param = C2Param::Copy(*info);
buffer->setInfo(std::static_pointer_cast<C2Info>(param));
}
return buffer;