diff options
author | 2024-09-26 13:00:11 -0700 | |
---|---|---|
committer | 2024-09-27 15:48:15 -0700 | |
commit | 8da8dd1daa129dc7eb36096e4215986578ea69ea (patch) | |
tree | 16eef95175b16e8ffc1d3b63fa60d27aa49227ed | |
parent | 6beeee510c4624023f667ceba172c24fb8352369 (diff) |
Fix UnusedVariable errorprone issues
https://errorprone.info/bugpattern/UnusedVariable
https://errorprone.info/bugpattern/UnusedTypeParameter
https://errorprone.info/bugpattern/UnusedNestedClass
https://errorprone.info/bugpattern/UnusedMethod
https://errorprone.info/bugpattern/UnusedLabel
Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: Idae6fd5c085fc71e7a0222ee379dd16a7b6a1f20
3 files changed, 3 insertions, 17 deletions
diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/RequiresPermissionChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/RequiresPermissionChecker.java index 9887c272e7f8..af26bd0a3404 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/RequiresPermissionChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/RequiresPermissionChecker.java @@ -130,10 +130,6 @@ public final class RequiresPermissionChecker extends BugChecker .onDescendantOf("android.content.Context") .withNameMatching( Pattern.compile("^send(Ordered|Sticky)?Broadcast.*AsUser.*$"))); - private static final Matcher<ExpressionTree> SEND_PENDING_INTENT = methodInvocation( - instanceMethod() - .onDescendantOf("android.app.PendingIntent") - .named("send")); private static final Matcher<ExpressionTree> INTENT_SET_ACTION = methodInvocation( instanceMethod().onDescendantOf("android.content.Intent").named("setAction")); diff --git a/ravenwood/runtime-common-src/com/android/ravenwood/common/RavenwoodCommonUtils.java b/ravenwood/runtime-common-src/com/android/ravenwood/common/RavenwoodCommonUtils.java index ef795c63880e..520f050f0655 100644 --- a/ravenwood/runtime-common-src/com/android/ravenwood/common/RavenwoodCommonUtils.java +++ b/ravenwood/runtime-common-src/com/android/ravenwood/common/RavenwoodCommonUtils.java @@ -37,8 +37,6 @@ public class RavenwoodCommonUtils { private RavenwoodCommonUtils() { } - private static final Object sLock = new Object(); - /** * If set to "1", we enable the verbose logging. * @@ -68,9 +66,6 @@ public class RavenwoodCommonUtils { public static final String RAVENWOOD_VERSION_JAVA_SYSPROP = "android.ravenwood.version"; - // @GuardedBy("sLock") - private static boolean sIntegrityChecked = false; - /** * @return if we're running on Ravenwood. */ diff --git a/ravenwood/runtime-helper-src/libcore-fake/libcore/util/NativeAllocationRegistry.java b/ravenwood/runtime-helper-src/libcore-fake/libcore/util/NativeAllocationRegistry.java index 4e7dc5d6264f..ad86135de32e 100644 --- a/ravenwood/runtime-helper-src/libcore-fake/libcore/util/NativeAllocationRegistry.java +++ b/ravenwood/runtime-helper-src/libcore-fake/libcore/util/NativeAllocationRegistry.java @@ -32,25 +32,20 @@ public class NativeAllocationRegistry { public static NativeAllocationRegistry createNonmalloced( ClassLoader classLoader, long freeFunction, long size) { - return new NativeAllocationRegistry(classLoader, freeFunction, size, false); + return new NativeAllocationRegistry(classLoader, freeFunction, size); } public static NativeAllocationRegistry createMalloced( ClassLoader classLoader, long freeFunction, long size) { - return new NativeAllocationRegistry(classLoader, freeFunction, size, true); + return new NativeAllocationRegistry(classLoader, freeFunction, size); } public static NativeAllocationRegistry createMalloced( ClassLoader classLoader, long freeFunction) { - return new NativeAllocationRegistry(classLoader, freeFunction, 0, true); + return new NativeAllocationRegistry(classLoader, freeFunction, 0); } public NativeAllocationRegistry(ClassLoader classLoader, long freeFunction, long size) { - this(classLoader, freeFunction, size, size == 0); - } - - private NativeAllocationRegistry(ClassLoader classLoader, long freeFunction, long size, - boolean mallocAllocation) { if (size < 0) { throw new IllegalArgumentException("Invalid native allocation size: " + size); } |