summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author tmfang <tmfang@google.com> 2019-04-24 16:59:59 +0800
committer tmfang <tmfang@google.com> 2019-04-25 10:47:00 +0800
commit7007e7947ec64a471e8bbf46153fc8af2a941083 (patch)
tree1e0d71bd8c282adcd96ee061445dfcea8190b50b
parent0cab8dc0db59bbbcc1f76f46c82b5dec3d2e21d6 (diff)
Fix talkback issue on bar chart
We set content description on icon view, so this is why talkback speaks the permission name twice. Test: open talkback, and click bar chart. Fixes: 130842756 Change-Id: I2ed4916de0a249f61d97dc00fa95193560b3d74c
-rw-r--r--packages/SettingsLib/BarChartPreference/src/com/android/settingslib/widget/BarView.java8
1 files changed, 7 insertions, 1 deletions
diff --git a/packages/SettingsLib/BarChartPreference/src/com/android/settingslib/widget/BarView.java b/packages/SettingsLib/BarChartPreference/src/com/android/settingslib/widget/BarView.java
index fccb7196b12f..93a34c03bf92 100644
--- a/packages/SettingsLib/BarChartPreference/src/com/android/settingslib/widget/BarView.java
+++ b/packages/SettingsLib/BarChartPreference/src/com/android/settingslib/widget/BarView.java
@@ -18,6 +18,7 @@ package com.android.settingslib.widget;
import android.content.Context;
import android.content.res.TypedArray;
+import android.text.TextUtils;
import android.util.AttributeSet;
import android.view.Gravity;
import android.view.LayoutInflater;
@@ -73,7 +74,12 @@ public class BarView extends LinearLayout {
mIcon.setImageDrawable(barViewInfo.getIcon());
mBarTitle.setText(barViewInfo.getTitle());
mBarSummary.setText(barViewInfo.getSummary());
- mIcon.setContentDescription(barViewInfo.getContentDescription());
+
+ final CharSequence barViewInfoContent = barViewInfo.getContentDescription();
+ if (!TextUtils.isEmpty(barViewInfoContent)
+ && !TextUtils.equals((barViewInfo.getTitle()), barViewInfoContent)) {
+ mIcon.setContentDescription(barViewInfo.getContentDescription());
+ }
}
@VisibleForTesting