diff options
author | 2023-03-03 15:50:06 -0800 | |
---|---|---|
committer | 2023-03-07 11:23:49 -0800 | |
commit | 587fb57aabc9871950307a70855af9491319523d (patch) | |
tree | d40467e37592c803a4d2690096ee5c92346fe34c | |
parent | 5a0ac4f8e337b2892c0806095ffbe13feb8f99d8 (diff) |
Support gainmap HW copy.
- for Bitmap::allocateHardwareBitmap to create and upload a hardware
version of the gainmap.
Bug: 267216439
Test: android.graphics.cts.BitmapFactoryTest,
android.graphics.cts.BitmapRegionDecoderTest,
android.graphics.cts.ImageDecoderTest, android.graphics.cts.GainmapTest
Change-Id: Ie080896425dc82a605b2bc41e97ddc2420f5328a
-rw-r--r-- | libs/hwui/Android.bp | 1 | ||||
-rw-r--r-- | libs/hwui/Gainmap.cpp | 32 | ||||
-rw-r--r-- | libs/hwui/Gainmap.h | 1 | ||||
-rw-r--r-- | libs/hwui/jni/Bitmap.cpp | 11 | ||||
-rw-r--r-- | libs/hwui/jni/BitmapFactory.cpp | 5 | ||||
-rw-r--r-- | libs/hwui/jni/BitmapRegionDecoder.cpp | 5 | ||||
-rw-r--r-- | libs/hwui/jni/ImageDecoder.cpp | 6 |
7 files changed, 49 insertions, 12 deletions
diff --git a/libs/hwui/Android.bp b/libs/hwui/Android.bp index 7228b895ebc4..3b129720c727 100644 --- a/libs/hwui/Android.bp +++ b/libs/hwui/Android.bp @@ -537,6 +537,7 @@ cc_defaults { "AnimatorManager.cpp", "CanvasTransform.cpp", "DamageAccumulator.cpp", + "Gainmap.cpp", "Interpolator.cpp", "LightingInfo.cpp", "Matrix.cpp", diff --git a/libs/hwui/Gainmap.cpp b/libs/hwui/Gainmap.cpp new file mode 100644 index 000000000000..30f401ef5f01 --- /dev/null +++ b/libs/hwui/Gainmap.cpp @@ -0,0 +1,32 @@ +/** + * Copyright (C) 2023 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#include "Gainmap.h" + +namespace android::uirenderer { + +sp<Gainmap> Gainmap::allocateHardwareGainmap(const sp<Gainmap>& srcGainmap) { + auto gainmap = sp<Gainmap>::make(); + gainmap->info = srcGainmap->info; + const SkBitmap skSrcBitmap = srcGainmap->bitmap->getSkBitmap(); + sk_sp<Bitmap> skBitmap(Bitmap::allocateHardwareBitmap(skSrcBitmap)); + if (!skBitmap.get()) { + return nullptr; + } + gainmap->bitmap = std::move(skBitmap); + return gainmap; +} + +} // namespace android::uirenderer
\ No newline at end of file diff --git a/libs/hwui/Gainmap.h b/libs/hwui/Gainmap.h index 765f98a257b8..3bc183ab854f 100644 --- a/libs/hwui/Gainmap.h +++ b/libs/hwui/Gainmap.h @@ -27,6 +27,7 @@ class Gainmap : public LightRefBase<Gainmap> { public: SkGainmapInfo info; sk_sp<Bitmap> bitmap; + static sp<Gainmap> allocateHardwareGainmap(const sp<Gainmap>& srcGainmap); }; } // namespace android::uirenderer diff --git a/libs/hwui/jni/Bitmap.cpp b/libs/hwui/jni/Bitmap.cpp index 3f9c4bd2aeff..6ee7576651f2 100644 --- a/libs/hwui/jni/Bitmap.cpp +++ b/libs/hwui/jni/Bitmap.cpp @@ -386,15 +386,10 @@ static jobject Bitmap_copy(JNIEnv* env, jobject, jlong srcHandle, jint dstConfig return NULL; } if (hasGainmap) { - auto gainmap = sp<uirenderer::Gainmap>::make(); - gainmap->info = original.gainmap()->info; - const SkBitmap skSrcBitmap = original.gainmap()->bitmap->getSkBitmap(); - sk_sp<Bitmap> skBitmap(Bitmap::allocateHardwareBitmap(skSrcBitmap)); - if (!skBitmap.get()) { - return NULL; + auto gm = uirenderer::Gainmap::allocateHardwareGainmap(original.gainmap()); + if (gm) { + bitmap->setGainmap(std::move(gm)); } - gainmap->bitmap = std::move(skBitmap); - bitmap->setGainmap(std::move(gainmap)); } return createBitmap(env, bitmap.release(), getPremulBitmapCreateFlags(isMutable)); } diff --git a/libs/hwui/jni/BitmapFactory.cpp b/libs/hwui/jni/BitmapFactory.cpp index 571ab833f053..c57e6f09347a 100644 --- a/libs/hwui/jni/BitmapFactory.cpp +++ b/libs/hwui/jni/BitmapFactory.cpp @@ -637,7 +637,10 @@ static jobject doDecode(JNIEnv* env, std::unique_ptr<SkStreamRewindable> stream, return nullObjectReturn("Failed to allocate a hardware bitmap"); } if (hasGainmap) { - hardwareBitmap->setGainmap(std::move(gainmap)); + auto gm = uirenderer::Gainmap::allocateHardwareGainmap(gainmap); + if (gm) { + hardwareBitmap->setGainmap(std::move(gm)); + } } return bitmap::createBitmap(env, hardwareBitmap.release(), bitmapCreateFlags, diff --git a/libs/hwui/jni/BitmapRegionDecoder.cpp b/libs/hwui/jni/BitmapRegionDecoder.cpp index f93be038cc36..aeaa17198be5 100644 --- a/libs/hwui/jni/BitmapRegionDecoder.cpp +++ b/libs/hwui/jni/BitmapRegionDecoder.cpp @@ -334,7 +334,10 @@ static jobject nativeDecodeRegion(JNIEnv* env, jobject, jlong brdHandle, jint in if (isHardware) { sk_sp<Bitmap> hardwareBitmap = Bitmap::allocateHardwareBitmap(bitmap); if (hasGainmap) { - hardwareBitmap->setGainmap(std::move(gainmap)); + auto gm = uirenderer::Gainmap::allocateHardwareGainmap(gainmap); + if (gm) { + hardwareBitmap->setGainmap(std::move(gm)); + } } return bitmap::createBitmap(env, hardwareBitmap.release(), bitmapCreateFlags); } diff --git a/libs/hwui/jni/ImageDecoder.cpp b/libs/hwui/jni/ImageDecoder.cpp index fda7080f2864..ad80460da5a9 100644 --- a/libs/hwui/jni/ImageDecoder.cpp +++ b/libs/hwui/jni/ImageDecoder.cpp @@ -469,8 +469,10 @@ static jobject ImageDecoder_nDecodeBitmap(JNIEnv* env, jobject /*clazz*/, jlong if (hwBitmap) { hwBitmap->setImmutable(); if (nativeBitmap->hasGainmap()) { - // TODO: Also convert to a HW gainmap image - hwBitmap->setGainmap(nativeBitmap->gainmap()); + auto gm = uirenderer::Gainmap::allocateHardwareGainmap(nativeBitmap->gainmap()); + if (gm) { + hwBitmap->setGainmap(std::move(gm)); + } } return bitmap::createBitmap(env, hwBitmap.release(), bitmapCreateFlags, ninePatchChunk, ninePatchInsets); |