diff options
| author | 2021-01-03 20:57:35 -0500 | |
|---|---|---|
| committer | 2021-01-04 02:08:15 +0000 | |
| commit | 4efe0bed468b6c4e76d607579dc6e79c524cbe72 (patch) | |
| tree | 29bb2cb1b5f3d04ef21242c2fed32d511b736b93 | |
| parent | 86e3bd8a07bdfacc887230f82d0caab76943275c (diff) | |
onDrawImageNine is no longer used
nine-patch draws now route through onDrawImageLattice, and canvas no
longer ever calls onDrawImageNine.
Test: make
Change-Id: Ie1d5b0c72690a4986e97efa1feeb736ef704a079
| -rw-r--r-- | libs/hwui/DisplayListOps.in | 1 | ||||
| -rw-r--r-- | libs/hwui/RecordingCanvas.cpp | 25 | ||||
| -rw-r--r-- | libs/hwui/RecordingCanvas.h | 1 | ||||
| -rw-r--r-- | libs/hwui/pipeline/skia/DumpOpsCanvas.h | 5 | ||||
| -rw-r--r-- | libs/hwui/tests/common/CallCountingCanvas.h | 8 | ||||
| -rw-r--r-- | libs/hwui/tests/unit/FatalTestCanvas.h | 3 |
6 files changed, 1 insertions, 42 deletions
diff --git a/libs/hwui/DisplayListOps.in b/libs/hwui/DisplayListOps.in index c6c4ba8a6493..1b1be4311498 100644 --- a/libs/hwui/DisplayListOps.in +++ b/libs/hwui/DisplayListOps.in @@ -40,7 +40,6 @@ X(DrawAnnotation) X(DrawDrawable) X(DrawPicture) X(DrawImage) -X(DrawImageNine) X(DrawImageRect) X(DrawImageLattice) X(DrawTextBlob) diff --git a/libs/hwui/RecordingCanvas.cpp b/libs/hwui/RecordingCanvas.cpp index a495ec4ac411..a2028ca3d274 100644 --- a/libs/hwui/RecordingCanvas.cpp +++ b/libs/hwui/RecordingCanvas.cpp @@ -319,23 +319,6 @@ struct DrawImage final : Op { BitmapPalette palette; void draw(SkCanvas* c, const SkMatrix&) const { c->drawImage(image.get(), x, y, &paint); } }; -struct DrawImageNine final : Op { - static const auto kType = Type::DrawImageNine; - DrawImageNine(sk_sp<const SkImage>&& image, const SkIRect& center, const SkRect& dst, - const SkPaint* paint) - : image(std::move(image)), center(center), dst(dst) { - if (paint) { - this->paint = *paint; - } - } - sk_sp<const SkImage> image; - SkIRect center; - SkRect dst; - SkPaint paint; - void draw(SkCanvas* c, const SkMatrix&) const { - c->drawImageNine(image.get(), center, dst, &paint); - } -}; struct DrawImageRect final : Op { static const auto kType = Type::DrawImageRect; DrawImageRect(sk_sp<const SkImage>&& image, const SkRect* src, const SkRect& dst, @@ -633,10 +616,6 @@ void DisplayListData::drawImage(sk_sp<const SkImage> image, SkScalar x, SkScalar const SkPaint* paint, BitmapPalette palette) { this->push<DrawImage>(0, std::move(image), x, y, paint, palette); } -void DisplayListData::drawImageNine(sk_sp<const SkImage> image, const SkIRect& center, - const SkRect& dst, const SkPaint* paint) { - this->push<DrawImageNine>(0, std::move(image), center, dst, paint); -} void DisplayListData::drawImageRect(sk_sp<const SkImage> image, const SkRect* src, const SkRect& dst, const SkPaint* paint, SkCanvas::SrcRectConstraint constraint, BitmapPalette palette) { @@ -944,10 +923,6 @@ void RecordingCanvas::onDrawImage(const SkImage* img, SkScalar x, SkScalar y, const SkPaint* paint) { fDL->drawImage(sk_ref_sp(img), x, y, paint, BitmapPalette::Unknown); } -void RecordingCanvas::onDrawImageNine(const SkImage* img, const SkIRect& center, const SkRect& dst, - const SkPaint* paint) { - fDL->drawImageNine(sk_ref_sp(img), center, dst, paint); -} void RecordingCanvas::onDrawImageRect(const SkImage* img, const SkRect* src, const SkRect& dst, const SkPaint* paint, SrcRectConstraint constraint) { fDL->drawImageRect(sk_ref_sp(img), src, dst, paint, constraint, BitmapPalette::Unknown); diff --git a/libs/hwui/RecordingCanvas.h b/libs/hwui/RecordingCanvas.h index 4851148cd4d8..9e2b0a970e96 100644 --- a/libs/hwui/RecordingCanvas.h +++ b/libs/hwui/RecordingCanvas.h @@ -188,7 +188,6 @@ public: void onDrawImage(const SkImage*, SkScalar, SkScalar, const SkPaint*) override; void onDrawImageLattice(const SkImage*, const Lattice&, const SkRect&, const SkPaint*) override; - void onDrawImageNine(const SkImage*, const SkIRect&, const SkRect&, const SkPaint*) override; void onDrawImageRect(const SkImage*, const SkRect*, const SkRect&, const SkPaint*, SrcRectConstraint) override; diff --git a/libs/hwui/pipeline/skia/DumpOpsCanvas.h b/libs/hwui/pipeline/skia/DumpOpsCanvas.h index 0eb526af127a..d5b46d5f583e 100644 --- a/libs/hwui/pipeline/skia/DumpOpsCanvas.h +++ b/libs/hwui/pipeline/skia/DumpOpsCanvas.h @@ -90,11 +90,6 @@ protected: mOutput << mIdent << "drawImage" << std::endl; } - void onDrawImageNine(const SkImage*, const SkIRect& center, const SkRect& dst, - const SkPaint*) override { - mOutput << mIdent << "drawImageNine" << std::endl; - } - void onDrawImageRect(const SkImage*, const SkRect*, const SkRect&, const SkPaint*, SrcRectConstraint) override { mOutput << mIdent << "drawImageRect" << std::endl; diff --git a/libs/hwui/tests/common/CallCountingCanvas.h b/libs/hwui/tests/common/CallCountingCanvas.h index 594afd04860b..40b5747babda 100644 --- a/libs/hwui/tests/common/CallCountingCanvas.h +++ b/libs/hwui/tests/common/CallCountingCanvas.h @@ -119,12 +119,6 @@ public: drawImageRectCount++; } - int drawImageNineCount = 0; - void onDrawImageNine(const SkImage* image, const SkIRect& center, const SkRect& dst, - const SkPaint* paint) override { - drawImageNineCount++; - } - int drawImageLatticeCount = 0; void onDrawImageLattice(const SkImage* image, const SkCanvas::Lattice& lattice, const SkRect& dst, const SkPaint* paint) override { @@ -171,4 +165,4 @@ private: } /* namespace test */ } /* namespace uirenderer */ -} /* namespace android */
\ No newline at end of file +} /* namespace android */ diff --git a/libs/hwui/tests/unit/FatalTestCanvas.h b/libs/hwui/tests/unit/FatalTestCanvas.h index 76ae0853b477..8467be925cbb 100644 --- a/libs/hwui/tests/unit/FatalTestCanvas.h +++ b/libs/hwui/tests/unit/FatalTestCanvas.h @@ -74,9 +74,6 @@ public: SrcRectConstraint) { ADD_FAILURE() << "onDrawImageRect not expected in this test"; } - void onDrawImageNine(const SkImage*, const SkIRect& center, const SkRect& dst, const SkPaint*) { - ADD_FAILURE() << "onDrawImageNine not expected in this test"; - } void onDrawImageLattice(const SkImage*, const Lattice& lattice, const SkRect& dst, const SkPaint*) { ADD_FAILURE() << "onDrawImageLattice not expected in this test"; |