summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author David Liu <dswliu@google.com> 2025-02-21 17:26:50 -0800
committer David Liu <dswliu@google.com> 2025-02-21 17:28:17 -0800
commit3626e7089c98ef118ca2abd6c532044f14c80a4c (patch)
treedc7dc6186b0186f22b15618605688c367c30f731
parente8aa3de1085de99bdd4e58d55d83354b7f56acde (diff)
[CollapsingToolbar] Upstream G3 changes
- Add back CollapsingToolbarDelegate one parameter constructor to avoid breaking 1P apps dependencies. - Add filterTouchesWhenObscured to base layout to avoid hijack. - Suppress lint warnings. Bug: 398320195 Change-Id: I9f841b9920aaa834e065e235f687b31183f016bc Test: local build + presubmit Flag: EXEMPT resources and annotation update
-rw-r--r--packages/SettingsLib/CollapsingToolbarBaseActivity/res/layout-v31/non_collapsing_toolbar_base_layout.xml3
-rw-r--r--packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/CollapsingToolbarDelegate.java4
-rw-r--r--packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/widget/CollapsingCoordinatorLayout.java1
3 files changed, 7 insertions, 1 deletions
diff --git a/packages/SettingsLib/CollapsingToolbarBaseActivity/res/layout-v31/non_collapsing_toolbar_base_layout.xml b/packages/SettingsLib/CollapsingToolbarBaseActivity/res/layout-v31/non_collapsing_toolbar_base_layout.xml
index 1e48443fcf13..a49f4bee89a0 100644
--- a/packages/SettingsLib/CollapsingToolbarBaseActivity/res/layout-v31/non_collapsing_toolbar_base_layout.xml
+++ b/packages/SettingsLib/CollapsingToolbarBaseActivity/res/layout-v31/non_collapsing_toolbar_base_layout.xml
@@ -19,7 +19,8 @@
android:id="@+id/content_parent"
android:layout_width="match_parent"
android:layout_height="match_parent"
- android:fitsSystemWindows="true">
+ android:fitsSystemWindows="true"
+ android:filterTouchesWhenObscured="false">
<include layout="@layout/non_collapsing_toolbar_content_layout"/>
</androidx.coordinatorlayout.widget.CoordinatorLayout>
diff --git a/packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/CollapsingToolbarDelegate.java b/packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/CollapsingToolbarDelegate.java
index 01ecb66fed1a..de0d60916b3d 100644
--- a/packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/CollapsingToolbarDelegate.java
+++ b/packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/CollapsingToolbarDelegate.java
@@ -89,6 +89,10 @@ public class CollapsingToolbarDelegate {
private boolean mIsExpressiveTheme;
+ public CollapsingToolbarDelegate(@NonNull HostCallback hostCallback) {
+ this(hostCallback, /* useCollapsingToolbar= */ true);
+ }
+
public CollapsingToolbarDelegate(@NonNull HostCallback hostCallback,
boolean useCollapsingToolbar) {
mHostCallback = hostCallback;
diff --git a/packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/widget/CollapsingCoordinatorLayout.java b/packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/widget/CollapsingCoordinatorLayout.java
index 51d7504f136d..25d04009b6f8 100644
--- a/packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/widget/CollapsingCoordinatorLayout.java
+++ b/packages/SettingsLib/CollapsingToolbarBaseActivity/src/com/android/settingslib/collapsingtoolbar/widget/CollapsingCoordinatorLayout.java
@@ -105,6 +105,7 @@ public class CollapsingCoordinatorLayout extends CoordinatorLayout {
return true;
}
+ @SuppressWarnings("RestrictTo")
private void init() {
int resId = SettingsThemeHelper.isExpressiveTheme(getContext())
? R.layout.settingslib_expressive_collapsing_toolbar_content_layout