summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Adrian Roos <roosa@google.com> 2019-03-05 18:15:44 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2019-03-05 18:15:44 +0000
commit26968d81f8291f1dd4a0f8a7e962c60d62b9ef61 (patch)
treebbd974a31383bbc371c72d0b3fa75e7c228fde4f
parent6e16eb107dad783aa03037daa8434cf8bebb6e4f (diff)
parentcdb8167051afffa77348dfee991679480d4d31a8 (diff)
Merge "Apilint: No longer flag interface callbacks"
-rw-r--r--tools/apilint/apilint.py4
1 files changed, 0 insertions, 4 deletions
diff --git a/tools/apilint/apilint.py b/tools/apilint/apilint.py
index 75aeb5e2b288..a91fbe76be8d 100644
--- a/tools/apilint/apilint.py
+++ b/tools/apilint/apilint.py
@@ -826,7 +826,6 @@ def verify_method_names(clazz):
@verifier
def verify_callbacks(clazz):
"""Verify Callback classes.
- All callback classes must be abstract.
All methods must follow onFoo() naming style."""
if clazz.fullname == "android.speech.tts.SynthesisCallback": return
@@ -836,9 +835,6 @@ def verify_callbacks(clazz):
warn(clazz, None, "L1", "Class should be named FooCallback")
if clazz.name.endswith("Callback"):
- if "interface" in clazz.split:
- error(clazz, None, "CL3", "Callbacks must be abstract class to enable extension in future API levels")
-
for m in clazz.methods:
if not re.match("on[A-Z][a-z]*", m.name):
error(clazz, m, "L1", "Callback method names must be onFoo() style")