diff options
author | 2018-12-07 08:27:14 -0500 | |
---|---|---|
committer | 2018-12-07 08:27:18 -0500 | |
commit | 05f1d5c04b6cb9ad5a985a9979ffa7bb393f868f (patch) | |
tree | 68f67037fe429944205e7e639260dc60023488f3 | |
parent | b1910c47a83cfc993df8048c996a3d0534225633 (diff) |
remove overrides of onDrawText -- no longer called
Skia now routes drawText, drawPosText, drawPosTextH to textblobs, so
these virtuals are no longer needed/called.
Test: make
Change-Id: Ia9d98d6c4ac72cea4ed9ed938b5fd29dbfe8bf49
-rw-r--r-- | libs/hwui/RecordingCanvas.cpp | 12 | ||||
-rw-r--r-- | libs/hwui/RecordingCanvas.h | 4 | ||||
-rw-r--r-- | libs/hwui/pipeline/skia/DumpOpsCanvas.h | 12 | ||||
-rw-r--r-- | libs/hwui/tests/unit/FatalTestCanvas.h | 12 |
4 files changed, 0 insertions, 40 deletions
diff --git a/libs/hwui/RecordingCanvas.cpp b/libs/hwui/RecordingCanvas.cpp index c63e449319dd..0b847af157d1 100644 --- a/libs/hwui/RecordingCanvas.cpp +++ b/libs/hwui/RecordingCanvas.cpp @@ -912,18 +912,6 @@ void RecordingCanvas::onDrawAnnotation(const SkRect& rect, const char key[], SkD fDL->drawAnnotation(rect, key, val); } -void RecordingCanvas::onDrawText(const void* text, size_t bytes, SkScalar x, SkScalar y, - const SkPaint& paint) { - fDL->drawText(text, bytes, x, y, paint); -} -void RecordingCanvas::onDrawPosText(const void* text, size_t bytes, const SkPoint pos[], - const SkPaint& paint) { - fDL->drawPosText(text, bytes, pos, paint); -} -void RecordingCanvas::onDrawPosTextH(const void* text, size_t bytes, const SkScalar xs[], - SkScalar y, const SkPaint& paint) { - fDL->drawPosTextH(text, bytes, xs, y, paint); -} void RecordingCanvas::onDrawTextRSXform(const void* text, size_t bytes, const SkRSXform xform[], const SkRect* cull, const SkPaint& paint) { fDL->drawTextRSXform(text, bytes, xform, cull, paint); diff --git a/libs/hwui/RecordingCanvas.h b/libs/hwui/RecordingCanvas.h index 08cfc6266f56..35cf707665cb 100644 --- a/libs/hwui/RecordingCanvas.h +++ b/libs/hwui/RecordingCanvas.h @@ -170,10 +170,6 @@ public: void onDrawPicture(const SkPicture*, const SkMatrix*, const SkPaint*) override; void onDrawAnnotation(const SkRect&, const char[], SkData*) override; - void onDrawText(const void*, size_t, SkScalar x, SkScalar y, const SkPaint&) override; - void onDrawPosText(const void*, size_t, const SkPoint[], const SkPaint&) override; - void onDrawPosTextH(const void*, size_t, const SkScalar[], SkScalar, const SkPaint&) override; - void onDrawTextRSXform(const void*, size_t, const SkRSXform[], const SkRect*, const SkPaint&) override; void onDrawTextBlob(const SkTextBlob*, SkScalar, SkScalar, const SkPaint&) override; diff --git a/libs/hwui/pipeline/skia/DumpOpsCanvas.h b/libs/hwui/pipeline/skia/DumpOpsCanvas.h index 206219426bb0..2b5d58051c2c 100644 --- a/libs/hwui/pipeline/skia/DumpOpsCanvas.h +++ b/libs/hwui/pipeline/skia/DumpOpsCanvas.h @@ -82,18 +82,6 @@ protected: mOutput << mIdent << "drawDRRect" << std::endl; } - void onDrawText(const void*, size_t, SkScalar, SkScalar, const SkPaint&) override { - mOutput << mIdent << "drawText" << std::endl; - } - - void onDrawPosText(const void*, size_t, const SkPoint[], const SkPaint&) override { - mOutput << mIdent << "drawPosText" << std::endl; - } - - void onDrawPosTextH(const void*, size_t, const SkScalar[], SkScalar, const SkPaint&) override { - mOutput << mIdent << "drawPosTextH" << std::endl; - } - void onDrawTextRSXform(const void*, size_t, const SkRSXform[], const SkRect*, const SkPaint&) override { mOutput << mIdent << "drawTextRSXform" << std::endl; diff --git a/libs/hwui/tests/unit/FatalTestCanvas.h b/libs/hwui/tests/unit/FatalTestCanvas.h index 89f0c52b49ec..146662b1e913 100644 --- a/libs/hwui/tests/unit/FatalTestCanvas.h +++ b/libs/hwui/tests/unit/FatalTestCanvas.h @@ -30,18 +30,6 @@ public: void onDrawDRRect(const SkRRect&, const SkRRect&, const SkPaint&) { ADD_FAILURE() << "onDrawDRRect not expected in this test"; } - void onDrawText(const void* text, size_t byteLength, SkScalar x, SkScalar y, - const SkPaint& paint) { - ADD_FAILURE() << "onDrawText not expected in this test"; - } - void onDrawPosText(const void* text, size_t byteLength, const SkPoint pos[], - const SkPaint& paint) { - ADD_FAILURE() << "onDrawPosText not expected in this test"; - } - void onDrawPosTextH(const void* text, size_t byteLength, const SkScalar xpos[], SkScalar constY, - const SkPaint& paint) { - ADD_FAILURE() << "onDrawPosTextH not expected in this test"; - } void onDrawTextRSXform(const void* text, size_t byteLength, const SkRSXform[], const SkRect* cullRect, const SkPaint& paint) { ADD_FAILURE() << "onDrawTextRSXform not expected in this test"; |