summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Anton Philippov <philippov@google.com> 2017-03-03 12:58:16 +0000
committer Anton Philippov <philippov@google.com> 2017-03-03 21:19:36 +0000
commitfb887a69b64f79735f5c90890a8d95c782506a8a (patch)
treeb2f1022d5c366952eb751635005e980aaea5be89
parenta6d6e60e0058fa29e5f20e981f13f78ace3e3573 (diff)
Pass an empty list to PerformBackupTask constructor instead of null
Recent changes to PerformBackupTask made it expect empty list rather than null for the ArrayList<String> pendingFullBackups argument. Bug: 35420596 Test: manual Change-Id: I8e1f69e78856b9bb8fc8aa9ab1adcac634314a36
-rw-r--r--services/backup/java/com/android/server/backup/BackupManagerService.java10
1 files changed, 6 insertions, 4 deletions
diff --git a/services/backup/java/com/android/server/backup/BackupManagerService.java b/services/backup/java/com/android/server/backup/BackupManagerService.java
index 2d947a4dfca1..6021bdc310c0 100644
--- a/services/backup/java/com/android/server/backup/BackupManagerService.java
+++ b/services/backup/java/com/android/server/backup/BackupManagerService.java
@@ -856,13 +856,15 @@ public class BackupManagerService {
try {
String dirName = transport.transportDirName();
PerformBackupTask pbt = new PerformBackupTask(transport, dirName, queue,
- oldJournal, null, null, null, false, false /* nonIncremental */);
+ oldJournal, null, null, Collections.<String>emptyList(), false,
+ false /* nonIncremental */);
Message pbtMessage = obtainMessage(MSG_BACKUP_RESTORE_STEP, pbt);
sendMessage(pbtMessage);
} catch (Exception e) {
// unable to ask the transport its dir name -- transient failure, since
// the above check succeeded. Try again next time.
- Slog.e(TAG, "Transport became unavailable attempting backup");
+ Slog.e(TAG, "Transport became unavailable attempting backup"
+ + " or error initializing backup task", e);
staged = false;
}
} else {
@@ -2657,7 +2659,7 @@ public class BackupManagerService {
File mStateDir;
File mJournal;
BackupState mCurrentState;
- ArrayList<String> mPendingFullBackups;
+ List<String> mPendingFullBackups;
IBackupObserver mObserver;
IBackupManagerMonitor mMonitor;
@@ -2683,7 +2685,7 @@ public class BackupManagerService {
public PerformBackupTask(IBackupTransport transport, String dirName,
ArrayList<BackupRequest> queue, File journal, IBackupObserver observer,
- IBackupManagerMonitor monitor, ArrayList<String> pendingFullBackups,
+ IBackupManagerMonitor monitor, List<String> pendingFullBackups,
boolean userInitiated, boolean nonIncremental) {
mTransport = transport;
mOriginalQueue = queue;