summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Chet Haase <chet@google.com> 2016-01-12 00:51:36 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2016-01-12 00:51:36 +0000
commitfadc86666f25e3d773be01c746bfae17a860cd6a (patch)
tree4a7db22d272ee6adac32ad8204b93211c3e15f48
parent12705131b95d5d6bcfae79d7991ff3e6f02457e4 (diff)
parent406a02b59d3a8f9890509200f048c23c3b3200b7 (diff)
Merge "Don't double-set keyframe values when Property exists"
-rw-r--r--core/java/android/animation/PropertyValuesHolder.java27
1 files changed, 14 insertions, 13 deletions
diff --git a/core/java/android/animation/PropertyValuesHolder.java b/core/java/android/animation/PropertyValuesHolder.java
index 8928e99cecd2..e993cca9e325 100644
--- a/core/java/android/animation/PropertyValuesHolder.java
+++ b/core/java/android/animation/PropertyValuesHolder.java
@@ -861,22 +861,23 @@ public class PropertyValuesHolder implements Cloneable {
if (mProperty != null) {
Object value = convertBack(mProperty.get(target));
kf.setValue(value);
- }
- try {
- if (mGetter == null) {
- Class targetClass = target.getClass();
- setupGetter(targetClass);
+ } else {
+ try {
if (mGetter == null) {
- // Already logged the error - just return to avoid NPE
- return;
+ Class targetClass = target.getClass();
+ setupGetter(targetClass);
+ if (mGetter == null) {
+ // Already logged the error - just return to avoid NPE
+ return;
+ }
}
+ Object value = convertBack(mGetter.invoke(target));
+ kf.setValue(value);
+ } catch (InvocationTargetException e) {
+ Log.e("PropertyValuesHolder", e.toString());
+ } catch (IllegalAccessException e) {
+ Log.e("PropertyValuesHolder", e.toString());
}
- Object value = convertBack(mGetter.invoke(target));
- kf.setValue(value);
- } catch (InvocationTargetException e) {
- Log.e("PropertyValuesHolder", e.toString());
- } catch (IllegalAccessException e) {
- Log.e("PropertyValuesHolder", e.toString());
}
}