summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Nolan Scobie <nscobie@google.com> 2022-11-09 15:23:07 -0500
committer Nolan Scobie <nscobie@google.com> 2022-11-10 17:38:02 -0500
commitf89a38ac32c18dbdaa2256ab2653eb3b39d51aff (patch)
treec00e87e3813a4af50c11feddeadc2966333fbee2
parent998b6d7ed50aed06cab79811ea8fd76dd7442536 (diff)
Change hwui_unit_tests (and benchmarks) to push to non-root writable dir
...and switch to more appropriate "general-tests" suite type. This allows the test suite to be run in certain lab/infra scenarios, like on ABTD. Docs device-tests to general-tests: https://source.android.com/docs/core/tests/development/test-mapping#packaging_build_script_rules Tests Without this change: https://android-build.googleplex.com/builds/abtd/run/L10000000957295240 (tooling fails to push content) With this change: https://android-build.googleplex.com/builds/abtd/run/L52900000957292742 (gets past tooling failure, and fails on an actually failing unit test) Test: compare ABTD runs with and without this CL Bug: 257123741 Change-Id: I33696a0f1c9279622138e4dc4c49d73c99f359eb
-rw-r--r--libs/hwui/Android.bp2
-rw-r--r--libs/hwui/AndroidTest.xml12
2 files changed, 7 insertions, 7 deletions
diff --git a/libs/hwui/Android.bp b/libs/hwui/Android.bp
index 29f37737d433..7b7677ff297d 100644
--- a/libs/hwui/Android.bp
+++ b/libs/hwui/Android.bp
@@ -636,7 +636,7 @@ cc_library_static {
cc_defaults {
name: "hwui_test_defaults",
defaults: ["hwui_defaults"],
- test_suites: ["device-tests"],
+ test_suites: ["general-tests"],
header_libs: ["libandroid_headers_private"],
target: {
android: {
diff --git a/libs/hwui/AndroidTest.xml b/libs/hwui/AndroidTest.xml
index 381fb9f6c7bf..911315f81a8a 100644
--- a/libs/hwui/AndroidTest.xml
+++ b/libs/hwui/AndroidTest.xml
@@ -16,22 +16,22 @@
<configuration description="Config for hwuimicro">
<target_preparer class="com.android.tradefed.targetprep.PushFilePreparer">
<option name="cleanup" value="true" />
- <option name="push" value="hwui_unit_tests->/data/nativetest/hwui_unit_tests" />
- <option name="push" value="hwuimicro->/data/benchmarktest/hwuimicro" />
- <option name="push" value="hwuimacro->/data/benchmarktest/hwuimacro" />
+ <option name="push" value="hwui_unit_tests->/data/local/tmp/nativetest/hwui_unit_tests" />
+ <option name="push" value="hwuimicro->/data/local/tmp/benchmarktest/hwuimicro" />
+ <option name="push" value="hwuimacro->/data/local/tmp/benchmarktest/hwuimacro" />
</target_preparer>
<option name="test-suite-tag" value="apct" />
<test class="com.android.tradefed.testtype.GTest" >
- <option name="native-test-device-path" value="/data/nativetest" />
+ <option name="native-test-device-path" value="/data/local/tmp/nativetest" />
<option name="module-name" value="hwui_unit_tests" />
</test>
<test class="com.android.tradefed.testtype.GoogleBenchmarkTest" >
- <option name="native-benchmark-device-path" value="/data/benchmarktest" />
+ <option name="native-benchmark-device-path" value="/data/local/tmp/benchmarktest" />
<option name="benchmark-module-name" value="hwuimicro" />
<option name="file-exclusion-filter-regex" value=".*\.config$" />
</test>
<test class="com.android.tradefed.testtype.GoogleBenchmarkTest" >
- <option name="native-benchmark-device-path" value="/data/benchmarktest" />
+ <option name="native-benchmark-device-path" value="/data/local/tmp/benchmarktest" />
<option name="benchmark-module-name" value="hwuimacro" />
<option name="file-exclusion-filter-regex" value=".*\.config$" />
</test>