diff options
| author | 2014-09-19 12:46:19 -0400 | |
|---|---|---|
| committer | 2014-09-19 18:34:32 +0000 | |
| commit | f6b46cb8b108cc8feee8ae68b979271fd6f72bf5 (patch) | |
| tree | 5eadade83c5c89aa83fd309c3479cce04df5d9ee | |
| parent | b6812b64c42ee15a1afa295fe341103fe02006ae (diff) | |
Fix crash in PacManager
The PacManager would clear the pac url by setting it to null, however
everywhere else, pac url is cleared to Uri.EMPTY. This sometimes leads
to an NPE when PAC is set and cleared rapidly and take down the whole
framework.
Bug: 17581527
Change-Id: I84ce215f4f6a8a7e804372fc0a1e20ac609a21f1
| -rw-r--r-- | services/core/java/com/android/server/connectivity/PacManager.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/services/core/java/com/android/server/connectivity/PacManager.java b/services/core/java/com/android/server/connectivity/PacManager.java index 63178eb0e06b..07fe7ba79582 100644 --- a/services/core/java/com/android/server/connectivity/PacManager.java +++ b/services/core/java/com/android/server/connectivity/PacManager.java @@ -71,7 +71,7 @@ public class PacManager { public static final String KEY_PROXY = "keyProxy"; private String mCurrentPac; @GuardedBy("mProxyLock") - private Uri mPacUrl; + private Uri mPacUrl = Uri.EMPTY; private AlarmManager mAlarmManager; @GuardedBy("mProxyLock") @@ -175,7 +175,7 @@ public class PacManager { } else { getAlarmManager().cancel(mPacRefreshIntent); synchronized (mProxyLock) { - mPacUrl = null; + mPacUrl = Uri.EMPTY; mCurrentPac = null; if (mProxyService != null) { try { |