diff options
author | 2023-02-10 14:49:26 -0800 | |
---|---|---|
committer | 2023-02-13 09:36:23 -0800 | |
commit | f67b9567ac286f2aeeab27b778b18128a609691a (patch) | |
tree | 8856c41600aebf9a2ca5682fd80bde8f567f3e6e | |
parent | 96c2a6b2cf78dac27a354191cc4e0cff05f8d7e2 (diff) |
Rename PackageState APIs from feedback
Documents tags for PackageState#getSharedLibraryDependencies,
adjusts "Res" suffixes to "ResourceId", and fixes boolean methods
to be more grammatically correct.
API-Coverage-Bug: 262593427
Bug: 268258907
Test: AndroidPackageTest
Change-Id: I929ce45b1e7fce6c1af8c2994f57045528958ec1
21 files changed, 276 insertions, 264 deletions
diff --git a/core/java/android/content/pm/ApplicationInfo.java b/core/java/android/content/pm/ApplicationInfo.java index 94c5e25b25f9..72cac6575aa3 100644 --- a/core/java/android/content/pm/ApplicationInfo.java +++ b/core/java/android/content/pm/ApplicationInfo.java @@ -679,8 +679,9 @@ public class ApplicationInfo extends PackageItemInfo implements Parcelable { public static final int PRIVATE_FLAG_PROFILEABLE_BY_SHELL = 1 << 23; /** - * Indicates whether this package requires access to non-SDK APIs. - * Only system apps and tests are allowed to use this property. + * Indicates whether this application has declared its user data as fragile, + * causing the system to prompt the user on whether to keep the user data + * on uninstall. * @hide */ public static final int PRIVATE_FLAG_HAS_FRAGILE_USER_DATA = 1 << 24; diff --git a/services/api/current.txt b/services/api/current.txt index f7d6ee96f162..e34ef1338be7 100644 --- a/services/api/current.txt +++ b/services/api/current.txt @@ -85,69 +85,72 @@ package com.android.server.pm.pkg { method @Nullable public String getAppComponentFactory(); method @Nullable public String getApplicationClassName(); method @Nullable public String getBackupAgentName(); - method @DrawableRes public int getBannerRes(); + method @DrawableRes public int getBannerResourceId(); method public int getBaseRevisionCode(); method public int getCategory(); method @Nullable public String getClassLoaderName(); method @Dimension(unit=android.annotation.Dimension.DP) public int getCompatibleWidthLimitDp(); - method @XmlRes public int getDataExtractionRulesRes(); - method @StringRes public int getDescriptionRes(); - method @XmlRes public int getFullBackupContentRes(); + method @XmlRes public int getDataExtractionRulesResourceId(); + method @StringRes public int getDescriptionResourceId(); + method @XmlRes public int getFullBackupContentResourceId(); method public int getGwpAsanMode(); - method @DrawableRes public int getIconRes(); - method @StringRes public int getLabelRes(); + method @DrawableRes public int getIconResourceId(); + method @StringRes public int getLabelResourceId(); method @Dimension(unit=android.annotation.Dimension.DP) public int getLargestWidthLimitDp(); method @NonNull public java.util.List<java.lang.String> getLibraryNames(); - method @XmlRes public int getLocaleConfigRes(); - method @DrawableRes public int getLogoRes(); + method @XmlRes public int getLocaleConfigResourceId(); + method @DrawableRes public int getLogoResourceId(); method public long getLongVersionCode(); method public float getMaxAspectRatio(); method public float getMinAspectRatio(); method public int getNativeHeapZeroInitialized(); - method @XmlRes public int getNetworkSecurityConfigRes(); + method @XmlRes public int getNetworkSecurityConfigResourceId(); method @Nullable public String getRequiredAccountType(); method @Dimension(unit=android.annotation.Dimension.DP) public int getRequiresSmallestWidthDp(); method @Nullable public String getRestrictedAccountType(); - method @DrawableRes public int getRoundIconRes(); + method @DrawableRes public int getRoundIconResourceId(); method @Nullable public String getSdkLibraryName(); method @Nullable public String getSharedUserId(); - method @StringRes public int getSharedUserLabelRes(); + method @StringRes public int getSharedUserLabelResourceId(); method @NonNull public java.util.List<com.android.server.pm.pkg.AndroidPackageSplit> getSplits(); method @Nullable public String getStaticSharedLibraryName(); method @NonNull public java.util.UUID getStorageUuid(); method public int getTargetSdkVersion(); - method @StyleRes public int getThemeRes(); + method @StyleRes public int getThemeResourceId(); method public int getUiOptions(); method @Nullable public String getVersionName(); method @Nullable public String getZygotePreloadName(); + method public boolean is32BitAbiPreferred(); method public boolean isAllowAudioPlaybackCapture(); - method public boolean isAllowBackup(); - method public boolean isAllowClearUserData(); - method public boolean isAllowClearUserDataOnFailedRestore(); method public boolean isAllowNativeHeapPointerTagging(); - method public boolean isAllowTaskReparenting(); method public boolean isAnyDensity(); method public boolean isAttributionsUserVisible(); + method public boolean isBackupAllowed(); method public boolean isBackupInForeground(); - method public boolean isCantSaveState(); + method public boolean isClearUserDataAllowed(); + method public boolean isClearUserDataOnFailedRestoreAllowed(); + method public boolean isCleartextTrafficAllowed(); method public boolean isCoreApp(); method public boolean isCrossProfile(); method public boolean isDebuggable(); + method public boolean isDeclaredHavingCode(); method public boolean isDefaultToDeviceProtectedStorage(); method public boolean isDirectBootAware(); - method public boolean isExtractNativeLibs(); + method public boolean isExtraLargeScreensSupported(); + method public boolean isExtractNativeLibrariesRequested(); method public boolean isFactoryTest(); method public boolean isForceQueryable(); method public boolean isFullBackupOnly(); method public boolean isHardwareAccelerated(); - method public boolean isHasCode(); - method public boolean isHasFragileUserData(); method public boolean isIsolatedSplitLoading(); - method public boolean isKillAfterRestore(); + method public boolean isKillAfterRestoreAllowed(); method public boolean isLargeHeap(); + method public boolean isLargeScreensSupported(); method public boolean isLeavingSharedUser(); method public boolean isMultiArch(); method public boolean isNativeLibraryRootRequiresIsa(); + method public boolean isNonSdkApiRequested(); + method public boolean isNormalScreensSupported(); method public boolean isOnBackInvokedCallbackEnabled(); method public boolean isPersistent(); method public boolean isProfileable(); @@ -157,17 +160,14 @@ package com.android.server.pm.pkg { method public boolean isResetEnabledSettingsOnAppDataCleared(); method public boolean isResourceOverlay(); method public boolean isRestoreAnyVersion(); + method public boolean isRtlSupported(); + method public boolean isSaveStateDisallowed(); method public boolean isSignedWithPlatformKey(); - method public boolean isSupportsExtraLargeScreens(); - method public boolean isSupportsLargeScreens(); - method public boolean isSupportsNormalScreens(); - method public boolean isSupportsRtl(); - method public boolean isSupportsSmallScreens(); + method public boolean isSmallScreensSupported(); + method public boolean isTaskReparentingAllowed(); method public boolean isTestOnly(); - method public boolean isUse32BitAbi(); method public boolean isUseEmbeddedDex(); - method public boolean isUsesCleartextTraffic(); - method public boolean isUsesNonSdkApi(); + method public boolean isUserDataFragile(); method public boolean isVmSafeMode(); } diff --git a/services/core/java/com/android/server/pm/PackageAbiHelperImpl.java b/services/core/java/com/android/server/pm/PackageAbiHelperImpl.java index e25430099301..85d2df320fc9 100644 --- a/services/core/java/com/android/server/pm/PackageAbiHelperImpl.java +++ b/services/core/java/com/android/server/pm/PackageAbiHelperImpl.java @@ -388,7 +388,7 @@ final class PackageAbiHelperImpl implements PackageAbiHelper { if (abi32 >= 0) { final String abi = Build.SUPPORTED_32_BIT_ABIS[abi32]; if (abi64 >= 0) { - if (pkg.isUse32BitAbi()) { + if (pkg.is32BitAbiPreferred()) { secondaryCpuAbi = primaryCpuAbi; primaryCpuAbi = abi; } else { @@ -474,7 +474,8 @@ final class PackageAbiHelperImpl implements PackageAbiHelper { private boolean shouldExtractLibs(AndroidPackage pkg, boolean isSystemApp, boolean isUpdatedSystemApp) { // We shouldn't extract libs if the package is a library or if extractNativeLibs=false - boolean extractLibs = !AndroidPackageUtils.isLibrary(pkg) && pkg.isExtractNativeLibs(); + boolean extractLibs = !AndroidPackageUtils.isLibrary(pkg) + && pkg.isExtractNativeLibrariesRequested(); // We shouldn't attempt to extract libs from system app when it was not updated. if (isSystemApp && !isUpdatedSystemApp) { extractLibs = false; diff --git a/services/core/java/com/android/server/pm/PackageDexOptimizer.java b/services/core/java/com/android/server/pm/PackageDexOptimizer.java index f708fbb81dba..f33813759e4f 100644 --- a/services/core/java/com/android/server/pm/PackageDexOptimizer.java +++ b/services/core/java/com/android/server/pm/PackageDexOptimizer.java @@ -189,7 +189,7 @@ public class PackageDexOptimizer { } // We do not dexopt a package with no code. - if (!pkg.isHasCode()) { + if (!pkg.isDeclaredHavingCode()) { return false; } @@ -287,7 +287,7 @@ public class PackageDexOptimizer { // For each code path in the package, this array contains the class loader context that // needs to be passed to dexopt in order to ensure correct optimizations. boolean[] pathsWithCode = new boolean[paths.size()]; - pathsWithCode[0] = pkg.isHasCode(); + pathsWithCode[0] = pkg.isDeclaredHavingCode(); for (int i = 1; i < paths.size(); i++) { pathsWithCode[i] = (pkg.getSplitFlags()[i - 1] & ApplicationInfo.FLAG_HAS_CODE) != 0; } diff --git a/services/core/java/com/android/server/pm/ScanPackageUtils.java b/services/core/java/com/android/server/pm/ScanPackageUtils.java index 830b096c696d..b09c2ddce638 100644 --- a/services/core/java/com/android/server/pm/ScanPackageUtils.java +++ b/services/core/java/com/android/server/pm/ScanPackageUtils.java @@ -545,7 +545,7 @@ final class ScanPackageUtils { */ public static void assertCodePolicy(AndroidPackage pkg) throws PackageManagerException { - final boolean shouldHaveCode = pkg.isHasCode(); + final boolean shouldHaveCode = pkg.isDeclaredHavingCode(); if (shouldHaveCode && !apkHasCode(pkg.getBaseApkPath())) { throw new PackageManagerException(INSTALL_FAILED_INVALID_APK, "Package " + pkg.getBaseApkPath() + " code is missing"); diff --git a/services/core/java/com/android/server/pm/Settings.java b/services/core/java/com/android/server/pm/Settings.java index 165e476b1de7..a8f6de30d485 100644 --- a/services/core/java/com/android/server/pm/Settings.java +++ b/services/core/java/com/android/server/pm/Settings.java @@ -4848,7 +4848,7 @@ public final class Settings implements Watchable, Snappable { pw.println(); if (pkg != null) { pw.print(prefix); pw.print(" versionName="); pw.println(pkg.getVersionName()); - pw.print(prefix); pw.print(" usesNonSdkApi="); pw.println(pkg.isUsesNonSdkApi()); + pw.print(prefix); pw.print(" usesNonSdkApi="); pw.println(pkg.isNonSdkApiRequested()); pw.print(prefix); pw.print(" splits="); dumpSplitNames(pw, pkg); pw.println(); final int apkSigningVersion = pkg.getSigningDetails().getSignatureSchemeVersion(); pw.print(prefix); pw.print(" apkSigningVersion="); pw.println(apkSigningVersion); @@ -4881,25 +4881,25 @@ public final class Settings implements Watchable, Snappable { pw.print(prefix); pw.print(" dataDir="); pw.println(dataDir.getAbsolutePath()); pw.print(prefix); pw.print(" supportsScreens=["); boolean first = true; - if (pkg.isSupportsSmallScreens()) { + if (pkg.isSmallScreensSupported()) { if (!first) pw.print(", "); first = false; pw.print("small"); } - if (pkg.isSupportsNormalScreens()) { + if (pkg.isNormalScreensSupported()) { if (!first) pw.print(", "); first = false; pw.print("medium"); } - if (pkg.isSupportsLargeScreens()) { + if (pkg.isLargeScreensSupported()) { if (!first) pw.print(", "); first = false; pw.print("large"); } - if (pkg.isSupportsExtraLargeScreens()) { + if (pkg.isExtraLargeScreensSupported()) { if (!first) pw.print(", "); first = false; diff --git a/services/core/java/com/android/server/pm/dex/ArtManagerService.java b/services/core/java/com/android/server/pm/dex/ArtManagerService.java index d8b6cd5bb7e3..d88b66b412e7 100644 --- a/services/core/java/com/android/server/pm/dex/ArtManagerService.java +++ b/services/core/java/com/android/server/pm/dex/ArtManagerService.java @@ -580,7 +580,7 @@ public class ArtManagerService extends android.content.pm.dex.IArtManager.Stub { */ private ArrayMap<String, String> getPackageProfileNames(AndroidPackage pkg) { ArrayMap<String, String> result = new ArrayMap<>(); - if (pkg.isHasCode()) { + if (pkg.isDeclaredHavingCode()) { result.put(pkg.getBaseApkPath(), ArtManager.getProfileName(null)); } diff --git a/services/core/java/com/android/server/pm/parsing/PackageInfoUtils.java b/services/core/java/com/android/server/pm/parsing/PackageInfoUtils.java index 59256d34a018..1af82a8aa212 100644 --- a/services/core/java/com/android/server/pm/parsing/PackageInfoUtils.java +++ b/services/core/java/com/android/server/pm/parsing/PackageInfoUtils.java @@ -133,7 +133,7 @@ public class PackageInfoUtils { info.splitRevisionCodes = pkg.getSplitRevisionCodes(); info.versionName = pkg.getVersionName(); info.sharedUserId = pkg.getSharedUserId(); - info.sharedUserLabel = pkg.getSharedUserLabelRes(); + info.sharedUserLabel = pkg.getSharedUserLabelResourceId(); info.applicationInfo = applicationInfo; info.installLocation = pkg.getInstallLocation(); if ((info.applicationInfo.flags & ApplicationInfo.FLAG_SYSTEM) != 0 @@ -876,27 +876,27 @@ public class PackageInfoUtils { // @formatter:off int pkgWithoutStateFlags = flag(pkg.isExternalStorage(), ApplicationInfo.FLAG_EXTERNAL_STORAGE) | flag(pkg.isHardwareAccelerated(), ApplicationInfo.FLAG_HARDWARE_ACCELERATED) - | flag(pkg.isAllowBackup(), ApplicationInfo.FLAG_ALLOW_BACKUP) - | flag(pkg.isKillAfterRestore(), ApplicationInfo.FLAG_KILL_AFTER_RESTORE) + | flag(pkg.isBackupAllowed(), ApplicationInfo.FLAG_ALLOW_BACKUP) + | flag(pkg.isKillAfterRestoreAllowed(), ApplicationInfo.FLAG_KILL_AFTER_RESTORE) | flag(pkg.isRestoreAnyVersion(), ApplicationInfo.FLAG_RESTORE_ANY_VERSION) | flag(pkg.isFullBackupOnly(), ApplicationInfo.FLAG_FULL_BACKUP_ONLY) | flag(pkg.isPersistent(), ApplicationInfo.FLAG_PERSISTENT) | flag(pkg.isDebuggable(), ApplicationInfo.FLAG_DEBUGGABLE) | flag(pkg.isVmSafeMode(), ApplicationInfo.FLAG_VM_SAFE_MODE) - | flag(pkg.isHasCode(), ApplicationInfo.FLAG_HAS_CODE) - | flag(pkg.isAllowTaskReparenting(), ApplicationInfo.FLAG_ALLOW_TASK_REPARENTING) - | flag(pkg.isAllowClearUserData(), ApplicationInfo.FLAG_ALLOW_CLEAR_USER_DATA) + | flag(pkg.isDeclaredHavingCode(), ApplicationInfo.FLAG_HAS_CODE) + | flag(pkg.isTaskReparentingAllowed(), ApplicationInfo.FLAG_ALLOW_TASK_REPARENTING) + | flag(pkg.isClearUserDataAllowed(), ApplicationInfo.FLAG_ALLOW_CLEAR_USER_DATA) | flag(pkg.isLargeHeap(), ApplicationInfo.FLAG_LARGE_HEAP) - | flag(pkg.isUsesCleartextTraffic(), ApplicationInfo.FLAG_USES_CLEARTEXT_TRAFFIC) - | flag(pkg.isSupportsRtl(), ApplicationInfo.FLAG_SUPPORTS_RTL) + | flag(pkg.isCleartextTrafficAllowed(), ApplicationInfo.FLAG_USES_CLEARTEXT_TRAFFIC) + | flag(pkg.isRtlSupported(), ApplicationInfo.FLAG_SUPPORTS_RTL) | flag(pkg.isTestOnly(), ApplicationInfo.FLAG_TEST_ONLY) | flag(pkg.isMultiArch(), ApplicationInfo.FLAG_MULTIARCH) - | flag(pkg.isExtractNativeLibs(), ApplicationInfo.FLAG_EXTRACT_NATIVE_LIBS) + | flag(pkg.isExtractNativeLibrariesRequested(), ApplicationInfo.FLAG_EXTRACT_NATIVE_LIBS) | flag(pkg.isGame(), ApplicationInfo.FLAG_IS_GAME) - | flag(pkg.isSupportsSmallScreens(), ApplicationInfo.FLAG_SUPPORTS_SMALL_SCREENS) - | flag(pkg.isSupportsNormalScreens(), ApplicationInfo.FLAG_SUPPORTS_NORMAL_SCREENS) - | flag(pkg.isSupportsLargeScreens(), ApplicationInfo.FLAG_SUPPORTS_LARGE_SCREENS) - | flag(pkg.isSupportsExtraLargeScreens(), ApplicationInfo.FLAG_SUPPORTS_XLARGE_SCREENS) + | flag(pkg.isSmallScreensSupported(), ApplicationInfo.FLAG_SUPPORTS_SMALL_SCREENS) + | flag(pkg.isNormalScreensSupported(), ApplicationInfo.FLAG_SUPPORTS_NORMAL_SCREENS) + | flag(pkg.isLargeScreensSupported(), ApplicationInfo.FLAG_SUPPORTS_LARGE_SCREENS) + | flag(pkg.isExtraLargeScreensSupported(), ApplicationInfo.FLAG_SUPPORTS_XLARGE_SCREENS) | flag(pkg.isResizeable(), ApplicationInfo.FLAG_RESIZEABLE_FOR_SCREENS) | flag(pkg.isAnyDensity(), ApplicationInfo.FLAG_SUPPORTS_SCREEN_DENSITIES) | flag(AndroidPackageUtils.isSystem(pkg), ApplicationInfo.FLAG_SYSTEM) @@ -932,12 +932,12 @@ public class PackageInfoUtils { | flag(pkg.isDefaultToDeviceProtectedStorage(), ApplicationInfo.PRIVATE_FLAG_DEFAULT_TO_DEVICE_PROTECTED_STORAGE) | flag(pkg.isDirectBootAware(), ApplicationInfo.PRIVATE_FLAG_DIRECT_BOOT_AWARE) | flag(pkg.isPartiallyDirectBootAware(), ApplicationInfo.PRIVATE_FLAG_PARTIALLY_DIRECT_BOOT_AWARE) - | flag(pkg.isAllowClearUserDataOnFailedRestore(), ApplicationInfo.PRIVATE_FLAG_ALLOW_CLEAR_USER_DATA_ON_FAILED_RESTORE) + | flag(pkg.isClearUserDataOnFailedRestoreAllowed(), ApplicationInfo.PRIVATE_FLAG_ALLOW_CLEAR_USER_DATA_ON_FAILED_RESTORE) | flag(pkg.isAllowAudioPlaybackCapture(), ApplicationInfo.PRIVATE_FLAG_ALLOW_AUDIO_PLAYBACK_CAPTURE) | flag(pkg.isRequestLegacyExternalStorage(), ApplicationInfo.PRIVATE_FLAG_REQUEST_LEGACY_EXTERNAL_STORAGE) - | flag(pkg.isUsesNonSdkApi(), ApplicationInfo.PRIVATE_FLAG_USES_NON_SDK_API) - | flag(pkg.isHasFragileUserData(), ApplicationInfo.PRIVATE_FLAG_HAS_FRAGILE_USER_DATA) - | flag(pkg.isCantSaveState(), ApplicationInfo.PRIVATE_FLAG_CANT_SAVE_STATE) + | flag(pkg.isNonSdkApiRequested(), ApplicationInfo.PRIVATE_FLAG_USES_NON_SDK_API) + | flag(pkg.isUserDataFragile(), ApplicationInfo.PRIVATE_FLAG_HAS_FRAGILE_USER_DATA) + | flag(pkg.isSaveStateDisallowed(), ApplicationInfo.PRIVATE_FLAG_CANT_SAVE_STATE) | flag(pkg.isResizeableActivityViaSdkVersion(), ApplicationInfo.PRIVATE_FLAG_ACTIVITIES_RESIZE_MODE_RESIZEABLE_VIA_SDK_VERSION) | flag(pkg.isAllowNativeHeapPointerTagging(), ApplicationInfo.PRIVATE_FLAG_ALLOW_NATIVE_HEAP_POINTER_TAGGING) | flag(AndroidPackageUtils.isSystemExt(pkg), ApplicationInfo.PRIVATE_FLAG_SYSTEM_EXT) diff --git a/services/core/java/com/android/server/pm/parsing/pkg/AndroidPackageUtils.java b/services/core/java/com/android/server/pm/parsing/pkg/AndroidPackageUtils.java index f3ee53178b60..e2acc17e94c4 100644 --- a/services/core/java/com/android/server/pm/parsing/pkg/AndroidPackageUtils.java +++ b/services/core/java/com/android/server/pm/parsing/pkg/AndroidPackageUtils.java @@ -59,7 +59,7 @@ public class AndroidPackageUtils { AndroidPackage aPkg) { PackageImpl pkg = (PackageImpl) aPkg; ArrayList<String> paths = new ArrayList<>(); - if (pkg.isHasCode()) { + if (pkg.isDeclaredHavingCode()) { paths.add(pkg.getBaseApkPath()); } String[] splitCodePaths = pkg.getSplitCodePaths(); @@ -156,7 +156,7 @@ public class AndroidPackageUtils { return NativeLibraryHelper.Handle.create( AndroidPackageUtils.getAllCodePaths(pkg), pkg.isMultiArch(), - pkg.isExtractNativeLibs(), + pkg.isExtractNativeLibrariesRequested(), pkg.isDebuggable() ); } @@ -243,7 +243,7 @@ public class AndroidPackageUtils { } else if (pkg.isSignedWithPlatformKey()) { isAllowedToUseHiddenApis = true; } else if (packageState.isSystem()) { - isAllowedToUseHiddenApis = pkg.isUsesNonSdkApi() + isAllowedToUseHiddenApis = pkg.isNonSdkApiRequested() || SystemConfig.getInstance().getHiddenApiWhitelistedApps().contains( pkg.getPackageName()); } else { diff --git a/services/core/java/com/android/server/pm/parsing/pkg/PackageImpl.java b/services/core/java/com/android/server/pm/parsing/pkg/PackageImpl.java index d7c4a09d045c..de31b4699918 100644 --- a/services/core/java/com/android/server/pm/parsing/pkg/PackageImpl.java +++ b/services/core/java/com/android/server/pm/parsing/pkg/PackageImpl.java @@ -793,7 +793,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, null, getBaseApkPath(), getBaseRevisionCode(), - isHasCode() ? ApplicationInfo.FLAG_HAS_CODE : 0, + isDeclaredHavingCode() ? ApplicationInfo.FLAG_HAS_CODE : 0, getClassLoaderName() )); @@ -879,7 +879,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getBannerRes() { + public int getBannerResourceId() { return banner; } @@ -934,12 +934,12 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getDataExtractionRulesRes() { + public int getDataExtractionRulesResourceId() { return dataExtractionRules; } @Override - public int getDescriptionRes() { + public int getDescriptionResourceId() { return descriptionRes; } @@ -950,7 +950,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getFullBackupContentRes() { + public int getFullBackupContentResourceId() { return fullBackupContent; } @@ -961,7 +961,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getIconRes() { + public int getIconResourceId() { return iconRes; } @@ -995,7 +995,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getLabelRes() { + public int getLabelResourceId() { return labelRes; } @@ -1011,12 +1011,12 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getLocaleConfigRes() { + public int getLocaleConfigResourceId() { return mLocaleConfigRes; } @Override - public int getLogoRes() { + public int getLogoResourceId() { return logo; } @@ -1077,7 +1077,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getNetworkSecurityConfigRes() { + public int getNetworkSecurityConfigResourceId() { return networkSecurityConfigRes; } @@ -1259,7 +1259,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getRoundIconRes() { + public int getRoundIconResourceId() { return roundIconRes; } @@ -1287,7 +1287,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getSharedUserLabelRes() { + public int getSharedUserLabelResourceId() { return sharedUserLabel; } @@ -1366,7 +1366,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public int getThemeRes() { + public int getThemeResourceId() { return theme; } @@ -1531,17 +1531,17 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public boolean isAllowBackup() { + public boolean isBackupAllowed() { return getBoolean(Booleans.ALLOW_BACKUP); } @Override - public boolean isAllowClearUserData() { + public boolean isClearUserDataAllowed() { return getBoolean(Booleans.ALLOW_CLEAR_USER_DATA); } @Override - public boolean isAllowClearUserDataOnFailedRestore() { + public boolean isClearUserDataOnFailedRestoreAllowed() { return getBoolean(Booleans.ALLOW_CLEAR_USER_DATA_ON_FAILED_RESTORE); } @@ -1551,7 +1551,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public boolean isAllowTaskReparenting() { + public boolean isTaskReparentingAllowed() { return getBoolean(Booleans.ALLOW_TASK_REPARENTING); } @@ -1574,7 +1574,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public boolean isCantSaveState() { + public boolean isSaveStateDisallowed() { return getBoolean(Booleans.CANT_SAVE_STATE); } @@ -1609,7 +1609,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public boolean isExtractNativeLibs() { + public boolean isExtractNativeLibrariesRequested() { return getBoolean(Booleans.EXTRACT_NATIVE_LIBS); } @@ -1629,7 +1629,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public boolean isHasCode() { + public boolean isDeclaredHavingCode() { return getBoolean(Booleans.HAS_CODE); } @@ -1639,7 +1639,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public boolean isHasFragileUserData() { + public boolean isUserDataFragile() { return getBoolean(Booleans.HAS_FRAGILE_USER_DATA); } @@ -1649,7 +1649,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public boolean isKillAfterRestore() { + public boolean isKillAfterRestoreAllowed() { return getBoolean(Booleans.KILL_AFTER_RESTORE); } @@ -1746,7 +1746,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, return getBoolean(Booleans.STATIC_SHARED_LIBRARY); } - public boolean isSupportsExtraLargeScreens() { + public boolean isExtraLargeScreensSupported() { if (supportsExtraLargeScreens == null) { return targetSdkVersion >= Build.VERSION_CODES.GINGERBREAD; } @@ -1754,7 +1754,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, return supportsExtraLargeScreens; } - public boolean isSupportsLargeScreens() { + public boolean isLargeScreensSupported() { if (supportsLargeScreens == null) { return targetSdkVersion >= Build.VERSION_CODES.DONUT; } @@ -1762,16 +1762,16 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, return supportsLargeScreens; } - public boolean isSupportsNormalScreens() { + public boolean isNormalScreensSupported() { return supportsNormalScreens == null || supportsNormalScreens; } @Override - public boolean isSupportsRtl() { + public boolean isRtlSupported() { return getBoolean(Booleans.SUPPORTS_RTL); } - public boolean isSupportsSmallScreens() { + public boolean isSmallScreensSupported() { if (supportsSmallScreens == null) { return targetSdkVersion >= Build.VERSION_CODES.DONUT; } @@ -1785,7 +1785,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public boolean isUse32BitAbi() { + public boolean is32BitAbiPreferred() { return getBoolean(Booleans.USE_32_BIT_ABI); } @@ -1795,12 +1795,12 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public boolean isUsesCleartextTraffic() { + public boolean isCleartextTrafficAllowed() { return getBoolean(Booleans.USES_CLEARTEXT_TRAFFIC); } @Override - public boolean isUsesNonSdkApi() { + public boolean isNonSdkApiRequested() { return getBoolean(Booleans.USES_NON_SDK_API); } @@ -1831,17 +1831,17 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setAllowBackup(boolean value) { + public PackageImpl setBackupAllowed(boolean value) { return setBoolean(Booleans.ALLOW_BACKUP, value); } @Override - public PackageImpl setAllowClearUserData(boolean value) { + public PackageImpl setClearUserDataAllowed(boolean value) { return setBoolean(Booleans.ALLOW_CLEAR_USER_DATA, value); } @Override - public PackageImpl setAllowClearUserDataOnFailedRestore(boolean value) { + public PackageImpl setClearUserDataOnFailedRestoreAllowed(boolean value) { return setBoolean(Booleans.ALLOW_CLEAR_USER_DATA_ON_FAILED_RESTORE, value); } @@ -1851,7 +1851,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setAllowTaskReparenting(boolean value) { + public PackageImpl setTaskReparentingAllowed(boolean value) { return setBoolean(Booleans.ALLOW_TASK_REPARENTING, value); } @@ -1895,7 +1895,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setBannerRes(int value) { + public PackageImpl setBannerResourceId(int value) { banner = value; return this; } @@ -1912,7 +1912,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setCantSaveState(boolean value) { + public PackageImpl setSaveStateDisallowed(boolean value) { return setBoolean(Booleans.CANT_SAVE_STATE, value); } @@ -1958,7 +1958,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setDataExtractionRulesRes(int value) { + public PackageImpl setDataExtractionRulesResourceId(int value) { dataExtractionRules = value; return this; } @@ -1969,7 +1969,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setDescriptionRes(int value) { + public PackageImpl setDescriptionResourceId(int value) { descriptionRes = value; return this; } @@ -1985,7 +1985,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setExtractNativeLibs(boolean value) { + public PackageImpl setExtractNativeLibrariesRequested(boolean value) { return setBoolean(Booleans.EXTRACT_NATIVE_LIBS, value); } @@ -1995,7 +1995,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setFullBackupContentRes(int value) { + public PackageImpl setFullBackupContentResourceId(int value) { fullBackupContent = value; return this; } @@ -2017,7 +2017,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setHasCode(boolean value) { + public PackageImpl setDeclaredHavingCode(boolean value) { return setBoolean(Booleans.HAS_CODE, value); } @@ -2027,12 +2027,12 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setHasFragileUserData(boolean value) { + public PackageImpl setUserDataFragile(boolean value) { return setBoolean(Booleans.HAS_FRAGILE_USER_DATA, value); } @Override - public PackageImpl setIconRes(int value) { + public PackageImpl setIconResourceId(int value) { iconRes = value; return this; } @@ -2049,7 +2049,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setKillAfterRestore(boolean value) { + public PackageImpl setKillAfterRestoreAllowed(boolean value) { return setBoolean(Booleans.KILL_AFTER_RESTORE, value); } @@ -2060,7 +2060,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setLabelRes(int value) { + public PackageImpl setLabelResourceId(int value) { labelRes = value; return this; } @@ -2082,13 +2082,13 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setLocaleConfigRes(int value) { + public PackageImpl setLocaleConfigResourceId(int value) { mLocaleConfigRes = value; return this; } @Override - public PackageImpl setLogoRes(int value) { + public PackageImpl setLogoResourceId(int value) { logo = value; return this; } @@ -2154,7 +2154,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setNetworkSecurityConfigRes(int value) { + public PackageImpl setNetworkSecurityConfigResourceId(int value) { networkSecurityConfigRes = value; return this; } @@ -2318,7 +2318,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setRoundIconRes(int value) { + public PackageImpl setRoundIconResourceId(int value) { roundIconRes = value; return this; } @@ -2347,7 +2347,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setSharedUserLabelRes(int value) { + public PackageImpl setSharedUserLabelResourceId(int value) { sharedUserLabel = value; return this; } @@ -2384,7 +2384,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setSupportsExtraLargeScreens(int supportsExtraLargeScreens) { + public PackageImpl setExtraLargeScreensSupported(int supportsExtraLargeScreens) { if (supportsExtraLargeScreens == 1) { return this; } @@ -2394,7 +2394,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setSupportsLargeScreens(int supportsLargeScreens) { + public PackageImpl setLargeScreensSupported(int supportsLargeScreens) { if (supportsLargeScreens == 1) { return this; } @@ -2404,7 +2404,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setSupportsNormalScreens(int supportsNormalScreens) { + public PackageImpl setNormalScreensSupported(int supportsNormalScreens) { if (supportsNormalScreens == 1) { return this; } @@ -2414,12 +2414,12 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setSupportsRtl(boolean value) { + public PackageImpl setRtlSupported(boolean value) { return setBoolean(Booleans.SUPPORTS_RTL, value); } @Override - public PackageImpl setSupportsSmallScreens(int supportsSmallScreens) { + public PackageImpl setSmallScreensSupported(int supportsSmallScreens) { if (supportsSmallScreens == 1) { return this; } @@ -2452,7 +2452,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setThemeRes(int value) { + public PackageImpl setThemeResourceId(int value) { theme = value; return this; } @@ -2470,7 +2470,7 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setUse32BitAbi(boolean value) { + public PackageImpl set32BitAbiPreferred(boolean value) { return setBoolean(Booleans.USE_32_BIT_ABI, value); } @@ -2480,12 +2480,12 @@ public class PackageImpl implements ParsedPackage, AndroidPackageInternal, } @Override - public PackageImpl setUsesCleartextTraffic(boolean value) { + public PackageImpl setCleartextTrafficAllowed(boolean value) { return setBoolean(Booleans.USES_CLEARTEXT_TRAFFIC, value); } @Override - public PackageImpl setUsesNonSdkApi(boolean value) { + public PackageImpl setNonSdkApiRequested(boolean value) { return setBoolean(Booleans.USES_NON_SDK_API, value); } diff --git a/services/core/java/com/android/server/pm/pkg/AndroidPackage.java b/services/core/java/com/android/server/pm/pkg/AndroidPackage.java index ad738730598f..2fdda1210394 100644 --- a/services/core/java/com/android/server/pm/pkg/AndroidPackage.java +++ b/services/core/java/com/android/server/pm/pkg/AndroidPackage.java @@ -116,7 +116,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestApplication_banner */ @DrawableRes - int getBannerRes(); + int getBannerResourceId(); /** * @see PackageInfo#baseRevisionCode @@ -149,21 +149,21 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestApplication_dataExtractionRules */ @XmlRes - int getDataExtractionRulesRes(); + int getDataExtractionRulesResourceId(); /** * @see ApplicationInfo#descriptionRes * @see R.styleable#AndroidManifestApplication_description */ @StringRes // This is actually format="reference" - int getDescriptionRes(); + int getDescriptionResourceId(); /** * @see ApplicationInfo#fullBackupContent * @see R.styleable#AndroidManifestApplication_fullBackupContent */ @XmlRes - int getFullBackupContentRes(); + int getFullBackupContentResourceId(); /** * @see ApplicationInfo#getGwpAsanMode() @@ -177,14 +177,14 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestApplication_icon */ @DrawableRes - int getIconRes(); + int getIconResourceId(); /** * @see ApplicationInfo#labelRes * @see R.styleable#AndroidManifestApplication_label */ @StringRes - int getLabelRes(); + int getLabelResourceId(); /** * @see ApplicationInfo#largestWidthLimitDp @@ -206,7 +206,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestApplication_logo */ @DrawableRes - int getLogoRes(); + int getLogoResourceId(); /** * The resource ID used to provide the application's locales configuration. @@ -214,7 +214,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestApplication_localeConfig */ @XmlRes - int getLocaleConfigRes(); + int getLocaleConfigResourceId(); /** * @see PackageInfo#getLongVersionCode() @@ -247,7 +247,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestApplication_networkSecurityConfig */ @XmlRes - int getNetworkSecurityConfigRes(); + int getNetworkSecurityConfigResourceId(); /** * @see PackageInfo#requiredAccountType @@ -277,7 +277,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestApplication_roundIcon */ @DrawableRes - int getRoundIconRes(); + int getRoundIconResourceId(); /** * @see R.styleable#AndroidManifestSdkLibrary_name @@ -297,7 +297,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifest_sharedUserLabel */ @StringRes - int getSharedUserLabelRes(); + int getSharedUserLabelResourceId(); /** * @return List of all splits for a package. Note that base.apk is considered a @@ -336,7 +336,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestApplication_theme */ @StyleRes - int getThemeRes(); + int getThemeResourceId(); /** * @see ApplicationInfo#uiOptions @@ -367,19 +367,19 @@ public interface AndroidPackage { * @see ApplicationInfo#FLAG_ALLOW_BACKUP * @see R.styleable#AndroidManifestApplication_allowBackup */ - boolean isAllowBackup(); + boolean isBackupAllowed(); /** * @see ApplicationInfo#FLAG_ALLOW_CLEAR_USER_DATA * @see R.styleable#AndroidManifestApplication_allowClearUserData */ - boolean isAllowClearUserData(); + boolean isClearUserDataAllowed(); /** * @see ApplicationInfo#PRIVATE_FLAG_ALLOW_CLEAR_USER_DATA_ON_FAILED_RESTORE * @see R.styleable#AndroidManifestApplication_allowClearUserDataOnFailedRestore */ - boolean isAllowClearUserDataOnFailedRestore(); + boolean isClearUserDataOnFailedRestoreAllowed(); /** * @see ApplicationInfo#PRIVATE_FLAG_ALLOW_NATIVE_HEAP_POINTER_TAGGING @@ -391,7 +391,7 @@ public interface AndroidPackage { * @see ApplicationInfo#FLAG_ALLOW_TASK_REPARENTING * @see R.styleable#AndroidManifestApplication_allowTaskReparenting */ - boolean isAllowTaskReparenting(); + boolean isTaskReparentingAllowed(); /** * If omitted from manifest, returns true if {@link #getTargetSdkVersion()} >= {@link @@ -424,7 +424,7 @@ public interface AndroidPackage { * @see ApplicationInfo#PRIVATE_FLAG_CANT_SAVE_STATE * @see R.styleable#AndroidManifestApplication_cantSaveState */ - boolean isCantSaveState(); + boolean isSaveStateDisallowed(); /** * @see PackageInfo#coreApp @@ -459,7 +459,7 @@ public interface AndroidPackage { * @see ApplicationInfo#FLAG_EXTRACT_NATIVE_LIBS * @see R.styleable#AndroidManifestApplication_extractNativeLibs */ - boolean isExtractNativeLibs(); + boolean isExtractNativeLibrariesRequested(); /** * @see ApplicationInfo#FLAG_FACTORY_TEST @@ -481,13 +481,13 @@ public interface AndroidPackage { * @see ApplicationInfo#FLAG_HAS_CODE * @see R.styleable#AndroidManifestApplication_hasCode */ - boolean isHasCode(); + boolean isDeclaredHavingCode(); /** * @see ApplicationInfo#PRIVATE_FLAG_HAS_FRAGILE_USER_DATA * @see R.styleable#AndroidManifestApplication_hasFragileUserData */ - boolean isHasFragileUserData(); + boolean isUserDataFragile(); /** * @see ApplicationInfo#PRIVATE_FLAG_ISOLATED_SPLIT_LOADING @@ -499,7 +499,7 @@ public interface AndroidPackage { * @see ApplicationInfo#FLAG_KILL_AFTER_RESTORE * @see R.styleable#AndroidManifestApplication_killAfterRestore */ - boolean isKillAfterRestore(); + boolean isKillAfterRestoreAllowed(); /** * @see ApplicationInfo#FLAG_LARGE_HEAP @@ -596,7 +596,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestSupportsScreens_xlargeScreens * @see ApplicationInfo#FLAG_SUPPORTS_XLARGE_SCREENS */ - boolean isSupportsExtraLargeScreens(); + boolean isExtraLargeScreensSupported(); /** * If omitted from manifest, returns true if {@link #getTargetSdkVersion()} >= {@link @@ -605,7 +605,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestSupportsScreens_largeScreens * @see ApplicationInfo#FLAG_SUPPORTS_LARGE_SCREENS */ - boolean isSupportsLargeScreens(); + boolean isLargeScreensSupported(); /** * If omitted from manifest, returns true. @@ -613,13 +613,13 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestSupportsScreens_normalScreens * @see ApplicationInfo#FLAG_SUPPORTS_NORMAL_SCREENS */ - boolean isSupportsNormalScreens(); + boolean isNormalScreensSupported(); /** * @see ApplicationInfo#FLAG_SUPPORTS_RTL * @see R.styleable#AndroidManifestApplication_supportsRtl */ - boolean isSupportsRtl(); + boolean isRtlSupported(); /** * If omitted from manifest, returns true if {@link #getTargetSdkVersion()} >= {@link @@ -628,7 +628,7 @@ public interface AndroidPackage { * @see R.styleable#AndroidManifestSupportsScreens_smallScreens * @see ApplicationInfo#FLAG_SUPPORTS_SMALL_SCREENS */ - boolean isSupportsSmallScreens(); + boolean isSmallScreensSupported(); /** * @see ApplicationInfo#FLAG_TEST_ONLY @@ -643,13 +643,13 @@ public interface AndroidPackage { * * @see R.attr#use32bitAbi */ - boolean isUse32BitAbi(); + boolean is32BitAbiPreferred(); /** * @see ApplicationInfo#FLAG_USES_CLEARTEXT_TRAFFIC * @see R.styleable#AndroidManifestApplication_usesCleartextTraffic */ - boolean isUsesCleartextTraffic(); + boolean isCleartextTrafficAllowed(); /** * @see ApplicationInfo#PRIVATE_FLAG_USE_EMBEDDED_DEX @@ -661,7 +661,7 @@ public interface AndroidPackage { * @see ApplicationInfo#PRIVATE_FLAG_USES_NON_SDK_API * @see R.styleable#AndroidManifestApplication_usesNonSdkApi */ - boolean isUsesNonSdkApi(); + boolean isNonSdkApiRequested(); /** * @see ApplicationInfo#FLAG_VM_SAFE_MODE @@ -892,7 +892,7 @@ public interface AndroidPackage { /** * If {@link R.styleable#AndroidManifestApplication_label} is a string literal, this is it. - * Otherwise, it's stored as {@link #getLabelRes()}. + * Otherwise, it's stored as {@link #getLabelResourceId()}. * * @see ApplicationInfo#nonLocalizedLabel * @see R.styleable#AndroidManifestApplication_label diff --git a/services/core/java/com/android/server/pm/pkg/PackageState.java b/services/core/java/com/android/server/pm/pkg/PackageState.java index 106b149997a7..2c37876dd261 100644 --- a/services/core/java/com/android/server/pm/pkg/PackageState.java +++ b/services/core/java/com/android/server/pm/pkg/PackageState.java @@ -160,6 +160,14 @@ public interface PackageState { /** * List of shared libraries that this package declares a dependency on. This includes all * types of libraries, system or app provided and Java or native. + * <p/> + * This includes libraries declared in the manifest under the following tags: + * <ul> + * <li>uses-library</li> + * <li>uses-native-library</li> + * <li>uses-sdk-library</li> + * <li>uses-static-library</li> + * </ul> */ @NonNull List<SharedLibrary> getSharedLibraryDependencies(); diff --git a/services/core/java/com/android/server/pm/pkg/component/ParsedActivityUtils.java b/services/core/java/com/android/server/pm/pkg/component/ParsedActivityUtils.java index b73ff3480359..ee793c8b2f87 100644 --- a/services/core/java/com/android/server/pm/pkg/component/ParsedActivityUtils.java +++ b/services/core/java/com/android/server/pm/pkg/component/ParsedActivityUtils.java @@ -114,7 +114,7 @@ public class ParsedActivityUtils { return input.error(result); } - if (receiver && pkg.isCantSaveState()) { + if (receiver && pkg.isSaveStateDisallowed()) { // A heavy-weight application can not have receivers in its main process if (Objects.equals(activity.getProcessName(), packageName)) { return input.error("Heavy-weight applications can not have receivers " @@ -129,7 +129,7 @@ public class ParsedActivityUtils { activity.setTheme(sa.getResourceId(R.styleable.AndroidManifestActivity_theme, 0)) .setUiOptions(sa.getInt(R.styleable.AndroidManifestActivity_uiOptions, pkg.getUiOptions())); - activity.setFlags(activity.getFlags() | (flag(ActivityInfo.FLAG_ALLOW_TASK_REPARENTING, R.styleable.AndroidManifestActivity_allowTaskReparenting, pkg.isAllowTaskReparenting(), sa) + activity.setFlags(activity.getFlags() | (flag(ActivityInfo.FLAG_ALLOW_TASK_REPARENTING, R.styleable.AndroidManifestActivity_allowTaskReparenting, pkg.isTaskReparentingAllowed(), sa) | flag(ActivityInfo.FLAG_ALWAYS_RETAIN_TASK_STATE, R.styleable.AndroidManifestActivity_alwaysRetainTaskState, sa) | flag(ActivityInfo.FLAG_CLEAR_TASK_ON_LAUNCH, R.styleable.AndroidManifestActivity_clearTaskOnLaunch, sa) | flag(ActivityInfo.FLAG_EXCLUDE_FROM_RECENTS, R.styleable.AndroidManifestActivity_excludeFromRecents, sa) diff --git a/services/core/java/com/android/server/pm/pkg/component/ParsedProviderUtils.java b/services/core/java/com/android/server/pm/pkg/component/ParsedProviderUtils.java index 4cb4dd04f42a..37bed15ba1d7 100644 --- a/services/core/java/com/android/server/pm/pkg/component/ParsedProviderUtils.java +++ b/services/core/java/com/android/server/pm/pkg/component/ParsedProviderUtils.java @@ -136,7 +136,7 @@ public class ParsedProviderUtils { sa.recycle(); } - if (pkg.isCantSaveState()) { + if (pkg.isSaveStateDisallowed()) { // A heavy-weight application can not have providers in its main process if (Objects.equals(provider.getProcessName(), packageName)) { return input.error("Heavy-weight applications can not have providers" diff --git a/services/core/java/com/android/server/pm/pkg/component/ParsedServiceUtils.java b/services/core/java/com/android/server/pm/pkg/component/ParsedServiceUtils.java index a812257eec92..c15266fc4cbc 100644 --- a/services/core/java/com/android/server/pm/pkg/component/ParsedServiceUtils.java +++ b/services/core/java/com/android/server/pm/pkg/component/ParsedServiceUtils.java @@ -115,7 +115,7 @@ public class ParsedServiceUtils { sa.recycle(); } - if (pkg.isCantSaveState()) { + if (pkg.isSaveStateDisallowed()) { // A heavy-weight application can not have services in its main process // We can do direct compare because we intern all strings. if (Objects.equals(service.getProcessName(), packageName)) { diff --git a/services/core/java/com/android/server/pm/pkg/parsing/ParsingPackage.java b/services/core/java/com/android/server/pm/pkg/parsing/ParsingPackage.java index bb36758f1e77..6cb6a9783134 100644 --- a/services/core/java/com/android/server/pm/pkg/parsing/ParsingPackage.java +++ b/services/core/java/com/android/server/pm/pkg/parsing/ParsingPackage.java @@ -163,19 +163,20 @@ public interface ParsingPackage { ParsingPackage setAllowAudioPlaybackCapture(boolean allowAudioPlaybackCapture); - ParsingPackage setAllowBackup(boolean allowBackup); + ParsingPackage setBackupAllowed(boolean allowBackup); - ParsingPackage setAllowClearUserData(boolean allowClearUserData); + ParsingPackage setClearUserDataAllowed(boolean allowClearUserData); - ParsingPackage setAllowClearUserDataOnFailedRestore(boolean allowClearUserDataOnFailedRestore); + ParsingPackage setClearUserDataOnFailedRestoreAllowed( + boolean allowClearUserDataOnFailedRestore); - ParsingPackage setAllowTaskReparenting(boolean allowTaskReparenting); + ParsingPackage setTaskReparentingAllowed(boolean allowTaskReparenting); ParsingPackage setResourceOverlay(boolean isResourceOverlay); ParsingPackage setBackupInForeground(boolean backupInForeground); - ParsingPackage setCantSaveState(boolean cantSaveState); + ParsingPackage setSaveStateDisallowed(boolean cantSaveState); ParsingPackage setDebuggable(boolean debuggable); @@ -185,19 +186,19 @@ public interface ParsingPackage { ParsingPackage setExternalStorage(boolean externalStorage); - ParsingPackage setExtractNativeLibs(boolean extractNativeLibs); + ParsingPackage setExtractNativeLibrariesRequested(boolean extractNativeLibs); ParsingPackage setFullBackupOnly(boolean fullBackupOnly); - ParsingPackage setHasCode(boolean hasCode); + ParsingPackage setDeclaredHavingCode(boolean hasCode); - ParsingPackage setHasFragileUserData(boolean hasFragileUserData); + ParsingPackage setUserDataFragile(boolean hasFragileUserData); ParsingPackage setGame(boolean isGame); ParsingPackage setIsolatedSplitLoading(boolean isolatedSplitLoading); - ParsingPackage setKillAfterRestore(boolean killAfterRestore); + ParsingPackage setKillAfterRestoreAllowed(boolean killAfterRestore); ParsingPackage setLargeHeap(boolean largeHeap); @@ -231,15 +232,15 @@ public interface ParsingPackage { ParsingPackage setStaticSharedLibrary(boolean staticSharedLibrary); - ParsingPackage setSupportsRtl(boolean supportsRtl); + ParsingPackage setRtlSupported(boolean supportsRtl); ParsingPackage setTestOnly(boolean testOnly); ParsingPackage setUseEmbeddedDex(boolean useEmbeddedDex); - ParsingPackage setUsesCleartextTraffic(boolean usesCleartextTraffic); + ParsingPackage setCleartextTrafficAllowed(boolean usesCleartextTraffic); - ParsingPackage setUsesNonSdkApi(boolean usesNonSdkApi); + ParsingPackage setNonSdkApiRequested(boolean usesNonSdkApi); ParsingPackage setVisibleToInstantApps(boolean visibleToInstantApps); @@ -255,7 +256,7 @@ public interface ParsingPackage { ParsingPackage setBackupAgentName(String backupAgentName); - ParsingPackage setBannerRes(int banner); + ParsingPackage setBannerResourceId(int banner); ParsingPackage setCategory(int category); @@ -265,7 +266,7 @@ public interface ParsingPackage { ParsingPackage setCompatibleWidthLimitDp(int compatibleWidthLimitDp); - ParsingPackage setDescriptionRes(int descriptionRes); + ParsingPackage setDescriptionResourceId(int descriptionRes); ParsingPackage setEnabled(boolean enabled); @@ -281,24 +282,24 @@ public interface ParsingPackage { ParsingPackage setCrossProfile(boolean crossProfile); - ParsingPackage setFullBackupContentRes(int fullBackupContentRes); + ParsingPackage setFullBackupContentResourceId(int fullBackupContentRes); - ParsingPackage setDataExtractionRulesRes(int dataExtractionRulesRes); + ParsingPackage setDataExtractionRulesResourceId(int dataExtractionRulesRes); ParsingPackage setHasDomainUrls(boolean hasDomainUrls); - ParsingPackage setIconRes(int iconRes); + ParsingPackage setIconResourceId(int iconRes); ParsingPackage setInstallLocation(int installLocation); /** @see R#styleable.AndroidManifest_sharedUserMaxSdkVersion */ ParsingPackage setLeavingSharedUser(boolean leavingSharedUser); - ParsingPackage setLabelRes(int labelRes); + ParsingPackage setLabelResourceId(int labelRes); ParsingPackage setLargestWidthLimitDp(int largestWidthLimitDp); - ParsingPackage setLogoRes(int logo); + ParsingPackage setLogoResourceId(int logo); ParsingPackage setManageSpaceActivityName(String manageSpaceActivityName); @@ -308,7 +309,7 @@ public interface ParsingPackage { ParsingPackage setMaxSdkVersion(int maxSdkVersion); - ParsingPackage setNetworkSecurityConfigRes(int networkSecurityConfigRes); + ParsingPackage setNetworkSecurityConfigResourceId(int networkSecurityConfigRes); ParsingPackage setNonLocalizedLabel(CharSequence nonLocalizedLabel); @@ -334,9 +335,9 @@ public interface ParsingPackage { ParsingPackage setRestrictedAccountType(String restrictedAccountType); - ParsingPackage setRoundIconRes(int roundIconRes); + ParsingPackage setRoundIconResourceId(int roundIconRes); - ParsingPackage setSharedUserLabelRes(int sharedUserLabelRes); + ParsingPackage setSharedUserLabelResourceId(int sharedUserLabelRes); ParsingPackage setSigningDetails(@NonNull SigningDetails signingDetails); @@ -344,23 +345,23 @@ public interface ParsingPackage { ParsingPackage setStaticSharedLibraryVersion(long staticSharedLibraryVersion); - ParsingPackage setSupportsLargeScreens(int supportsLargeScreens); + ParsingPackage setLargeScreensSupported(int supportsLargeScreens); - ParsingPackage setSupportsNormalScreens(int supportsNormalScreens); + ParsingPackage setNormalScreensSupported(int supportsNormalScreens); - ParsingPackage setSupportsSmallScreens(int supportsSmallScreens); + ParsingPackage setSmallScreensSupported(int supportsSmallScreens); - ParsingPackage setSupportsExtraLargeScreens(int supportsExtraLargeScreens); + ParsingPackage setExtraLargeScreensSupported(int supportsExtraLargeScreens); ParsingPackage setTargetSandboxVersion(int targetSandboxVersion); - ParsingPackage setThemeRes(int theme); + ParsingPackage setThemeResourceId(int theme); ParsingPackage setRequestForegroundServiceExemption(boolean requestForegroundServiceExemption); ParsingPackage setUpgradeKeySets(@NonNull Set<String> upgradeKeySets); - ParsingPackage setUse32BitAbi(boolean use32BitAbi); + ParsingPackage set32BitAbiPreferred(boolean use32BitAbi); ParsingPackage setVolumeUuid(@Nullable String volumeUuid); @@ -385,7 +386,7 @@ public interface ParsingPackage { ParsingPackage setResetEnabledSettingsOnAppDataCleared( boolean resetEnabledSettingsOnAppDataCleared); - ParsingPackage setLocaleConfigRes(int localeConfigRes); + ParsingPackage setLocaleConfigResourceId(int localeConfigRes); ParsingPackage setAllowUpdateOwnership(boolean value); @@ -508,15 +509,15 @@ public interface ParsingPackage { @Nullable String getZygotePreloadName(); - boolean isAllowBackup(); + boolean isBackupAllowed(); - boolean isAllowTaskReparenting(); + boolean isTaskReparentingAllowed(); boolean isAnyDensity(); boolean isHardwareAccelerated(); - boolean isCantSaveState(); + boolean isSaveStateDisallowed(); boolean isProfileable(); @@ -528,11 +529,11 @@ public interface ParsingPackage { boolean isStaticSharedLibrary(); - boolean isSupportsExtraLargeScreens(); + boolean isExtraLargeScreensSupported(); - boolean isSupportsLargeScreens(); + boolean isLargeScreensSupported(); - boolean isSupportsNormalScreens(); + boolean isNormalScreensSupported(); - boolean isSupportsSmallScreens(); + boolean isSmallScreensSupported(); } diff --git a/services/core/java/com/android/server/pm/pkg/parsing/ParsingPackageUtils.java b/services/core/java/com/android/server/pm/pkg/parsing/ParsingPackageUtils.java index 31f291fa948d..fda44e495b89 100644 --- a/services/core/java/com/android/server/pm/pkg/parsing/ParsingPackageUtils.java +++ b/services/core/java/com/android/server/pm/pkg/parsing/ParsingPackageUtils.java @@ -430,7 +430,7 @@ public class ParsingPackageUtils { } } - pkg.setUse32BitAbi(lite.isUse32bitAbi()); + pkg.set32BitAbiPreferred(lite.isUse32bitAbi()); return input.success(pkg); } catch (IllegalArgumentException e) { return input.error(e.getCause() instanceof IOException ? INSTALL_FAILED_INVALID_APK @@ -466,7 +466,7 @@ public class ParsingPackageUtils { } return input.success(result.getResult() - .setUse32BitAbi(lite.isUse32bitAbi())); + .set32BitAbiPreferred(lite.isUse32bitAbi())); } catch (IOException e) { return input.error(INSTALL_PARSE_FAILED_UNEXPECTED_EXCEPTION, "Failed to get path: " + apkFile, e); @@ -957,10 +957,10 @@ public class ParsingPackageUtils { // cannot be windowed / resized. Note that an SDK version of 0 is common for // pre-Doughnut applications. if (pkg.getTargetSdkVersion() < DONUT - || (!pkg.isSupportsSmallScreens() - && !pkg.isSupportsNormalScreens() - && !pkg.isSupportsLargeScreens() - && !pkg.isSupportsExtraLargeScreens() + || (!pkg.isSmallScreensSupported() + && !pkg.isNormalScreensSupported() + && !pkg.isLargeScreensSupported() + && !pkg.isExtraLargeScreensSupported() && !pkg.isResizeable() && !pkg.isAnyDensity())) { adjustPackageToBeUnresizeableAndUnpipable(pkg); @@ -1052,7 +1052,8 @@ public class ParsingPackageUtils { return input.success(pkg .setLeavingSharedUser(leaving) .setSharedUserId(str.intern()) - .setSharedUserLabelRes(resId(R.styleable.AndroidManifest_sharedUserLabel, sa))); + .setSharedUserLabelResourceId( + resId(R.styleable.AndroidManifest_sharedUserLabel, sa))); } private static ParseResult<ParsingPackage> parseKeySets(ParseInput input, @@ -1885,7 +1886,7 @@ public class ParsingPackageUtils { TypedValue labelValue = sa.peekValue(R.styleable.AndroidManifestApplication_label); if (labelValue != null) { - pkg.setLabelRes(labelValue.resourceId); + pkg.setLabelResourceId(labelValue.resourceId); if (labelValue.resourceId == 0) { pkg.setNonLocalizedLabel(labelValue.coerceToString()); } @@ -1906,7 +1907,7 @@ public class ParsingPackageUtils { pkg.setManageSpaceActivityName(manageSpaceActivityName); } - if (pkg.isAllowBackup()) { + if (pkg.isBackupAllowed()) { // backupAgent, killAfterRestore, fullBackupContent, backupInForeground, // and restoreAnyVersion are only relevant if backup is possible for the // given application. @@ -1924,7 +1925,7 @@ public class ParsingPackageUtils { } pkg.setBackupAgentName(backupAgentName) - .setKillAfterRestore(bool(true, + .setKillAfterRestoreAllowed(bool(true, R.styleable.AndroidManifestApplication_killAfterRestore, sa)) .setRestoreAnyVersion(bool(false, R.styleable.AndroidManifestApplication_restoreAnyVersion, sa)) @@ -1950,7 +1951,7 @@ public class ParsingPackageUtils { fullBackupContent = v.data == 0 ? -1 : 0; } - pkg.setFullBackupContentRes(fullBackupContent); + pkg.setFullBackupContentResourceId(fullBackupContent); } if (DEBUG_BACKUP) { Slog.v(TAG, "fullBackupContent=" + fullBackupContent + " for " + pkgName); @@ -2024,7 +2025,7 @@ public class ParsingPackageUtils { String processName = processNameResult.getResult(); pkg.setProcessName(processName); - if (pkg.isCantSaveState()) { + if (pkg.isSaveStateDisallowed()) { // A heavy-weight application can not be in a custom process. // We can do direct compare because we intern all strings. if (processName != null && !processName.equals(pkgName)) { @@ -2224,31 +2225,31 @@ public class ParsingPackageUtils { // CHECKSTYLE:off pkg // Default true - .setAllowBackup(bool(true, R.styleable.AndroidManifestApplication_allowBackup, sa)) - .setAllowClearUserData(bool(true, R.styleable.AndroidManifestApplication_allowClearUserData, sa)) - .setAllowClearUserDataOnFailedRestore(bool(true, R.styleable.AndroidManifestApplication_allowClearUserDataOnFailedRestore, sa)) + .setBackupAllowed(bool(true, R.styleable.AndroidManifestApplication_allowBackup, sa)) + .setClearUserDataAllowed(bool(true, R.styleable.AndroidManifestApplication_allowClearUserData, sa)) + .setClearUserDataOnFailedRestoreAllowed(bool(true, R.styleable.AndroidManifestApplication_allowClearUserDataOnFailedRestore, sa)) .setAllowNativeHeapPointerTagging(bool(true, R.styleable.AndroidManifestApplication_allowNativeHeapPointerTagging, sa)) .setEnabled(bool(true, R.styleable.AndroidManifestApplication_enabled, sa)) - .setExtractNativeLibs(bool(true, R.styleable.AndroidManifestApplication_extractNativeLibs, sa)) - .setHasCode(bool(true, R.styleable.AndroidManifestApplication_hasCode, sa)) + .setExtractNativeLibrariesRequested(bool(true, R.styleable.AndroidManifestApplication_extractNativeLibs, sa)) + .setDeclaredHavingCode(bool(true, R.styleable.AndroidManifestApplication_hasCode, sa)) // Default false - .setAllowTaskReparenting(bool(false, R.styleable.AndroidManifestApplication_allowTaskReparenting, sa)) - .setCantSaveState(bool(false, R.styleable.AndroidManifestApplication_cantSaveState, sa)) + .setTaskReparentingAllowed(bool(false, R.styleable.AndroidManifestApplication_allowTaskReparenting, sa)) + .setSaveStateDisallowed(bool(false, R.styleable.AndroidManifestApplication_cantSaveState, sa)) .setCrossProfile(bool(false, R.styleable.AndroidManifestApplication_crossProfile, sa)) .setDebuggable(bool(false, R.styleable.AndroidManifestApplication_debuggable, sa)) .setDefaultToDeviceProtectedStorage(bool(false, R.styleable.AndroidManifestApplication_defaultToDeviceProtectedStorage, sa)) .setDirectBootAware(bool(false, R.styleable.AndroidManifestApplication_directBootAware, sa)) .setForceQueryable(bool(false, R.styleable.AndroidManifestApplication_forceQueryable, sa)) .setGame(bool(false, R.styleable.AndroidManifestApplication_isGame, sa)) - .setHasFragileUserData(bool(false, R.styleable.AndroidManifestApplication_hasFragileUserData, sa)) + .setUserDataFragile(bool(false, R.styleable.AndroidManifestApplication_hasFragileUserData, sa)) .setLargeHeap(bool(false, R.styleable.AndroidManifestApplication_largeHeap, sa)) .setMultiArch(bool(false, R.styleable.AndroidManifestApplication_multiArch, sa)) .setPreserveLegacyExternalStorage(bool(false, R.styleable.AndroidManifestApplication_preserveLegacyExternalStorage, sa)) .setRequiredForAllUsers(bool(false, R.styleable.AndroidManifestApplication_requiredForAllUsers, sa)) - .setSupportsRtl(bool(false, R.styleable.AndroidManifestApplication_supportsRtl, sa)) + .setRtlSupported(bool(false, R.styleable.AndroidManifestApplication_supportsRtl, sa)) .setTestOnly(bool(false, R.styleable.AndroidManifestApplication_testOnly, sa)) .setUseEmbeddedDex(bool(false, R.styleable.AndroidManifestApplication_useEmbeddedDex, sa)) - .setUsesNonSdkApi(bool(false, R.styleable.AndroidManifestApplication_usesNonSdkApi, sa)) + .setNonSdkApiRequested(bool(false, R.styleable.AndroidManifestApplication_usesNonSdkApi, sa)) .setVmSafeMode(bool(false, R.styleable.AndroidManifestApplication_vmSafeMode, sa)) .setAutoRevokePermissions(anInt(R.styleable.AndroidManifestApplication_autoRevokePermissions, sa)) .setAttributionsAreUserVisible(bool(false, R.styleable.AndroidManifestApplication_attributionsAreUserVisible, sa)) @@ -2260,7 +2261,7 @@ public class ParsingPackageUtils { .setAllowAudioPlaybackCapture(bool(targetSdk >= Build.VERSION_CODES.Q, R.styleable.AndroidManifestApplication_allowAudioPlaybackCapture, sa)) .setHardwareAccelerated(bool(targetSdk >= Build.VERSION_CODES.ICE_CREAM_SANDWICH, R.styleable.AndroidManifestApplication_hardwareAccelerated, sa)) .setRequestLegacyExternalStorage(bool(targetSdk < Build.VERSION_CODES.Q, R.styleable.AndroidManifestApplication_requestLegacyExternalStorage, sa)) - .setUsesCleartextTraffic(bool(targetSdk < Build.VERSION_CODES.P, R.styleable.AndroidManifestApplication_usesCleartextTraffic, sa)) + .setCleartextTrafficAllowed(bool(targetSdk < Build.VERSION_CODES.P, R.styleable.AndroidManifestApplication_usesCleartextTraffic, sa)) // Ints Default 0 .setUiOptions(anInt(R.styleable.AndroidManifestApplication_uiOptions, sa)) // Ints @@ -2269,16 +2270,16 @@ public class ParsingPackageUtils { .setMaxAspectRatio(aFloat(R.styleable.AndroidManifestApplication_maxAspectRatio, sa)) .setMinAspectRatio(aFloat(R.styleable.AndroidManifestApplication_minAspectRatio, sa)) // Resource ID - .setBannerRes(resId(R.styleable.AndroidManifestApplication_banner, sa)) - .setDescriptionRes(resId(R.styleable.AndroidManifestApplication_description, sa)) - .setIconRes(resId(R.styleable.AndroidManifestApplication_icon, sa)) - .setLogoRes(resId(R.styleable.AndroidManifestApplication_logo, sa)) - .setNetworkSecurityConfigRes(resId(R.styleable.AndroidManifestApplication_networkSecurityConfig, sa)) - .setRoundIconRes(resId(R.styleable.AndroidManifestApplication_roundIcon, sa)) - .setThemeRes(resId(R.styleable.AndroidManifestApplication_theme, sa)) - .setDataExtractionRulesRes( + .setBannerResourceId(resId(R.styleable.AndroidManifestApplication_banner, sa)) + .setDescriptionResourceId(resId(R.styleable.AndroidManifestApplication_description, sa)) + .setIconResourceId(resId(R.styleable.AndroidManifestApplication_icon, sa)) + .setLogoResourceId(resId(R.styleable.AndroidManifestApplication_logo, sa)) + .setNetworkSecurityConfigResourceId(resId(R.styleable.AndroidManifestApplication_networkSecurityConfig, sa)) + .setRoundIconResourceId(resId(R.styleable.AndroidManifestApplication_roundIcon, sa)) + .setThemeResourceId(resId(R.styleable.AndroidManifestApplication_theme, sa)) + .setDataExtractionRulesResourceId( resId(R.styleable.AndroidManifestApplication_dataExtractionRules, sa)) - .setLocaleConfigRes(resId(R.styleable.AndroidManifestApplication_localeConfig, sa)) + .setLocaleConfigResourceId(resId(R.styleable.AndroidManifestApplication_localeConfig, sa)) // Strings .setClassLoaderName(string(R.styleable.AndroidManifestApplication_classLoader, sa)) .setRequiredAccountType(string(R.styleable.AndroidManifestApplication_requiredAccountType, sa)) @@ -2883,13 +2884,13 @@ public class ParsingPackageUtils { // This is a trick to get a boolean and still able to detect // if a value was actually set. return input.success(pkg - .setSupportsSmallScreens( + .setSmallScreensSupported( anInt(1, R.styleable.AndroidManifestSupportsScreens_smallScreens, sa)) - .setSupportsNormalScreens( + .setNormalScreensSupported( anInt(1, R.styleable.AndroidManifestSupportsScreens_normalScreens, sa)) - .setSupportsLargeScreens( + .setLargeScreensSupported( anInt(1, R.styleable.AndroidManifestSupportsScreens_largeScreens, sa)) - .setSupportsExtraLargeScreens( + .setExtraLargeScreensSupported( anInt(1, R.styleable.AndroidManifestSupportsScreens_xlargeScreens, sa)) .setResizeable( anInt(1, R.styleable.AndroidManifestSupportsScreens_resizeable, sa)) diff --git a/services/tests/PackageManagerServiceTests/server/src/com/android/server/pm/PackageParserTest.java b/services/tests/PackageManagerServiceTests/server/src/com/android/server/pm/PackageParserTest.java index 9895e7ccdac1..c7fb32c2aa17 100644 --- a/services/tests/PackageManagerServiceTests/server/src/com/android/server/pm/PackageParserTest.java +++ b/services/tests/PackageManagerServiceTests/server/src/com/android/server/pm/PackageParserTest.java @@ -753,7 +753,7 @@ public class PackageParserTest { .setPVersionCode(pkg.getLongVersionCode()) .setPkgFlags(PackageInfoUtils.appInfoFlags(pkg, null)) .setPrivateFlags(PackageInfoUtils.appInfoPrivateFlags(pkg, null)) - .setSharedUserId(pkg.getSharedUserLabelRes()) + .setSharedUserId(pkg.getSharedUserLabelResourceId()) .build(); } @@ -763,13 +763,13 @@ public class PackageParserTest { assertEquals(a.getBaseRevisionCode(), b.getBaseRevisionCode()); assertEquals(a.isHardwareAccelerated(), b.isHardwareAccelerated()); assertEquals(a.getLongVersionCode(), b.getLongVersionCode()); - assertEquals(a.getSharedUserLabelRes(), b.getSharedUserLabelRes()); + assertEquals(a.getSharedUserLabelResourceId(), b.getSharedUserLabelResourceId()); assertEquals(a.getInstallLocation(), b.getInstallLocation()); assertEquals(a.isCoreApp(), b.isCoreApp()); assertEquals(a.isRequiredForAllUsers(), b.isRequiredForAllUsers()); assertEquals(a.getCompileSdkVersion(), b.getCompileSdkVersion()); assertEquals(a.getCompileSdkVersionCodeName(), b.getCompileSdkVersionCodeName()); - assertEquals(a.isUse32BitAbi(), b.isUse32BitAbi()); + assertEquals(a.is32BitAbiPreferred(), b.is32BitAbiPreferred()); assertEquals(a.getPackageName(), b.getPackageName()); assertArrayEquals(a.getSplitNames(), b.getSplitNames()); assertEquals(a.getVolumeUuid(), b.getVolumeUuid()); @@ -1039,7 +1039,7 @@ public class PackageParserTest { ((ParsedPackage) pkg.setBaseRevisionCode(100) .setHardwareAccelerated(true) - .setSharedUserLabelRes(100) + .setSharedUserLabelResourceId(100) .setInstallLocation(100) .setRequiredForAllUsers(true) .asSplit( @@ -1048,7 +1048,7 @@ public class PackageParserTest { new int[]{100}, null ) - .setUse32BitAbi(true) + .set32BitAbiPreferred(true) .setVolumeUuid("d52ef59a-7def-4541-bf21-4c28ed4b65a0") .addPermission(permission) .addPermissionGroup(new ParsedPermissionGroupImpl()) diff --git a/services/tests/PackageManagerServiceTests/unit/src/com/android/server/pm/test/parsing/parcelling/AndroidPackageTest.kt b/services/tests/PackageManagerServiceTests/unit/src/com/android/server/pm/test/parsing/parcelling/AndroidPackageTest.kt index 0b7020c74f66..6d3cdffda837 100644 --- a/services/tests/PackageManagerServiceTests/unit/src/com/android/server/pm/test/parsing/parcelling/AndroidPackageTest.kt +++ b/services/tests/PackageManagerServiceTests/unit/src/com/android/server/pm/test/parsing/parcelling/AndroidPackageTest.kt @@ -155,7 +155,7 @@ class AndroidPackageTest : ParcelableComponentTest(AndroidPackage::class, Packag AndroidPackage::getAppComponentFactory, AndroidPackage::getAutoRevokePermissions, AndroidPackage::getBackupAgentName, - AndroidPackage::getBannerRes, + AndroidPackage::getBannerResourceId, AndroidPackage::getBaseApkPath, AndroidPackage::getBaseRevisionCode, AndroidPackage::getCategory, @@ -163,16 +163,16 @@ class AndroidPackageTest : ParcelableComponentTest(AndroidPackage::class, Packag AndroidPackage::getCompatibleWidthLimitDp, AndroidPackage::getCompileSdkVersion, AndroidPackage::getCompileSdkVersionCodeName, - AndroidPackage::getDataExtractionRulesRes, - AndroidPackage::getDescriptionRes, - AndroidPackage::getFullBackupContentRes, + AndroidPackage::getDataExtractionRulesResourceId, + AndroidPackage::getDescriptionResourceId, + AndroidPackage::getFullBackupContentResourceId, AndroidPackage::getGwpAsanMode, - AndroidPackage::getIconRes, + AndroidPackage::getIconResourceId, AndroidPackage::getInstallLocation, - AndroidPackage::getLabelRes, + AndroidPackage::getLabelResourceId, AndroidPackage::getLargestWidthLimitDp, - AndroidPackage::getLogoRes, - AndroidPackage::getLocaleConfigRes, + AndroidPackage::getLogoResourceId, + AndroidPackage::getLocaleConfigResourceId, AndroidPackage::getManageSpaceActivityName, AndroidPackage::getMaxSdkVersion, AndroidPackage::getMemtagMode, @@ -180,7 +180,7 @@ class AndroidPackageTest : ParcelableComponentTest(AndroidPackage::class, Packag AndroidPackage::getNativeHeapZeroInitialized, AndroidPackage::getNativeLibraryDir, AndroidPackage::getNativeLibraryRootDir, - AndroidPackage::getNetworkSecurityConfigRes, + AndroidPackage::getNetworkSecurityConfigResourceId, AndroidPackage::getNonLocalizedLabel, AndroidPackage::getOverlayCategory, AndroidPackage::getOverlayPriority, @@ -195,11 +195,11 @@ class AndroidPackageTest : ParcelableComponentTest(AndroidPackage::class, Packag AndroidPackage::getRequiresSmallestWidthDp, AndroidPackage::getResizeableActivity, AndroidPackage::getRestrictedAccountType, - AndroidPackage::getRoundIconRes, + AndroidPackage::getRoundIconResourceId, PackageImpl::getSecondaryCpuAbi, AndroidPackage::getSecondaryNativeLibraryDir, AndroidPackage::getSharedUserId, - AndroidPackage::getSharedUserLabelRes, + AndroidPackage::getSharedUserLabelResourceId, AndroidPackage::getSdkLibraryName, AndroidPackage::getSdkLibVersionMajor, AndroidPackage::getStaticSharedLibraryName, @@ -207,21 +207,21 @@ class AndroidPackageTest : ParcelableComponentTest(AndroidPackage::class, Packag AndroidPackage::getTargetSandboxVersion, AndroidPackage::getTargetSdkVersion, AndroidPackage::getTaskAffinity, - AndroidPackage::getThemeRes, + AndroidPackage::getThemeResourceId, AndroidPackage::getUiOptions, AndroidPackage::getUid, AndroidPackage::getVersionName, AndroidPackage::getZygotePreloadName, AndroidPackage::isAllowAudioPlaybackCapture, - AndroidPackage::isAllowBackup, - AndroidPackage::isAllowClearUserData, - AndroidPackage::isAllowClearUserDataOnFailedRestore, + AndroidPackage::isBackupAllowed, + AndroidPackage::isClearUserDataAllowed, + AndroidPackage::isClearUserDataOnFailedRestoreAllowed, AndroidPackage::isAllowNativeHeapPointerTagging, - AndroidPackage::isAllowTaskReparenting, + AndroidPackage::isTaskReparentingAllowed, AndroidPackage::isAllowUpdateOwnership, AndroidPackage::isBackupInForeground, AndroidPackage::isHardwareAccelerated, - AndroidPackage::isCantSaveState, + AndroidPackage::isSaveStateDisallowed, AndroidPackage::isCoreApp, AndroidPackage::isCrossProfile, AndroidPackage::isDebuggable, @@ -229,17 +229,17 @@ class AndroidPackageTest : ParcelableComponentTest(AndroidPackage::class, Packag AndroidPackage::isDirectBootAware, AndroidPackage::isEnabled, AndroidPackage::isExternalStorage, - AndroidPackage::isExtractNativeLibs, + AndroidPackage::isExtractNativeLibrariesRequested, AndroidPackage::isFactoryTest, AndroidPackage::isApex, AndroidPackage::isForceQueryable, AndroidPackage::isFullBackupOnly, AndroidPackage::isGame, - AndroidPackage::isHasCode, + AndroidPackage::isDeclaredHavingCode, AndroidPackage::isHasDomainUrls, - AndroidPackage::isHasFragileUserData, + AndroidPackage::isUserDataFragile, AndroidPackage::isIsolatedSplitLoading, - AndroidPackage::isKillAfterRestore, + AndroidPackage::isKillAfterRestoreAllowed, AndroidPackage::isLargeHeap, AndroidPackage::isMultiArch, AndroidPackage::isNativeLibraryRootRequiresIsa, @@ -257,12 +257,12 @@ class AndroidPackageTest : ParcelableComponentTest(AndroidPackage::class, Packag AndroidPackage::isSdkLibrary, AndroidPackage::isStaticSharedLibrary, AndroidPackage::isStub, - AndroidPackage::isSupportsRtl, + AndroidPackage::isRtlSupported, AndroidPackage::isTestOnly, - AndroidPackage::isUse32BitAbi, + AndroidPackage::is32BitAbiPreferred, AndroidPackage::isUseEmbeddedDex, - AndroidPackage::isUsesCleartextTraffic, - AndroidPackage::isUsesNonSdkApi, + AndroidPackage::isCleartextTrafficAllowed, + AndroidPackage::isNonSdkApiRequested, AndroidPackage::isVisibleToInstantApps, AndroidPackage::isVmSafeMode, AndroidPackage::isLeavingSharedUser, @@ -282,10 +282,10 @@ class AndroidPackageTest : ParcelableComponentTest(AndroidPackage::class, Packag getter(AndroidPackage::getUpgradeKeySets, setOf("testUpgradeKeySet")), getter(AndroidPackage::isAnyDensity, false, 0), getter(AndroidPackage::isResizeable, false, 0), - getter(AndroidPackage::isSupportsSmallScreens, false, 0), - getter(AndroidPackage::isSupportsNormalScreens, false, 0), - getter(AndroidPackage::isSupportsLargeScreens, false, 0), - getter(AndroidPackage::isSupportsExtraLargeScreens, false, 0), + getter(AndroidPackage::isSmallScreensSupported, false, 0), + getter(AndroidPackage::isNormalScreensSupported, false, 0), + getter(AndroidPackage::isLargeScreensSupported, false, 0), + getter(AndroidPackage::isExtraLargeScreensSupported, false, 0), adder(AndroidPackage::getAdoptPermissions, "test.adopt.PERMISSION"), adder(AndroidPackage::getOriginalPackages, "com.test.original"), adder(AndroidPackage::getImplicitPermissions, "test.implicit.PERMISSION"), diff --git a/services/tests/PackageManagerServiceTests/unit/src/com/android/server/pm/test/pkg/PackageStateTest.kt b/services/tests/PackageManagerServiceTests/unit/src/com/android/server/pm/test/pkg/PackageStateTest.kt index 8a855e51fc3d..5a733c7ea117 100644 --- a/services/tests/PackageManagerServiceTests/unit/src/com/android/server/pm/test/pkg/PackageStateTest.kt +++ b/services/tests/PackageManagerServiceTests/unit/src/com/android/server/pm/test/pkg/PackageStateTest.kt @@ -312,4 +312,4 @@ class PackageStateTest { .that(exception) .isNotNull() } -}
\ No newline at end of file +} diff --git a/services/tests/mockingservicestests/src/com/android/server/pm/PackageManagerServiceHibernationTests.kt b/services/tests/mockingservicestests/src/com/android/server/pm/PackageManagerServiceHibernationTests.kt index b9893f6ee170..f1acf663eae1 100644 --- a/services/tests/mockingservicestests/src/com/android/server/pm/PackageManagerServiceHibernationTests.kt +++ b/services/tests/mockingservicestests/src/com/android/server/pm/PackageManagerServiceHibernationTests.kt @@ -147,12 +147,12 @@ class PackageManagerServiceHibernationTests { TEST_PACKAGE_NAME, 1L, rule.system().dataAppDirectory, - withPackage = { it.apply { isHasCode = true } }) + withPackage = { it.apply { isDeclaredHavingCode = true } }) rule.system().stageScanExistingPackage( TEST_PACKAGE_2_NAME, 1L, rule.system().dataAppDirectory, - withPackage = { it.apply { isHasCode = true } }) + withPackage = { it.apply { isDeclaredHavingCode = true } }) val pm = createPackageManagerService() rule.system().validateFinalState() whenever(appHibernationManager.isHibernatingGlobally(TEST_PACKAGE_2_NAME)).thenReturn(true) |