diff options
| author | 2019-06-03 20:31:59 +0000 | |
|---|---|---|
| committer | 2019-06-03 20:31:59 +0000 | |
| commit | f5671d390d0dfebec37f62bfff7228cd23cd1b59 (patch) | |
| tree | 46c27142c99eb9b5eb2832f462f4e5d0b578f684 | |
| parent | aac39e204d05be8ec760ba9fac72f1ffd47a6260 (diff) | |
| parent | 56db15b8437e2e3bda63e19c30a87c56fa1dfde6 (diff) | |
Merge "Remove stopship for idmap2 vendor sdk checking" into qt-dev
| -rw-r--r-- | cmds/idmap2/idmap2/Scan.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/cmds/idmap2/idmap2/Scan.cpp b/cmds/idmap2/idmap2/Scan.cpp index 83c034b4bc42..21c6bd280064 100644 --- a/cmds/idmap2/idmap2/Scan.cpp +++ b/cmds/idmap2/idmap2/Scan.cpp @@ -68,9 +68,10 @@ struct InputOverlay { }; bool VendorIsQOrLater() { - // STOPSHIP(b/119390857): Check api version once Q sdk version is finalized - std::string version = android::base::GetProperty("ro.vndk.version", "Q"); - return version == "Q" || version == "q"; + constexpr int kQSdkVersion = 29; + int version = std::atoi(android::base::GetProperty("ro.vndk.version", "29").data()); + // If the string cannot be parsed, it is a development sdk codename. + return version >= kQSdkVersion || version == 0; } Result<std::unique_ptr<std::vector<std::string>>> FindApkFiles(const std::vector<std::string>& dirs, |